Re: FreeBSD Port: net/realtek-re-kmod

From: Mike Jakubik <mike.jakubik_at_gmail.com>
Date: Sun, 01 Dec 2024 14:09:40 UTC
Indeed, compiles cleanly and works fine on this system. Thank you sir!

FreeBSD fbsd15.localdomain 15.0-CURRENT FreeBSD 15.0-CURRENT #0 
main-e8d027be6: Fri Nov 29 20:19:55 EST 2024 
mike@fbsd15.localdomain:/usr/obj/usr/src/amd64.amd64/sys/GENERIC-NODEBUG 
amd64

[root@fbsd15 /usr/ports/net/realtek-re-kmod]# make
===>  License BSD4CLAUSE accepted by the user
===>   realtek-re-kmod-1100.00_1 depends on file: /usr/local/sbin/pkg - 
found
===> Fetching all distfiles required by realtek-re-kmod-1100.00_1 for 
building
===>  Extracting for realtek-re-kmod-1100.00_1
=> SHA256 Checksum OK for alexdupre-rtl_bsd_drv-v1100.00-ea4ed1e_GH0.tar.gz.
===>  Patching for realtek-re-kmod-1100.00_1
===>  Applying extra patch 
/usr/ports/net/realtek-re-kmod/files/extra-patch-if__re.c
===>  Configuring for realtek-re-kmod-1100.00_1
===>  Building for realtek-re-kmod-1100.00_1
--- machine ---
--- x86 ---
--- i386 ---
--- objwarn ---
Warning: Object directory not changed from original 
/usr/ports/net/realtek-re-kmod/work/rtl_bsd_drv-ea4ed1e
--- machine ---
machine -> /usr/src/sys/amd64/include
--- x86 ---
x86 -> /usr/src/sys/x86/include
--- i386 ---
i386 -> /usr/src/sys/i386/include
--- opt_bdg.h ---
--- opt_inet.h ---
--- opt_inet6.h ---
--- opt_global.h ---
--- device_if.h ---
--- bus_if.h ---
--- pci_if.h ---
--- opt_bdg.h ---
:> opt_bdg.h
--- opt_global.h ---
touch opt_global.h
--- device_if.h ---
awk -f /usr/src/sys/tools/makeobjops.awk /usr/src/sys/kern/device_if.m -h
--- bus_if.h ---
awk -f /usr/src/sys/tools/makeobjops.awk /usr/src/sys/kern/bus_if.m -h
--- pci_if.h ---
awk -f /usr/src/sys/tools/makeobjops.awk /usr/src/sys/dev/pci/pci_if.m -h
--- if_re.o ---
cc  -O2 -pipe -march=znver4 -fno-strict-aliasing 
-DENABLE_INTERRUPT_MITIGATIN  -Werror -D_KERNEL -DKLD_MODULE -nostdinc   
-include 
/usr/ports/net/realtek-re-kmod/work/rtl_bsd_drv-ea4ed1e/opt_global.h -I. 
-I/usr/src/sys -I/usr/src/sys/contrib/ck/include -fno-common 
-fno-omit-frame-pointer -mno-omit-leaf-frame-pointer 
-fdebug-prefix-map=./machine=/usr/src/sys/amd64/include 
-fdebug-prefix-map=./x86=/usr/src/sys/x86/include 
-fdebug-prefix-map=./i386=/usr/src/sys/i386/include    -MD 
-MF.depend.if_re.o -MTif_re.o -mcmodel=kernel -mno-red-zone -mno-mmx 
-mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding 
-fwrapv -fstack-protector  -Wall -Wstrict-prototypes 
-Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef 
-Wno-pointer-sign -D__printf__=__freebsd_kprintf__ 
-Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas 
-Wswitch -Wno-error=tautological-compare -Wno-error=empty-body 
-Wno-error=parentheses-equality -Wno-error=unused-function 
-Wno-error=pointer-sign -Wno-error=shift-negative-value 
-Wno-address-of-packed-member -Wno-format-zero-length   -mno-aes 
-mno-avx  -std=gnu99 -c if_re.c -o if_re.o
--- if_re.ko ---
ld -m elf_x86_64_fbsd -warn-common --build-id=sha1 -T 
/usr/src/sys/conf/ldscript.kmod.amd64 -r  -o if_re.ko if_re.o
:> export_syms
awk -f /usr/src/sys/conf/kmod_syms.awk if_re.ko  export_syms | xargs -J 
% objcopy % if_re.ko
objcopy --strip-debug if_re.ko
===>  Staging for realtek-re-kmod-1100.00_1
===>   Generating temporary packing list
install -T release -o root -g wheel -m 444   if_re.ko 
/usr/ports/net/realtek-re-kmod/work/stage/boot/modules/
====> Compressing man pages (compress-man)
[root@fbsd15 /usr/ports/net/realtek-re-kmod]# make reinstall clean


On 12/1/24 08:51, Mike Jakubik wrote:
>
> Oh OK, sorry missed that, will test and report.
>
> Thanks!
>
> On 2024-12-01 4:58 a.m., Ronald Klop wrote:
>> I think a quick fix for your problem was committed a few days ago 
>> (Nov 28).
>>
>> https://cgit.freebsd.org/ports/commit/?id=4ca9ea9d4060a4a494456a0e56306bd508fe20e8
>>
>> Regards,
>> Ronald.
>>
>> *Van:* Mike Jakubik <mike.jakubik@gmail.com>
>> *Datum:* zondag, 1 december 2024 01:59
>> *Aan:* ale@FreeBSD.org, freebsd-net@freebsd.org
>> *Onderwerp:* FreeBSD Port: net/realtek-re-kmod
>>
>>     Any update on this from upstream maybe? Seems like an easy fix, I
>>     got new system that needs this driver too (Realtek 5Gb).
>>
>>     Ty.
>>
>>
>>     Hello,
>>
>>
>>     Seems like it wont compile on recent current, noticed about  2
>>     days ago and /usr/src/sys/sys/mbuf.h hasnt been touched it seems.
>>
>>     15.0-CURRENT FreeBSD 15.0-CURRENT #0 main-56043cbfdd: Thu Nov 21
>>     20:30:44 EST 2024
>>
>>
>>     [root@fbsd15 /usr/ports/net/realtek-re-kmod]# make
>>     MAKE_JOBS_UNSAFE=yes
>>     ===>  Building for realtek-re-kmod-1100.00_1
>>     Warning: Object directory not changed from original
>>     /usr/ports/net/realtek-re-kmod/work/rtl_bsd_drv-ea4ed1e
>>     cc  -O2 -pipe -fno-strict-aliasing -DENABLE_INTERRUPT_MITIGATIN
>>     -Werror -D_KERNEL -DKLD_MODULE -nostdinc   -include
>>     /usr/ports/net/realtek-re-kmod/work/rtl_bsd_drv-ea4ed1e/opt_global.h
>>     -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -fno-common
>>     -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer
>>     -fdebug-prefix-map=./machine=/usr/src/sys/amd64/include
>>     -fdebug-prefix-map=./x86=/usr/src/sys/x86/include
>>     -fdebug-prefix-map=./i386=/usr/src/sys/i386/include    -MD
>>     -MF.depend.if_re.o -MTif_re.o -mcmodel=kernel -mno-red-zone
>>     -mno-mmx -mno-sse -msoft-float -fno-asynchronous-unwind-tables
>>     -ffreestanding -fwrapv -fstack-protector  -Wall
>>     -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith
>>     -Wcast-qual -Wundef -Wno-pointer-sign
>>     -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs
>>     -fdiagnostics-show-option -Wno-unknown-pragmas -Wswitch
>>     -Wno-error=tautological-compare -Wno-error=empty-body
>>     -Wno-error=parentheses-equality -Wno-error=unused-function
>>     -Wno-error=pointer-sign -Wno-error=shift-negative-value
>>     -Wno-address-of-packed-member -Wno-format-zero-length -mno-aes
>>     -mno-avx  -std=gnu99 -c if_re.c -o if_re.o
>>     if_re.c:1270:37: error: incomplete definition of type 'struct ifnet'
>>     1270 |         sc->re_rx_desc_buf_sz = (ifp->if_mtu > ETHERMTU) ?
>>     ifp->if_mtu: ETHERMTU;
>>     |                                  ~~~^
>>     /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of
>>     'struct ifnet'
>>     139 |         struct ifnet *ifp;              /* network
>>     interface tag belongs to */
>>     |                ^
>>     if_re.c:1270:63: error: incomplete definition of type 'struct ifnet'
>>     1270 |         sc->re_rx_desc_buf_sz = (ifp->if_mtu > ETHERMTU) ?
>>     ifp->if_mtu: ETHERMTU;
>>     |                                                            ~~~^
>>     /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of
>>     'struct ifnet'
>>     139 |         struct ifnet *ifp;              /* network
>>     interface tag belongs to */
>>     |                ^
>>     if_re.c:4562:60: error: incomplete definition of type 'struct ifnet'
>>     4562 |                 printf("if_drv_flags\t0x%08x\n",
>>     sc->re_ifp->if_drv_flags);
>>     | ~~~~~~~~~~^
>>     /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of
>>     'struct ifnet'
>>     139 |         struct ifnet *ifp;              /* network
>>     interface tag belongs to */
>>     |                ^
>>     if_re.c:4622:43: error: call to undeclared function 'IF_LLADDR';
>>     ISO C99 and later do not support implicit function declarations
>>     [-Werror,-Wimplicit-function-declaration]
>>     4622 |                 printf("dev_addr\t%6D\n",
>>     IF_LLADDR(sc->re_ifp), ":");
>>     |                                           ^
>>     if_re.c:4622:43: error: format specifies type 'void *' but the
>>     argument has type 'int' [-Werror,-Wformat]
>>     4622 |                 printf("dev_addr\t%6D\n",
>>     IF_LLADDR(sc->re_ifp), ":");
>>     |                                   ~~~ ^~~~~~~~~~~~~~~~~~~~~
>>     if_re.c:4662:32: error: incomplete definition of type 'struct ifnet'
>>     4662 |                 if ((sc->re_ifp->if_drv_flags &
>>     IFF_DRV_RUNNING) == 0) {
>>     |                      ~~~~~~~~~~^
>>     /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of
>>     'struct ifnet'
>>     139 |         struct ifnet *ifp;              /* network
>>     interface tag belongs to */
>>     |                ^
>>     if_re.c:5522:12: error: incomplete definition of type 'struct ifnet'
>>     5522 |         ifp->if_softc = sc;
>>     |         ~~~^
>>     /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of
>>     'struct ifnet'
>>     139 |         struct ifnet *ifp;              /* network
>>     interface tag belongs to */
>>     |                ^
>>     if_re.c:5529:12: error: incomplete definition of type 'struct ifnet'
>>     5529 |         ifp->if_mtu = ETHERMTU;
>>     |         ~~~^
>>     /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of
>>     'struct ifnet'
>>     139 |         struct ifnet *ifp;              /* network
>>     interface tag belongs to */
>>     |                ^
>>     if_re.c:5530:12: error: incomplete definition of type 'struct ifnet'
>>     5530 |         ifp->if_flags = IFF_BROADCAST | IFF_SIMPLEX |
>>     IFF_MULTICAST;
>>     |         ~~~^
>>     /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of
>>     'struct ifnet'
>>     139 |         struct ifnet *ifp;              /* network
>>     interface tag belongs to */
>>     |                ^
>>     if_re.c:5531:12: error: incomplete definition of type 'struct ifnet'
>>     5531 |         ifp->if_ioctl = re_ioctl;
>>     |         ~~~^
>>     /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of
>>     'struct ifnet'
>>     139 |         struct ifnet *ifp;              /* network
>>     interface tag belongs to */
>>     |                ^
>>     if_re.c:5532:12: error: incomplete definition of type 'struct ifnet'
>>     5532 |         ifp->if_output = ether_output;
>>     |         ~~~^
>>     /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of
>>     'struct ifnet'
>>     139 |         struct ifnet *ifp;              /* network
>>     interface tag belongs to */
>>     |                ^
>>     if_re.c:5533:12: error: incomplete definition of type 'struct ifnet'
>>     5533 |         ifp->if_start = re_start;
>>     |         ~~~^
>>     /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of
>>     'struct ifnet'
>>     139 |         struct ifnet *ifp;              /* network
>>     interface tag belongs to */
>>     |                ^
>>     if_re.c:5538:20: error: incomplete definition of type 'struct ifnet'
>>     5538 |                 ifp->if_hwassist |= CSUM_TCP | CSUM_UDP;
>>     |                 ~~~^
>>     /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of
>>     'struct ifnet'
>>     139 |         struct ifnet *ifp;              /* network
>>     interface tag belongs to */
>>     |                ^
>>     if_re.c:5540:20: error: incomplete definition of type 'struct ifnet'
>>     5540 |                 ifp->if_hwassist |= RE_CSUM_FEATURES;
>>     |                 ~~~^
>>     /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of
>>     'struct ifnet'
>>     139 |         struct ifnet *ifp;              /* network
>>     interface tag belongs to */
>>     |                ^
>>     if_re.c:5541:12: error: incomplete definition of type 'struct ifnet'
>>     5541 |         ifp->if_capabilities = IFCAP_HWCSUM |
>>     IFCAP_HWCSUM_IPV6;
>>     |         ~~~^
>>     /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of
>>     'struct ifnet'
>>     139 |         struct ifnet *ifp;              /* network
>>     interface tag belongs to */
>>     |                ^
>>     if_re.c:5544:20: error: incomplete definition of type 'struct ifnet'
>>     5544 |                 ifp->if_hwassist |= CSUM_TSO;
>>     |                 ~~~^
>>     /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of
>>     'struct ifnet'
>>     139 |         struct ifnet *ifp;              /* network
>>     interface tag belongs to */
>>     |                ^
>>     if_re.c:5545:20: error: incomplete definition of type 'struct ifnet'
>>     5545 |                 ifp->if_capabilities |= IFCAP_TSO;
>>     |                 ~~~^
>>     /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of
>>     'struct ifnet'
>>     139 |         struct ifnet *ifp;              /* network
>>     interface tag belongs to */
>>     |                ^
>>     if_re.c:5549:20: error: incomplete definition of type 'struct ifnet'
>>     5549 |                 ifp->if_hwassist &= ~(CSUM_IP6_TSO |
>>     |                 ~~~^
>>     /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of
>>     'struct ifnet'
>>     139 |         struct ifnet *ifp;              /* network
>>     interface tag belongs to */
>>     |                ^
>>     if_re.c:5552:20: error: incomplete definition of type 'struct ifnet'
>>     5552 |                 ifp->if_capabilities &= ~(IFCAP_TSO6 |
>>     IFCAP_HWCSUM_IPV6);
>>     |                 ~~~^
>>     /usr/src/sys/sys/mbuf.h:139:9: note: forward declaration of
>>     'struct ifnet'
>>     139 |         struct ifnet *ifp;              /* network
>>     interface tag belongs to */
>>     |                ^
>>     fatal error: too many errors emitted, stopping now [-ferror-limit=]
>>     20 errors generated.
>>     *** Error code 1
>>
>>     Stop.
>>     make: stopped making "all" in
>>     /usr/ports/net/realtek-re-kmod/work/rtl_bsd_drv-ea4ed1e
>>     *** Error code 1
>>
>>     Stop.
>>     make: stopped making "all" in /usr/ports/net/realtek-re-kmod
>>     [root@fbsd15 /usr/ports/net/realtek-re-kmod]#
>>
>>
>>     ------------------------------------------------------------------------
>>
>>