From nobody Tue Aug 27 11:42:26 2024 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WtQdH3p4Mz5Vb5M for ; Tue, 27 Aug 2024 11:42:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WtQdH2mYnz4q5j for ; Tue, 27 Aug 2024 11:42:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724758947; a=rsa-sha256; cv=none; b=szzpcq2L7ji238S1qDGZkV4Ft+Qh7AevJco8219hhg4NIUwHPbJJxaHWth26AgU+9DfXLF 7RVtiwUwwByo447u8vUjwUY1i4wFG/p7gmpcy24iEj39oPOXKjoFsDV3qBzUal5DyUHNvC 5SDCB2tvpp1afl9QjWFRLwyvpxgCh7sSzDf8oRbwmJ23bj7EBQk64t+OD128DbKc7G1Z59 rZSpFNp/kk330D1o8y8kDaTRkUAm2QaWgIUCxdMxpVrF4R9GHUNftI7P/e7j0woXOUlulY drg+ee6Tl1Wai8JaAGTOHjZklMrrpsWZc/kBEJXEEw4n06smh6y21v+G30bMsA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724758947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CYykLDnxCEIqzanPLtNicZerLTZUG0XBdum4rD17pTA=; b=ZKlWMcD6SHpATiEhxKDhNqp9/JFnrApTGjQTz/rQtglihmOjz0Sct7MgLupwpRf3GhfNKs ewdLLqHScAdenoBbYGCiTRBTLuw7ptqEiCd2ucRn1yRxahlVbFe8WmxdkhOdS9EY8kOP4y g5V5sgLNUIxC/ePRHFBmaQ6yQts8SC0Ato2bY/wTXqM3+3CUxMd400HCOeLqb5vc/Ufs8I TMO8JkC4HITO8oUQhNo9lZi4gr28vVzmMJFeKy6z6z5AiTC8iqWDk864/IpcAhbLVN+uty WeAzivgo0eORJcMB3JNFIaGQ6fEjRQMFBh7OMwRsae5tUxNafp//gV/3xtkuWg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WtQdH2Lwbzph5 for ; Tue, 27 Aug 2024 11:42:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 47RBgRp8068437 for ; Tue, 27 Aug 2024 11:42:27 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 47RBgRLG068436 for net@FreeBSD.org; Tue, 27 Aug 2024 11:42:27 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 280701] FreeBSD-SA-24:05 fix breaks ICMP/ICMP6 states handling in pf firewall (ping, traceroute) Date: Tue, 27 Aug 2024 11:42:26 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.1-RELEASE X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: franco@opnsense.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280701 --- Comment #58 from Franco Fichtner --- I found these inconsistencies in the ported patches from OpenBSD: diff --git a/sys/netpfil/pf/pf.c b/sys/netpfil/pf/pf.c index ef488bad26d..c9180e877d5 100644 --- a/sys/netpfil/pf/pf.c +++ b/sys/netpfil/pf/pf.c @@ -1878,7 +1878,7 @@ pf_icmp_mapping(struct pf_pdesc *pd, u_int8_t type, */ *icmp_dir =3D PF_IN; *virtual_type =3D MLD_LISTENER_QUERY; - *virtual_id =3D 0; + *virtual_id =3D 0; /* XXX missing fake id */ break; } case MLD_MTRACE: @@ -1892,7 +1892,8 @@ pf_icmp_mapping(struct pf_pdesc *pd, u_int8_t type, *icmp_dir =3D PF_IN; case ND_NEIGHBOR_ADVERT: { *virtual_type =3D ND_NEIGHBOR_SOLICIT; - *virtual_id =3D 0; + *multi =3D PF_ICMP_MULTI_SOLICITED; + *virtual_id =3D 0; /* XXX missing fake id */ break; } From early testing, however, it's not working any better with plugging back PF_ICMP_MULTI_SOLICITED only. I'm unsure about the mock id effect. But wh= at I can say is that it's better to skip dealing with PF_ICMP_MULTI_SOLICITED as OpenBSD did in 2012 too: https://github.com/openbsd/src/commit/2633ae8c4c8a64 Another patch from 2023 is relevant as well as it disables half the state tracking for unsolicited advertise cases: https://github.com/openbsd/src/commit/49f39043a02d6 --=20 You are receiving this mail because: You are the assignee for the bug.=