From nobody Wed Aug 21 07:45:08 2024 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WpdfG1kq5z5TNrL for ; Wed, 21 Aug 2024 07:45:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WpdfG0BVFz4TbC for ; Wed, 21 Aug 2024 07:45:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724226310; a=rsa-sha256; cv=none; b=Q/Vi1zjv3DyCW0CHIJE6yhfGezYxodq2167cJIUn/DDfySaRMf0TAE7N2RZTfDUcmAN01h 8gDG0LqUqVhK07sNVgd8D3Dmj0I7ZHYcgzanDKDiS0Kjbd202FOA6dIQ/vNuEWLtwFFjp9 Y8jdDsnnXyix0PE+xj0baQ85APchSF0DbipeH1g/sX1Cpa75xb7nWEh1PgQZ7xH5ztuUj6 tM8tpUndozUD02Kss5y9EquPYnWOIJ+faKCBu3N8YK0cgNaKb02RIlY71wJSPBycR4qxlB I2iAdcwXo2duvgkuEbWbWDejJn3RDn8fD0Bi+yo/dvp4Lb0MvplcxMRpT5ShLw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724226310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h/5Anw5D5UjP2p4YnePV+D7AOcfzqy2iFlOIBinGI9c=; b=qZDMwBGcb3AOSPv/H1IWznlvNY/REiNNTC+RLJ9Qh/eSax6lLZ7hKviFzAB6WBvhTbuf3m p6RTw71Tk4MVhBiFuulOhVTYQhlRHincax5SoC51kt1v/cbR5n+w3tAOTgjDwcYiA4O74k EBvnYobr5YpbdFIZusjeEPsTVjkA/0E/AER4wnJbUibTMbrCA4/NdnCmPHpdQOEs1ynXu+ rqEb77RMledAu7rskU9eayw3lWYjsj5aXeE0ycl9ybDZzX+Y0HXhu0/CToB6XikcZhuquI 2rw4CB13uJZfJpxCsh5+qqhRw7FkXRHTlj4gmnpP7rvrgsxDjqsVAGcY5xjsbg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WpdfF6VL8zZt7 for ; Wed, 21 Aug 2024 07:45:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 47L7j9Wb024437 for ; Wed, 21 Aug 2024 07:45:09 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 47L7j9jm024436 for net@FreeBSD.org; Wed, 21 Aug 2024 07:45:09 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 280701] FreeBSD-SA-24:05 fix breaks ICMP/ICMP6 states handling in pf firewall (ping, traceroute) Date: Wed, 21 Aug 2024 07:45:08 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.1-RELEASE X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280701 --- Comment #29 from commit-hook@FreeBSD.org --- A commit in branch releng/13.4 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D9c67287ccfb7257d140b46c8d8aed7276= c94d5f1 commit 9c67287ccfb7257d140b46c8d8aed7276c94d5f1 Author: Kristof Provost AuthorDate: 2024-08-14 09:29:30 +0000 Commit: Kristof Provost CommitDate: 2024-08-21 07:44:25 +0000 pf: invert direction for inner icmp state lookups (e.g. traceroute with icmp) ok henning, jsing Also extend the test case to cover this scenario. PR: 280701 Approved by: re (cperciva) Obtained from: OpenBSD MFC after: 1 week Sponsored by: Rubicon Communications, LLC ("Netgate") (cherry picked from commit 89f6723288b0d27d3f14f93e6e83f672fa2b8aca) (cherry picked from commit 5f3f07397a7909e8f9449d1aa0b465159cbf0d60) sys/netpfil/pf/pf.c | 21 +++++++++++---------- tests/sys/netpfil/pf/icmp.sh | 4 +++- tests/sys/netpfil/pf/icmp6.sh | 4 +++- 3 files changed, 17 insertions(+), 12 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=