From nobody Tue Aug 20 15:16:37 2024 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WpCjf4NsMz5TJLP for ; Tue, 20 Aug 2024 15:16:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WpCjd6sKQz4vwk for ; Tue, 20 Aug 2024 15:16:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724166998; a=rsa-sha256; cv=none; b=FQUDTXdALf1GLVDybq+DzMuc/ZYBkRxeEAJHcklVVAFgLV9NOtQERtyO8e2u6t1WGQdUmI DGFIrcdiSTIsfNYYBQQnk2UwGn9EaUwVbr2X1Tm6+aEeYg2ZS87ag0fa9rh5WOWm+cGkft Mwt8ShFFJ+8h2ILMtnPRNALkFyxme3yEJy30ZjF21LF17d7P8zzoMI9Xdh/YV6R4/7l0dp S7SbEzWrqfeOtns9zmW/R3377Lx3hSgxwfYNxUUZ/7yP9WGHsJDtYmCs4ZZVgabV+giXN2 ADaJ02kstvSrPrQJjcgc1SFnEhBGaE01RFR3iEQp/adrir2FJM38vJV44m1Y9A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724166998; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZDfs9xVKD2PjgBwmV1q98JlOxSySUDSf3pSKpv2FeLg=; b=vdoVCmwxbpR2mmsGiW40DUym/83UFoOV+FSOc8RlDT1Tz/jenIZk3XJbNu8Ic7rtLDoScf gF5A9w8VKfZiKmnC37EBRC6d9HIa+nrrNLNUzkU8dchaCJBkYhRuzTeJ71OXdBP7pcwRjO gRSMXY4n9HKo3V8vVEKOe/xK5NS/3VfGWXLpHhVnjlGvC5jm1exDNL3cSMWcqD/RhafaZo sBH03Yy+AkhJK7tcHgkhROAUioqPDQXLkslqN5wCvS2TAmnMWl/qBgMRFkZDQjKljNg9Nx bQsoOHGogtKfeLgO1SXEbfkbh2eRQBBUTvUIJQ0Zczg6ybmt4Q41fFTvj/l/ww== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WpCjd68qbz15Bp for ; Tue, 20 Aug 2024 15:16:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 47KFGbtt034378 for ; Tue, 20 Aug 2024 15:16:37 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 47KFGbx1034375 for net@FreeBSD.org; Tue, 20 Aug 2024 15:16:37 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 280701] FreeBSD-SA-24:05 fix breaks ICMP/ICMP6 states handling in pf firewall (ping, traceroute) Date: Tue, 20 Aug 2024 15:16:37 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.1-RELEASE X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280701 --- Comment #25 from commit-hook@FreeBSD.org --- A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D5f3f07397a7909e8f9449d1aa0b465159= cbf0d60 commit 5f3f07397a7909e8f9449d1aa0b465159cbf0d60 Author: Kristof Provost AuthorDate: 2024-08-14 09:29:30 +0000 Commit: Kristof Provost CommitDate: 2024-08-20 07:25:21 +0000 pf: invert direction for inner icmp state lookups (e.g. traceroute with icmp) ok henning, jsing Also extend the test case to cover this scenario. PR: 280701 Obtained from: OpenBSD MFC after: 1 week Sponsored by: Rubicon Communications, LLC ("Netgate") (cherry picked from commit 89f6723288b0d27d3f14f93e6e83f672fa2b8aca) sys/netpfil/pf/pf.c | 21 +++++++++++---------- tests/sys/netpfil/pf/icmp.sh | 4 +++- tests/sys/netpfil/pf/icmp6.sh | 4 +++- 3 files changed, 17 insertions(+), 12 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=