From nobody Tue Aug 20 15:16:27 2024 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WpCjT2VQCz5TJ92 for ; Tue, 20 Aug 2024 15:16:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WpCjT1RNqz4vpL for ; Tue, 20 Aug 2024 15:16:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724166989; a=rsa-sha256; cv=none; b=dEh0glKpIZWAb9rzZdiwjv0Yf+G3athwJRb9/BmJDcRKVl1AkAWRHISGAHvtNtEDO5Tq4q mmjDWEr5rf6bfBGj7GbZSMDrfHe7q4eFA2vVkQQHqilLYsOaZrkfPqoem1t5zn+crwbSxa SEPMJTGV4I+IIAAHSZaA2FQKkrE112npRezSSZHTfLyrBvZBqhNO+lQYGLgWcNOLa4wNL8 Ik+9InPdbXc//+EakXyQtluCxcA5oFI0ijra2D71oZa/gj3uY1U0q2fLWT1yzzqWKZ6CZR /ty15pYKVzTNTYf6uLqexekLlo3EJyt1WH7nCKoDXtfDSJjZIKywYWhhfWipXw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724166989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sYUtLOEvERc4JGrR+CAsWvvV4zwy5UGAS6gr/IiUHCc=; b=YKPlSybp19yIJokDRzxj8pW3E+kGbFCmNOMPNKVJeYok1+uRIz7+bvSk9OWLMjLNTYyu7w wR/FW4U9GLzbNcJmqiDO2mvSdchY7vrTAaGx3B5V1dbOnMk8tkxgWGLXkN4pvc7uvNdVlw +/XuELHsY8z+RBrdwaXHgQjlmFHLIvYCHqIMOAF/ohWqfpfS/0plso5wqfUkyqrY7CZCyQ NiWswju8sCEH7TLB922dMg/PajmlOWNBmcIqm8mFF/AHyDLNDyykHLboreLCwmQobGDR1T qF8kKSZlHCa8C/DuqR7inZZx8bkdk0uYSvEPYnUuIDfm8MfI0zzzu0oXZu5xBA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WpCjT13tbz155j for ; Tue, 20 Aug 2024 15:16:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 47KFGTlg033779 for ; Tue, 20 Aug 2024 15:16:29 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 47KFGT4i033777 for net@FreeBSD.org; Tue, 20 Aug 2024 15:16:29 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 280701] FreeBSD-SA-24:05 fix breaks ICMP/ICMP6 states handling in pf firewall (ping, traceroute) Date: Tue, 20 Aug 2024 15:16:27 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.1-RELEASE X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280701 --- Comment #22 from commit-hook@FreeBSD.org --- A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D46c4fc50d3012ca3c8756df243589add3= 6b70830 commit 46c4fc50d3012ca3c8756df243589add36b70830 Author: Kristof Provost AuthorDate: 2024-08-14 09:29:30 +0000 Commit: Kristof Provost CommitDate: 2024-08-20 15:15:10 +0000 pf: invert direction for inner icmp state lookups (e.g. traceroute with icmp) ok henning, jsing Also extend the test case to cover this scenario. PR: 280701 Obtained from: OpenBSD MFC after: 1 week Sponsored by: Rubicon Communications, LLC ("Netgate") (cherry picked from commit 89f6723288b0d27d3f14f93e6e83f672fa2b8aca) sys/netpfil/pf/pf.c | 21 +++++++++++---------- tests/sys/netpfil/pf/icmp.sh | 4 +++- tests/sys/netpfil/pf/icmp6.sh | 4 +++- 3 files changed, 17 insertions(+), 12 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=