From nobody Tue Aug 20 01:43:32 2024 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WnsgT0Dmxz5TyX1 for ; Tue, 20 Aug 2024 01:43:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WnsgS5gj5z41dc for ; Tue, 20 Aug 2024 01:43:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724118212; a=rsa-sha256; cv=none; b=Dxzl10TanbWDke6FdZx8G/7pCrVOTegj17eLZwRvf4CrIyGUZ+W30f3kIKxRcBBENoNwkK WTY4lVn/o3guo5uSjAFDQmmSRXmMBAx7IrY2Sx31BF/MuGtQWZyuoeR+H/lLe5yCtsp/UH xrfNPCV0eJ+4EjlihA4nS79Xqj2egk51EP5AlLz13iZ/0L3w1QUvuE33h6FLQbLESb4Cmy 4bk0HwpMf0d2q+/eOVwDrG5KHbGuZ+OK37y0m9rbzfspkpRBlL1jR5Mfe5u5KnTAAro8H+ 4gaeuQiwkbGRP8bJ68NJIw1ndp95QdTSU/fAMi5teDCnVCD3Q9x7ZUK5TjayyQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724118212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z0CkfrcpVS3zEUmY2oFgdInDx39rSrFhVNtKhSzZpUg=; b=Dd0akz4L1cvHsBy50lhnd1zXCDftgX1gfP4JF5Rz/L/Dkj22KD8ThGUJOaB7INBMvsQD7z yxBX5pIRZxafD9mGdS9vm7GDDosN9Kmcq9QgyZrEXehLc8qDeuTVrxEprQts8EqQHCedMd cRAjkx4zYHahTvr1LjkKHnRNUCMqoNS7csXb/UBIeLs3OfbkFFV6/W/7FpH/+iWv4Q/3mC 6onMVeR0u1RBQS/y0hFuTm5OlGk3CdfJ2Sr1u7nliPU5hQBZMDkLYfUgiKvcSmJjBQwQmK 2qE3s6LsAZ1NoFPcSAyX3b2Qgrc7jn/ijIU5Gjgebm4iXCE/KmvYue4NtTpMmA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WnsgS5HNczgf4 for ; Tue, 20 Aug 2024 01:43:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 47K1hWCU085867 for ; Tue, 20 Aug 2024 01:43:32 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 47K1hWG9085866 for net@FreeBSD.org; Tue, 20 Aug 2024 01:43:32 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 280097] Warning printed when FIBs are expanded is unhelpful and confusing Date: Tue, 20 Aug 2024 01:43:32 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: zlei@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280097 --- Comment #15 from Zhenlei Huang --- (In reply to Jeremy Cooper from comment #13) > I am reopening this because the main problem was the content of the messa= ge, > not problems about when it is displayed. As it stands, the current soluti= on > still retains the CONFUSING wording. Ah, I think the original warning message > WARNING: Adding ifaddrs to all fibs has been turned off by default. Consi= der tuning net.add_addr_allfibs if needed says exactly what it intends. Please note `Adding ifaddrs to all fibs` is a feature although it is not highlighted in the warning message. I'd admit th= at `ifaddrs` is more a developer friendly word, it refers to `interface addres= ses` exactly. > I propose that the warning be changed ever so slightly so that the user c= an tell > 1. When it was generated (when net.fibs is adjusted) Now only when the first time increasing `net.fibs` and `net.add_addr_allfib= s =3D=3D 0`. > 2. That the warning is a reminder, not the detection of a problem. Emm, the message was introduced to be a WARNING, exactly. And a WARNING does not necessarily mean a problem is detected. In this case it is something important ( a noticeable breaking change ) that user should be aware. (In reply to Jeremy Cooper from comment #14) > Pardon me, that was my old wording. I think I proposed the following in m= y last round: >+ printf("%s adjusted to %d. REMINDER: " The `adjusted to` is redundant. When doing the tuning ``` # sysctl net.fibs=3D2 net.fibs: 1 -> 2 ``` The console should print the new value (by default). >+ "Interface addresses are no longer automatically a= dded " >+ "to additional FIBs. Consider setting %s if needed= \n", The `additional` is not accurate. If so then what is the current FIB ? I'd prefer keep `tuning`. I think it is more natural. We are tuning a sysctl knob. >+ "net.fibs", >+ num_tables, > "net.add_addr_allfibs"); >+ If you insist then I'd propose to reword `ifaddrs` to `interface addresses`. The message will end up with ``` WARNING: Adding interface addresses to all fibs has been turned off by defa= ult. Consider tuning net.add_addr_allfibs if needed ``` Is it clear enough to you ? --=20 You are receiving this mail because: You are the assignee for the bug.=