From nobody Sun Nov 12 04:13:32 2023 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SSfLh2Ysqz50w9T for ; Sun, 12 Nov 2023 04:13:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SSfLh0xvwz3TTq for ; Sun, 12 Nov 2023 04:13:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699762412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3WHjDl4Hrqf/q+k4FpoljqFWRVHhM7Xx5GTAIkY6Czc=; b=s3OKhsD5t6g9BQ3TpzkLVqurmP7LximzJqGrX1hY6btEA6uothkoEOQE6hPqY8uLQp0pZq 4YaDcRgh7LZ1PHIAjSYZ7UdJU1aKS2JbjNCKNZUHYi7LOHsKQvG2hdxLW11hvauXqC+SaP lg4PQ+NjMQj6UwmFonXzBWMz51gbC5VeAcX2dJpdg6/VvkgLsvA18Z8tPAXghRXmlDplA3 JCSCuG75HObRcCE7oUaKRNPtsPyLj/5n4OBkYsdbxqGVgDaD9zazXdX+U2M6SrSH9LiNhD XbVgm2vhmIx8iptlbk5mVYHzv5LfCv1YtSCtbHGX5hifBtnDJkQEtiPcTdBPFA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1699762412; a=rsa-sha256; cv=none; b=EUfo+mXcRz9JQcuOucccZpzlnOpVdjwYw7sLrKYqXxBwAVh3apTeoBtnW8zIdGE1EEiFoV zEfpGfr7KZyupsFXGa15+s3KyxhMYRypombk1vzrFgfneyssrCKjl/SmOEERal/2qxv5UC 9p0HoPKIw6LG2D88yr8cjoGg5uR5z0wIvWntwlyMznweSpch/RAgebBqwf3hZEsymXm/8Y fY4MXtqaytKF+tFdEvlFTGj0RG79BxCnkfDVZnZE4cZlWjlT9IK/sFOsKoEMnRYEjyDJ2V n6jOi/hR9ZYr8VJSh/TT5gyjAwhJLtp1jhtmjkvbqCIEKuVr1RhW+fYv7qZy6w== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SSfLh022qz17nF for ; Sun, 12 Nov 2023 04:13:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3AC4DVgd055899 for ; Sun, 12 Nov 2023 04:13:31 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3AC4DVPl055897 for net@FreeBSD.org; Sun, 12 Nov 2023 04:13:31 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 275002] if_wg: Missing failure check for m_copyback() Date: Sun, 12 Nov 2023 04:13:32 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: aly@aaronly.me X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D275002 --- Comment #3 from Aaron LI --- (In reply to Kristof Provost from comment #1) > I don't think that's an issue here because the mbuf is known to be of > length 'len' before it's passed to m_copyout(). The allocation is done > just before the m_copyback(). Oh, that's true. I forget that implication set by m_get2() just before m_copyback(). As kevans suggested, a KASSERT() after m_copyback() would make it clear and remove this confusion. --=20 You are receiving this mail because: You are the assignee for the bug.=