Re: reviewers for if_smsc change?

From: Mike Karels <mike_at_karels.net>
Date: Thu, 09 Nov 2023 12:34:27 UTC
On 9 Nov 2023, at 4:30, Ronald Klop wrote:

> On 11/4/23 15:39, Ronald Klop wrote:
>> Hi,
>>
>> For issue 274092 [1] I'm looking for reviewers.
>>
>> A user on the ML had an issue that the MAC address was not assigned on some Raspberry PI compute modules.
>> I tried and succeeded in using the MAC address passed on from the firmware to the kernel.
>>
>> The review is in: https://reviews.freebsd.org/D42463
>>
>> I have a ports commit bit if possible I would like it to commit this myself as first steps in more in depth FreeBSD development.
>>
>> Regards,
>> Ronald.
>>
>>
>> [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274092 (if_smsc.c needs to use ether_gen_addr instead of read_random for more stable MAC address)
>>
>
>
> Hi,
>
> I got some comments on the phabricator review and updated the patch with it. I think it is pretty clean now and it is tested and works.
> How should I go from here?
> Can somebody help me commit this (I am a ports committer) or commit this for me?
> Do I need more approval and if yes, how can I get that?
>
> Regards,
> Ronald.

The change looks good to me now.  I think it would be good if someone who
works on USB looked at it too.  I am willing to approve the change; I think
you can commit it with approval.

		Mike