From nobody Mon Mar 27 08:17:39 2023 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PlQfX5RTBz41x0c for ; Mon, 27 Mar 2023 08:17:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PlQfX1xdKz4FB2 for ; Mon, 27 Mar 2023 08:17:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679905060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5/5zl+wTDJowZV4RgkhM3khrZgBtz/QwOF3NKUXRYr4=; b=KJeZlndGUrf7+mUcXpue6wubTxkZ0rsUq/9BnEyam7kzQ6VYjhz26lzthv7B9Pby2knICl DaowydCn3wyT8oiUU4cECN5KJ70Djuh7L6mHvHtBKZdgo3G5J5F9bR4dkzDVNkRFlmTq1W 00xPbMPPFy5RBx4uugrGG/VzKjJcoB0XzsjpYQAnyRlftAo9BvHfQSDHUwX8d8FkEwaFZw 1JlYcSUHOzLnn3czO0m2/YzuraArgZKpO9cJ1iWCHLK7WGh2xpQdUdytbwz8ibrWnHSq7d PdseYoWtdFtl+DNd7CFJmbv/5nr9CNUWW5MtZe1zrY1jWaXOaOK1xo9eVDvIyw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1679905060; a=rsa-sha256; cv=none; b=sOn51CVgyoX1w70WUBdQ86BsHi+qIXQkrMdGs6En+MBIOnfp190OnlVJPvP50Nccbll9er P98E3m45cmY/iD5zCiw+5xz4qi/1u5oMbvjKRI7PCtk45k9afEYKhrTezvOGz9w56TVlsM SvPQ8liBUu0R2kuoBqAGWEoio8gAvJLhQSVBaefFjlKuHh7z8eyYWFGE64N1d0BbKKpv/4 DwokjQ0mkyeyrjokf3BmB8jxbFcv2xtJ7CcN7Od1ErsQq6nwRtc1Wx890A1+c5/z9YMwFV x7Czv6+n8YL88DAdAmS5ZoWkxR6oxmDOj0niCrol3htUuIezFXixGy27j+MX6g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PlQfX126RzF6n for ; Mon, 27 Mar 2023 08:17:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 32R8Henw017309 for ; Mon, 27 Mar 2023 08:17:40 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 32R8HeOl017308 for net@FreeBSD.org; Mon, 27 Mar 2023 08:17:40 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 268246] crash and panic using pfsync on 13.1-RELEASE Date: Mon, 27 Mar 2023 08:17:39 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.1-RELEASE X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D268246 --- Comment #102 from commit-hook@FreeBSD.org --- A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D44af4103e422029026e9bb1a578455036= 5831cf3 commit 44af4103e422029026e9bb1a5784550365831cf3 Author: Kristof Provost AuthorDate: 2023-03-20 13:29:55 +0000 Commit: Kristof Provost CommitDate: 2023-03-27 08:16:03 +0000 pfsync: fix pfsync_undefer_state() locking pfsync_undefer_state() takes the bucket lock, but could get called from places (e.g. from pfsync_update_state() or pfsync_delete_state()) where we already held the lock. As it can also be called from places where we don't yet hold the lock create new locked variant for use when the lock is already held. Keep using pfsync_undefer_state() where the lock must still be taken. PR: 268246 MFC after: 1 week Sponsored by: Rubicon Communications, LLC (Netgate) (cherry picked from commit 53247cdf12449e90f6736ae563e4cce8315c923f) sys/netpfil/pf/if_pfsync.c | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=