From nobody Mon Mar 27 08:17:35 2023 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PlQfR6lCpz41xFv for ; Mon, 27 Mar 2023 08:17:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PlQfR1Z5sz4F6H for ; Mon, 27 Mar 2023 08:17:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679905055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3+V2FJktJrKorrv6N9P2kKLKgZhr0XsNX/OceklVzqY=; b=o47AFg9YOylrqc5yHiac2h4KCRprYs3z+OpB/1SeX3lvW9upoeWbxR8zg7MR0knvFK7Bc3 RXwa5SrKt5e5Qx5M1BUEPJ+al/QybIzUMwPOQbnXJcZUlVirg90bY/D8JIw8QP17C1bS5W kJS0b2I/EmZHsnOSIaCiKDFf6VTadfbzC4GURKgSpsMm5i7ri/QgHDs+2sVcEj1n183r4D PrDkcSFzNIqFmfRTq4a1f69K3JiYDEDw2lLgQ93OFKsbeaPwFV2CwxH1137LnKu7+uxANi cdm0fVWvCNvjBXof6b7GXqJp7kLQD/RnD810QV7Xw3E0wxspxCb4xHVXZwaP3w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1679905055; a=rsa-sha256; cv=none; b=VN9k/NC3s6k0FK1M/lqa3IWLa3qTjJ4FvaMbtKYlIq9JtSQuFaiotAcBcByN0aTbcABSHy 0TFX5XbUmz1R6y/CCMHzxFGmJx+6pUGG4xaM7edPA1xAQxJKSXbw+ckyAbInoeogzLwiH8 uTkMp33R2Y19UZiO40CfZZzyQCwJLOUhzhYSGR0RvKryBc7xzYAqipX+5YfwdiOPGdQT3M FE0dN4B4OjyEyQ9SRz+M7hFp617YPsQUHyjBjFUANqLXq7hS0YNQH0AOn48tj2cHeA6cHa zOLaL87VscFlmGn0jipu4yWUvTxG5HjCKBKydzOfpuSHlqkQ6fQ+AQvqDsKx1g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PlQfR0hZjzFCP for ; Mon, 27 Mar 2023 08:17:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 32R8HZpO017162 for ; Mon, 27 Mar 2023 08:17:35 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 32R8HZT0017161 for net@FreeBSD.org; Mon, 27 Mar 2023 08:17:35 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 268246] crash and panic using pfsync on 13.1-RELEASE Date: Mon, 27 Mar 2023 08:17:35 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.1-RELEASE X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D268246 --- Comment #99 from commit-hook@FreeBSD.org --- A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D3eb2341caaa307a8d067333c8aebe3e26= 9ade2fd commit 3eb2341caaa307a8d067333c8aebe3e269ade2fd Author: Kristof Provost AuthorDate: 2023-03-20 13:26:33 +0000 Commit: Kristof Provost CommitDate: 2023-03-27 08:16:03 +0000 pfsync: add missing unlock in pfsync_defer_tmo() The callout for pfsync_defer_tmo() is created with CALLOUT_RETURNUNLOCKED, because while the callout framework takes care of taking the lock we want to run a few operations outside of the lock, so we unlock ourselves. However, if `sc->sc_sync_if =3D=3D NULL` we return without releasing the lock, and leak the lock, causing later deadlocks. Ensure we always release the bucket lock when we exit pfsync_defer_tmo() PR: 268246 MFC after: 1 week Sponsored by: Rubicon Communications, LLC (Netgate) (cherry picked from commit 844ad2828a35c434b893af4274b1f6c50332dd70) sys/netpfil/pf/if_pfsync.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --=20 You are receiving this mail because: You are the assignee for the bug.=