From nobody Fri Mar 17 18:05:39 2023 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PdX9b6HX4z3yf1d for ; Fri, 17 Mar 2023 18:05:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PdX9b5Dg0z3FCQ for ; Fri, 17 Mar 2023 18:05:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679076339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PH+en78WQTv3C6riqu6inquEhswI6jQcH2gbRriDIZY=; b=vds6LDkAVmmUWypo2gsH3htjADU7p4d8mr/7ZpsT3g/FbIf/2qmFUnJYmQwJiOhkPXEs+R FHUfXjTEamW1cytsadGrEWJ69MsVph2whkF9QYrMelhw4K6VmoZB2Dbv95K5Z80vKp2mm7 +kxdTD1VDWQUeRbjkCF40s+RjWuKPs9TMLr/ECjjvB3Y+A2CsyabMmailwlpgZk69j/Z2J MNxNuO8WOUBNEgPkRC5qp66UBX6yhWJuQK4YjqjTYTJG1nLX7DrC8AI0J1yzxKtlypF7sN 9K6RVSilzwQocxSBn1AGzDZ8ZTuQ3+5HeL82mEPwLJgv1ADy7BlbpdQSNxxC9A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1679076339; a=rsa-sha256; cv=none; b=c8RlNli6fMKJUoL9XvJ4++xT/9k7cRX7Jip5n9tdZl1K5kfITdgcpdhpU3rdO6yqsSP0Tx jCrgc3xj7VLcGx0qmwgMUJa0BcJlhMXKXjYs+6rCBvpJFElXD8mxy5w+r1KTiIVd0aH0Im Yy+G4peZAUwzpwVFE3Y6T8/tJzaKVWut/LfNLvu62HSldUjfiNoYB+QDKzcuSDNKAvQkUY clRJjZUGSaFEMlrVWaOUOg6o/lZVdqLwx7VPfyyp+1Vv629LnZoU/4/AXS9C9Owotq6E1k EY1939vRQqooATkLUtsOzUl0aOlDonfWy6Lp24+89SslENp5Qb4coHianiM65Q== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PdX9b4CvTzbQN for ; Fri, 17 Mar 2023 18:05:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 32HI5dIj096725 for ; Fri, 17 Mar 2023 18:05:39 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 32HI5dhs096724 for net@FreeBSD.org; Fri, 17 Mar 2023 18:05:39 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 268490] [igb] [lagg] [vlan]: Intel i210 performance severely degraded Date: Fri, 17 Mar 2023 18:05:39 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.4-RELEASE X-Bugzilla-Keywords: needs-qa, regression X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: duerrd561@gmail.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D268490 --- Comment #34 from Daniel Duerr --- (In reply to Kevin Bowling from comment #33) Hi Kevin, Here's my first progress report: ### Round 1: Restart the `git bisect` and confirm the commit 68cfeeb1d3c4 w= orks [root@nfs ~]# cd /usr/src [root@nfs ~]# git checkout releng/12.4 [root@nfs ~]# git bisect start release/12.4.0 release/12.2.0 -- sys/dev/e10= 00 Bisecting: a merge base must be tested [68cfeeb1d3c428e3c3881f45bc3a20a252b37d0e] MFC r365284: [root@nfs ~]# make -j `sysctl -n hw.ncpu` buildkernel KERNCONF=3DGENERIC-NO= DEBUG && make installkernel KERNCONF=3DGENERIC-NODEBUG [root@nfs ~]# reboot [root@nfs ~]# uname -a FreeBSD nfs.tidepool.cloud 12.2-PRERELEASE FreeBSD 12.2-PRERELEASE 68cfeeb1d3c4(HEAD) GENERIC-NODEBUG amd64 [root@nfs ~]# iperf -s ------------------------------------------------------------ Server listening on TCP port 5001 TCP window size: 64.0 KByte (default) ------------------------------------------------------------ [ 1] local 172.27.6.135 port 5001 connected with 172.27.6.129 port 10616 [ ID] Interval Transfer Bandwidth [ 1] 0.00-10.00 sec 1.15 GBytes 985 Mbits/sec [ 2] local 172.27.6.135 port 5001 connected with 172.27.6.129 port 20446 [ ID] Interval Transfer Bandwidth [ 2] 0.00-10.00 sec 1.15 GBytes 988 Mbits/sec [ 3] local 172.27.6.135 port 5001 connected with 172.27.6.129 port 10068 [ ID] Interval Transfer Bandwidth [ 3] 0.00-10.00 sec 1.15 GBytes 985 Mbits/sec ### Round 2: Apply the change to sys/dev/e1000/if_em.c in commit 68cfeeb1d3= c4 and see if it still works [root@nfs src]# vi sys/dev/e1000/if_em.c [root@nfs src]# git diff diff --git a/sys/dev/e1000/if_em.c b/sys/dev/e1000/if_em.c index 558a75ac015e..42faacfc3eea 100644 --- a/sys/dev/e1000/if_em.c +++ b/sys/dev/e1000/if_em.c @@ -1338,7 +1338,7 @@ em_if_init(if_ctx_t ctx) } /* Don't lose promiscuous settings */ - em_if_set_promisc(ctx, IFF_PROMISC); + em_if_set_promisc(ctx, if_getflags(ifp)); e1000_clear_hw_cntrs_base_generic(&adapter->hw); /* MSI-X configuration for 82574 */ [root@nfs ~]# make -j `sysctl -n hw.ncpu` buildkernel KERNCONF=3DGENERIC-NO= DEBUG && make installkernel KERNCONF=3DGENERIC-NODEBUG [root@nfs ~]# reboot [root@nfs ~]# uname -a FreeBSD nfs.tidepool.cloud 12.2-PRERELEASE FreeBSD 12.2-PRERELEASE #15 68cfeeb1d3c4(HEAD)-dirty: Fri Mar 17 10:50:14 PDT 2023=20=20=20=20 toor@nfs.tidepool.cloud:/usr/obj/usr/src/amd64.amd64/sys/GENERIC-NODEBUG a= md64 [root@nfs ~]# iperf -s ------------------------------------------------------------ Server listening on TCP port 5001 TCP window size: 64.0 KByte (default) ------------------------------------------------------------ [ 1] local 172.27.6.135 port 5001 connected with 172.27.6.129 port 47216 [ 2] local 172.27.6.135 port 5001 connected with 172.27.6.129 port 37030 [ 3] local 172.27.6.135 port 5001 connected with 172.27.6.129 port 41145 ^CWaiting for server threads to complete. Interrupt again to force quit. [ ID] Interval Transfer Bandwidth [ 1] 0.00-76.70 sec 60.0 Bytes 6.26 bits/sec [ 2] 0.00-56.38 sec 60.0 Bytes 8.51 bits/sec [ 3] 0.00-36.23 sec 60.0 Bytes 13.2 bits/sec [SUM] 0.00-78.70 sec 180 Bytes 18.3 bits/sec In summary, the first good commit in the bisect works and when I apply the change, it stops working. As a next step, I was thinking I'd (a) revert the manual change back to the "good" state, (b) so a `git bisect good` to proceed to the next (first "bad= ") commit, and (c) manually reverse the change the other way to see if the bad commit then works. Does that make sense? --=20 You are receiving this mail because: You are the assignee for the bug.=