[Bug 272319] FreeBSD kernel crash on MPD5 restart with PPP configuration.

Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: <bugzilla-noreply_at_freebsd.org>
Date: Sun, 02 Jul 2023 15:08:16 UTC

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272319

--- Comment #15 from Aleksandr Fedorov <afedorov@FreeBSD.org> ---
(In reply to ny from comment #11)

Yes, I think there is an additional bug here.

After commit
https://github.com/freebsd/freebsd-src/commit/779f106aa169256b7010a1d8f963ff656b881e92

A new KPI has been added - solisten_upcall_set() which is used to catch events
associated with a listening socket.

But, the current version of ng_ksocket(4) continues to use the old KPI for data
sockets.

Therefore, I think, because ng_ksocket(4) doesn't set the handler function via
solisten_upcall_set(), it doesn't get ACCEPT event, etc.

For an example, see how it was done for ctl_ha.c
https://github.com/freebsd/freebsd-src/commit/779f106aa169256b7010a1d8f963ff656b881e92#diff-77eaa0ac186398050c82052906359306b18a8a274c
b81b7ee3dbd897f8207705

The same things should be done with ng_ksocket(4).

-- 
You are receiving this mail because:
You are the assignee for the bug.