From nobody Sat Jan 28 01:40:10 2023 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P3cZg1SHjz3bpnb for ; Sat, 28 Jan 2023 01:40:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P3cZg0NLTz3pdv for ; Sat, 28 Jan 2023 01:40:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674870011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pfLnFQzEnNBca1Jwc6hK4Jwapms4PQPe5Ex7Ej9TA2c=; b=EQNKAd7m3pQjWeWiQ/hFOmcVPBswiG/0lIY8W8Xdm39629B34NeRspUM1cpa8nL2TthSqs GxAGa9FO1RNHmizkkp1KVpuMhnfd5xJ7octDXkpP9aPm9VReBxGcV49fZpteAH776GVwZr pc69LRwCGrjkEQmjvhnRr+cRsQY0PUoBjeCeCPFmOONMNCZ3lVtwB5e/kQKJZ7K9O72Pw7 BqF0SN26QF18DjpFlS9wkRrRAGNj489P5H8azTFWi0bXYhz9z4heETvl6lyFXGOD7ekrsr kgJj/xArHQhZNWDVBgdwUgRvWT1/Q5ztynL1SxSX5e83wE45yw4qfkCRBbxaAg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1674870011; a=rsa-sha256; cv=none; b=dUwYchpHKcViu2LZ1wTlbye894Ua+6yafbVp3ncZA5XY+mdz8C59ug67ZD6PT0ibqVSfNe pjVT05KBY2Hn75MWcMpfsPgUY6751SEx76iTRDeh4pMQZnJytakeDKl+D2CRgrEAuQHdch SbtOLGfE5xiiaNigyfyCDh53VxtWVTQUF4VDtqSNfSOdr/B78PYXQXtK4O8KA+1SVSfQUQ LeLdP9DC2jxig/HbcQfCTcRu4NDseEJ9zMWazQiQQjnNcas3c2Fm0/Tpj/FcBG3Y7UhnrY SYd48hj4EHkMwHQ+H8tvA4nK5KiCCPlAZYmwKIMoTwzlL6Apgjfd+BwdLaEy4g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4P3cZf6TG8zWR7 for ; Sat, 28 Jan 2023 01:40:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 30S1eAar004407 for ; Sat, 28 Jan 2023 01:40:10 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 30S1eA8R004406 for net@FreeBSD.org; Sat, 28 Jan 2023 01:40:10 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 268246] crash and panic using pfsync on 13.1-RELEASE Date: Sat, 28 Jan 2023 01:40:10 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.1-RELEASE X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D268246 --- Comment #40 from commit-hook@FreeBSD.org --- A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D8edf0b52c40762d64b3d4318235b58ae5= d4eff58 commit 8edf0b52c40762d64b3d4318235b58ae5d4eff58 Author: Kristof Provost AuthorDate: 2023-01-13 03:34:20 +0000 Commit: Kristof Provost CommitDate: 2023-01-28 01:34:38 +0000 pf: fix panic on deferred packets The pfsync_defer_tmo() callout needs to set the correct vnet before it can transmit packets. It used the rcvif in the mbuf to get this vnet, but that doesn't work for locally originated traffic. In that case the rcvif pointer is NULL, and the dereference leads to a panic. Instead use the sc_sync_if, which is always set (if pfsync is enabled, at least). PR: 268246 MFC after: 2 weeks (cherry picked from commit fd02192c3acaefeb62db11e0c10ab36240b79ba2) sys/netpfil/pf/if_pfsync.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --=20 You are receiving this mail because: You are the assignee for the bug.=