From nobody Wed Dec 06 17:07:04 2023 X-Original-To: freebsd-net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SlkN33RBCz53hFH for ; Wed, 6 Dec 2023 17:06:59 +0000 (UTC) (envelope-from driesm@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SlkN32v88z4Y9K; Wed, 6 Dec 2023 17:06:59 +0000 (UTC) (envelope-from driesm@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701882419; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W+DP2AkyDMih7QBLnlCVFgdJPKd5NKx3xkzn12QxIqc=; b=hnkxbtcPXcG085/m00KWTEKpNG+WzIPA1F4BW0ZmFPMKT9G3RiVUCCTiRchbqhg64JO+ey R4Ti/W/IwKf9dXu2fuZbIT691xgaQTEC1lZKEmANMnG81Tcx6deSpFJcDH0ujRuDhQzB8L +TaoVm/c6ZYS6V0PYTl9N6+6iWbHn1i5IcLXTLxnc+F7Tnc1w4141DWnA/muwiRvgS/b2U 22Rsauk1lbufmAHKjvx3M1hz4XpqSYvRynx5eDI61Euu1/hSovrtWxxSeevZkoAIADMxEP aQXEMN2cAU28NbwFjX9EGhz9BPilduZ36MbDL7qGPWAFrGeO3SQyP2NM1Pfdrw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1701882419; a=rsa-sha256; cv=none; b=RkFwzgzU9ncQHWhUJrHY9jU0mwTWGDTO4vFzQnQEqaN28aSd9UH0WmuoorRCoLDcRNSyDR uYw6wKE5xtCkUUa55wXPfo/bNaLH4VyMOLC+5Oo6OhtEx78L2J6SIYIDoR5BI1GmGpMSsB zFAtkg7eNIhbIIMeGhHfwRVGG9dDjS9I2fTCYGPwSHcH+gT9DL012CyEIvNXuoLjGPgs+Z YwzR/YtDPlJ+6HOI9dp69GDDUV7KIiNIWpCK1yq5v3zDcGHcOAURJqNtaNA0z7Hs0tkDvh MG4S96tTTC3EkNZqNoKgHtI7FG87Jh+prEqUERZSXv5FbuXnXcEXVcicg7joYQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701882419; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W+DP2AkyDMih7QBLnlCVFgdJPKd5NKx3xkzn12QxIqc=; b=JV/g/v9xjxU5b8AdTYHCkgSs3064/q1VYNAMosuhidzCiwA4uk0LaySFIfbydH0CPJPN7e 8wBoJ7UW9d1I7lNP+i4a3lVUYQcXeGbGK868yJPKOZpfIRYo6dzZ6YlkMmgLm3rbj480U/ I5vTOeKGS4AqtYb9EEGJC3ZAV3lYkOOOd7BMethODTpIKX0YozLaJatbvqjKh0STJmmIte A7sQa22BL/Ja0y6HIUPsm4hDIRpYuGuG9jzODX5t5qsQG5TKqVtPahD9Al8VUZqUkpakid WxdXM7CTXr7yIeVZunKFfUaGjNaLL1ZuHVvVT8eWOhH2TNF0YbeA1LOC33DEfw== Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: driesm) by smtp.freebsd.org (Postfix) with ESMTPSA id 4SlkN31rtgz1D3C; Wed, 6 Dec 2023 17:06:59 +0000 (UTC) (envelope-from driesm@freebsd.org) Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-6d7fa93afe9so3891439a34.2; Wed, 06 Dec 2023 09:06:59 -0800 (PST) X-Gm-Message-State: AOJu0Ywa8aZPBPTTApFf1xO2QxqEoGK3IpdnDq8+d22MD6fUzsSp86fP eVQmOfTmD0W1v+HvrEPG2YKkVObuqQNKuijzoWA= X-Google-Smtp-Source: AGHT+IG8JNb2agcfEXemesWu8fSl7kZ/te9BRjMTMEPuvlLTWwmBLKZiysj/qI77YHw6XY6xfXmpp8Vm2eTjVpg4kZk= X-Received: by 2002:a05:6870:7905:b0:1f4:b1d6:573f with SMTP id hg5-20020a056870790500b001f4b1d6573fmr1294699oab.13.1701882418591; Wed, 06 Dec 2023 09:06:58 -0800 (PST) List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Dries Michiels Date: Wed, 6 Dec 2023 18:07:04 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: mlx5 fails to attach after STABLE-14 source upgrade To: Konstantin Belousov Cc: Zhenlei Huang , FreeBSD Net Content-Type: multipart/alternative; boundary="000000000000027f3e060bda61c5" --000000000000027f3e060bda61c5 Content-Type: text/plain; charset="UTF-8" That indeed fixed it, thanks! Op ma 4 dec 2023 om 02:46 schreef Konstantin Belousov : > On Mon, Dec 04, 2023 at 09:37:24AM +0800, Zhenlei Huang wrote: > > > > > > > On Dec 2, 2023, at 3:29 AM, Dries Michiels wrote: > > > > > > > > > > > > After updating my STABLE-14 machine from somewhere quite recently (my > old kernel that boots without error is from 14-n265716-bd7dceb27c08 > somewhere previous saturday). > > > The new kernel that didn't boot was from Commit > 24cd42aeb6232b4678f45dc6d242e8982dbea8e6 (HEAD -> stable/14, > origin/stable/14) checked out. > > > > > > Could someone take a look at this? > > > > > > Regards > > > Dries > > > > > > Hi Dries, > > > > The commit 24cd42aeb6232b4678f45dc6d242e8982dbea8e6 is for crypto/ossl , > that should > > not affect mlx5. > > > > There're some changes since bd7dceb27c08, > > ``` > > git log --format=oneline bd7dceb27c08..24cd42aeb623 -- sys/dev/mlx5 > > > > ac83e415ef083da400509c6fa434ee59cfe9668f mlx5_core: fix deadlock when > using RXTLS > > 8377dd1c9aeb7f4e42ec2679bb8913379d9c77e7 mlx5core: add linux/bitops.h > include for mlx5_ifc.h use of BIT() > > 588203bfbdc46073dc8b4515d31a6a9efe3d9a3c mlx5: Introduce new destination > type TABLE_TYPE > > d82618894153d0f53b272a0c76fd180658efbb41 mlx5ib: adjust for the > mlx5_create_auto_grouped_flow_table() interface change > > e073fccf14569f61b312078d0cee9a6f6eb17a37 mlx5: add ability to attach > flow counter to steering rule > > 52164cb3bd38ef23c108149e4a91042da204a2f3 mlx5: add fs_counters > > 5a2ff1f03ad245577498bcbc3907f4ae336fd9e8 mlx5: Add a no-append flow > insertion mode > > 67a9c8868af371f3e0b96a18d1f9d54fd2be4b1a net/mlx5: Allow creating > autogroups with reserved entries > > 4c6a46cea41b236f9b06e702e8491055dddc7d4c net/mlx5: Fix auto group size > calculation > > 0759f76e579d61e4609b05ea0efcc2d1a63d2679 mlx5: Use software enum in APIs > instead of PRM > > 6fb2eebf6471ee08949dd027a6beffdbf78d8bb1 mlx5: Add packet reformat > support to flow rules > > 8895a0509698f29bb234a186590e3f08970a34d9 mlx5: Add modify header support > to flow rules > > 08e7b322db02329516e5d8adcec9df3c7b20774c mlx5: Refactor flow actions > into a struct > > 87d86f3733a4cdfb5777bc2b28bd11db93c7ab97 mlx5: Add packet reformat > allocation support > > 2b729c222d4821069c817c853f56826d065f7ac7 mlx5: Add modify header support > > ``` > > > > You may want to revert part(s) of them to check which one is to be > blamed. > > You can build the driver module only, that should be quite fast. > > The commit 0cd90ee598cef68cef72db8b912241868d1067d0 most likely fixes the > problem. I will merge it to stable/14 shortly. > --000000000000027f3e060bda61c5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
That indeed fixed it, thanks!

Op ma 4 dec 2023 om 02:46 sch= reef Konstantin Belousov <kostikb= el@gmail.com>:
On Mon, Dec 04, 2023 at 09:37:24AM +0800, Zhenlei Huang wrote:
>
>
> > On Dec 2, 2023, at 3:29 AM, Dries Michiels <driesm@freebsd.org> wrote:
> >
> > <image.png>
> >
> > After updating my STABLE-14 machine from somewhere quite recently= (my old kernel that boots without error is from 14-n265716-bd7dceb27c08 so= mewhere previous saturday).
> > The new kernel that didn't boot was from Commit 24cd42aeb6232= b4678f45dc6d242e8982dbea8e6 (HEAD -> stable/14, origin/stable/14) checke= d out.
> >
> > Could someone take a look at this?
> >
> > Regards
> > Dries
>
>
> Hi Dries,
>
> The commit 24cd42aeb6232b4678f45dc6d242e8982dbea8e6 is for crypto/ossl= , that should
> not affect mlx5.
>
> There're some changes since bd7dceb27c08,
> ```
> git log --format=3Doneline bd7dceb27c08..24cd42aeb623 -- sys/dev/mlx5<= br> >
> ac83e415ef083da400509c6fa434ee59cfe9668f mlx5_core: fix deadlock when = using RXTLS
> 8377dd1c9aeb7f4e42ec2679bb8913379d9c77e7 mlx5core: add linux/bitops.h = include for mlx5_ifc.h use of BIT()
> 588203bfbdc46073dc8b4515d31a6a9efe3d9a3c mlx5: Introduce new destinati= on type TABLE_TYPE
> d82618894153d0f53b272a0c76fd180658efbb41 mlx5ib: adjust for the mlx5_c= reate_auto_grouped_flow_table() interface change
> e073fccf14569f61b312078d0cee9a6f6eb17a37 mlx5: add ability to attach f= low counter to steering rule
> 52164cb3bd38ef23c108149e4a91042da204a2f3 mlx5: add fs_counters
> 5a2ff1f03ad245577498bcbc3907f4ae336fd9e8 mlx5: Add a no-append flow in= sertion mode
> 67a9c8868af371f3e0b96a18d1f9d54fd2be4b1a net/mlx5: Allow creating auto= groups with reserved entries
> 4c6a46cea41b236f9b06e702e8491055dddc7d4c net/mlx5: Fix auto group size= calculation
> 0759f76e579d61e4609b05ea0efcc2d1a63d2679 mlx5: Use software enum in AP= Is instead of PRM
> 6fb2eebf6471ee08949dd027a6beffdbf78d8bb1 mlx5: Add packet reformat sup= port to flow rules
> 8895a0509698f29bb234a186590e3f08970a34d9 mlx5: Add modify header suppo= rt to flow rules
> 08e7b322db02329516e5d8adcec9df3c7b20774c mlx5: Refactor flow actions i= nto a struct
> 87d86f3733a4cdfb5777bc2b28bd11db93c7ab97 mlx5: Add packet reformat all= ocation support
> 2b729c222d4821069c817c853f56826d065f7ac7 mlx5: Add modify header suppo= rt
> ```
>
> You may want to revert part(s) of them to check which one is to be bla= med.
> You can build the driver module only, that should be quite fast.

The commit 0cd90ee598cef68cef72db8b912241868d1067d0 most likely fixes the problem.=C2=A0 I will merge it to stable/14 shortly.
--000000000000027f3e060bda61c5--