From nobody Mon Dec 04 01:37:24 2023 X-Original-To: freebsd-net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Sk5rZ6bX8z52fBd for ; Mon, 4 Dec 2023 01:37:34 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Sk5rZ5jSCz4VxC; Mon, 4 Dec 2023 01:37:34 +0000 (UTC) (envelope-from zlei@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701653854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e61iglKdmj7XwgE/DREY71hK1ja2bzXgDWxYrwkGLNw=; b=uKwTrs5isId2+utaNnJNxHApr7FpIt8qUNJBEH/5XshLGky6Y4dCc/maub1R+XuvxVfUMO l9bHqmLhq2Cp4BmIPbMChmm/kkl7aYwlykDHnRRSpv+TuvYOWOtJeVCzf1IaZtNae3InMo Ah8OOmxb5Pn9HVUf9EcMsVu1lsmST9tuzqar4//Lu8dQdkKROXSunNkq637gY7XYXrgyZn ILxyvx0WHJkOsLGON4k0V2Ediq08dqOyqsazx/ph51YnJorUV4DX6ahko5MSod6XgX32ki b5zQSLqQGEPsCgz924UavYjDUoudSQUhKpYxP5YsK9kM7tZ2EdF3sRH84Ijf2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701653854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e61iglKdmj7XwgE/DREY71hK1ja2bzXgDWxYrwkGLNw=; b=dnMrzkQuhycfjlJ28rg+PaepplaU0hV7ZbxaYJSE+mWeYJ+Y1yXBM5d0smxRkM4BtCqGsH EthV28HWFCSYA96FzkYg8kzMGPxVIIHC30e59ZG4HnHdMHRFNa/flR5OSRnB8DAysJmhSO xU2OWEVYPeDhgRPLBgEaKzn5jh8JHSfy+88UHSQ16eXnce5illNSc6A4asQ54wevtLD9OK 92ENiY/O3ryZ6DlZFQu1D/5I4TyfMg4pTLGhMIGflLlmnfaJPteNSDK8AJvUEbbG2zdJrY 3gXdQkVcB4NBGnVsnStSJeRsn7fo7+Lyz/CAHT39kWNKG4aCoP5SH2/mv++DuA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1701653854; a=rsa-sha256; cv=none; b=VAPeV9k7g0PjnUazlz8mUwnhXfSnrECkGV0qnO6d4nU4w78Bvi9QmcUr18XfsjyiBhKVQU y7GEccYWNYLcTcX2YKeMmapjxeotl7M1T+ANDEqjPx+yTvt53kn0DaB01RrKtoAcZlmOac mHfzLs/MRC8qgg9D3gLARfg9eENCh2pgrPcHDD+J+Wgd85iUQdxCE7BDEMKi39SS1USB86 93AuEZrlcUjn4YvuO4R5kYYZZJYZ6LCfnmmPTOutLApLH1YLrrynxg/vdttQu83Fpqh0yc OYu1W84QgvXI4/6G/YNGebcp5MOddbDpk7IBX+CZ1nM/v9e4e3PwcDRp6avaeQ== Received: from smtpclient.apple (ns1.oxydns.net [45.32.91.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: zlei/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Sk5rY0Dr4zxLg; Mon, 4 Dec 2023 01:37:32 +0000 (UTC) (envelope-from zlei@FreeBSD.org) From: Zhenlei Huang Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_F8FB19B9-62B4-45BA-A76C-BFC2777C7AF3" List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\)) Subject: Re: mlx5 fails to attach after STABLE-14 source upgrade Date: Mon, 4 Dec 2023 09:37:24 +0800 In-Reply-To: Cc: FreeBSD Net , Konstantin Belousov To: Dries Michiels References: X-Mailer: Apple Mail (2.3696.120.41.1.4) --Apple-Mail=_F8FB19B9-62B4-45BA-A76C-BFC2777C7AF3 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Dec 2, 2023, at 3:29 AM, Dries Michiels wrote: >=20 > >=20 > After updating my STABLE-14 machine from somewhere quite recently (my = old kernel that boots without error is from 14-n265716-bd7dceb27c08 = somewhere previous saturday). > The new kernel that didn't boot was from Commit = 24cd42aeb6232b4678f45dc6d242e8982dbea8e6 (HEAD -> stable/14, = origin/stable/14) checked out. >=20 > Could someone take a look at this? >=20 > Regards > Dries Hi Dries, The commit 24cd42aeb6232b4678f45dc6d242e8982dbea8e6 is for crypto/ossl , = that should not affect mlx5. There're some changes since bd7dceb27c08, ``` git log --format=3Doneline bd7dceb27c08..24cd42aeb623 -- sys/dev/mlx5 ac83e415ef083da400509c6fa434ee59cfe9668f mlx5_core: fix deadlock when = using RXTLS 8377dd1c9aeb7f4e42ec2679bb8913379d9c77e7 mlx5core: add linux/bitops.h = include for mlx5_ifc.h use of BIT() 588203bfbdc46073dc8b4515d31a6a9efe3d9a3c mlx5: Introduce new destination = type TABLE_TYPE d82618894153d0f53b272a0c76fd180658efbb41 mlx5ib: adjust for the = mlx5_create_auto_grouped_flow_table() interface change e073fccf14569f61b312078d0cee9a6f6eb17a37 mlx5: add ability to attach = flow counter to steering rule 52164cb3bd38ef23c108149e4a91042da204a2f3 mlx5: add fs_counters 5a2ff1f03ad245577498bcbc3907f4ae336fd9e8 mlx5: Add a no-append flow = insertion mode 67a9c8868af371f3e0b96a18d1f9d54fd2be4b1a net/mlx5: Allow creating = autogroups with reserved entries 4c6a46cea41b236f9b06e702e8491055dddc7d4c net/mlx5: Fix auto group size = calculation 0759f76e579d61e4609b05ea0efcc2d1a63d2679 mlx5: Use software enum in APIs = instead of PRM 6fb2eebf6471ee08949dd027a6beffdbf78d8bb1 mlx5: Add packet reformat = support to flow rules 8895a0509698f29bb234a186590e3f08970a34d9 mlx5: Add modify header support = to flow rules 08e7b322db02329516e5d8adcec9df3c7b20774c mlx5: Refactor flow actions = into a struct 87d86f3733a4cdfb5777bc2b28bd11db93c7ab97 mlx5: Add packet reformat = allocation support 2b729c222d4821069c817c853f56826d065f7ac7 mlx5: Add modify header support ``` You may want to revert part(s) of them to check which one is to be = blamed. You can build the driver module only, that should be quite fast. Best regards, Zhenlei --Apple-Mail=_F8FB19B9-62B4-45BA-A76C-BFC2777C7AF3 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii


On Dec = 2, 2023, at 3:29 AM, Dries Michiels <driesm@freebsd.org> = wrote:

<image.png>

After updating my = STABLE-14 machine from somewhere quite recently (my old kernel that = boots without error is from 14-n265716-bd7dceb27c08 somewhere = previous saturday).
The new kernel = that didn't boot was from Commit = 24cd42aeb6232b4678f45dc6d242e8982dbea8e6 (HEAD -> stable/14, = origin/stable/14) checked out.

Could someone take a look at = this?

Regards
Dries

Hi Dries,

The commit 24cd42aeb6232b4678f45dc6d242e8982dbea8e6 = is for crypto/ossl , that = should
not = affect mlx5.

There're some changes since bd7dceb27c08,
```
git log --format=3Doneline = bd7dceb27c08..24cd42aeb623 -- sys/dev/mlx5

ac83e415ef083da400509c6fa434ee59cfe9668f mlx5_core: fix = deadlock when using RXTLS
8377dd1c9aeb7f4e42ec2679bb8913379d9c77e7 mlx5core: add = linux/bitops.h include for mlx5_ifc.h use of BIT()
588203bfbdc46073dc8b4515d31a6a9efe3d9a3c = mlx5: Introduce new destination type TABLE_TYPE
d82618894153d0f53b272a0c76fd180658efbb41 = mlx5ib: adjust for the mlx5_create_auto_grouped_flow_table() interface = change
e073fccf14569f61b312078d0cee9a6f6eb17a37 mlx5: add ability to = attach flow counter to steering rule
52164cb3bd38ef23c108149e4a91042da204a2f3 = mlx5: add fs_counters
5a2ff1f03ad245577498bcbc3907f4ae336fd9e8 mlx5: Add a = no-append flow insertion mode
67a9c8868af371f3e0b96a18d1f9d54fd2be4b1a net/mlx5: Allow = creating autogroups with reserved entries
4c6a46cea41b236f9b06e702e8491055dddc7d4c = net/mlx5: Fix auto group size calculation
0759f76e579d61e4609b05ea0efcc2d1a63d2679 = mlx5: Use software enum in APIs instead of PRM
6fb2eebf6471ee08949dd027a6beffdbf78d8bb1 = mlx5: Add packet reformat support to flow rules
8895a0509698f29bb234a186590e3f08970a34d9 = mlx5: Add modify header support to flow rules
08e7b322db02329516e5d8adcec9df3c7b20774c = mlx5: Refactor flow actions into a struct
87d86f3733a4cdfb5777bc2b28bd11db93c7ab97 = mlx5: Add packet reformat allocation support
2b729c222d4821069c817c853f56826d065f7ac7 = mlx5: Add modify header support
```

You may want to revert part(s) of them to = check which one is to be blamed.
You can build the driver module only, = that should be quite fast.

Best regards,
Zhenlei

= --Apple-Mail=_F8FB19B9-62B4-45BA-A76C-BFC2777C7AF3--