From nobody Mon Aug 28 07:54:11 2023 X-Original-To: freebsd-net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RZ2rW42Rhz4rG7c for ; Mon, 28 Aug 2023 07:54:19 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4RZ2rW2LkNz3GHf; Mon, 28 Aug 2023 07:54:19 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.17.1/8.17.1) with ESMTPS id 37S7sBm6024820 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 28 Aug 2023 10:54:14 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 37S7sBm6024820 Received: (from kostik@localhost) by tom.home (8.17.1/8.17.1/Submit) id 37S7sBmi024818; Mon, 28 Aug 2023 10:54:11 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 28 Aug 2023 10:54:11 +0300 From: Konstantin Belousov To: Zhenlei Huang Cc: freebsd-net Subject: Re: About IFNET_PCP_NONE Message-ID: References: List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.0 X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-14) on tom.home X-Rspamd-Queue-Id: 4RZ2rW2LkNz3GHf X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] On Mon, Aug 28, 2023 at 09:51:38AM +0800, Zhenlei Huang wrote: > Hi Konstantin, > > > I was just about going to open a PR for https://reviews.freebsd.org/D39536 and > realized I might made wrong assumption. > > I thought IFNET_PCP_NONE is something like IEEE8021Q_PCP_BE but I second why not > use IEEE8021Q_PCP_BE but a new const IFNET_PCP_NONE. > > So despite its naming IFNET_PCP_NONE, is it actually a flag to let specific interface > completely bypass (disable) PCP processing? > > The const IFNET_PCP_NONE is defined in sys/net/if.h with > ``` > #define IFNET_PCP_NONE 0xff /* PCP disabled */ > ``` I fail to understand your question. IFNET_PCP_NONE is a value that means that no 802.1q prio is inserted into the packet. Otherwise, non-vlan traffic is tagged with the priority. IEEE8021Q_PCP_BE is a name of one of the priorities, it seems from my code reading.