Re: Current with RSS and EPAIR and without INET6.
- In reply to: Kristof Provost : "Re: Current with RSS and EPAIR and without INET6."
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Thu, 03 Mar 2022 17:37:44 UTC
Thanks Kristof! Santi On 3/3/22 18:32, Kristof Provost wrote: > Thanks! > > Pushed as 52bcdc5b809ea56cbdce0bd36499e4ae74780d2b. > > Kristof > > On 2 Mar 2022, at 23:24, Santiago Martinez wrote: >> Hi Kristof and Zhenlei, >> >> I have updated the patch as requested (wrapped the ifdef INET|INET6 inside the ifdef RSS). >> >> It now works without INET6 or without INET. (only tested module loading and interface creation on both cases v4/6). >> >> Best regards. >> >> Santi >> >> @@ -73,8 +73,12 @@__FBSDID("$FreeBSD$"); >> #include <net/netisr.h> >> #ifdef RSS >> #include <net/rss_config.h> >> +#ifdef INET >> #include <netinet/in_rss.h> >> +#endif >> +#ifdef INET6 >> #include <netinet6/in6_rss.h> >> +#endif >> #endif >> #include <net/vnet.h> >> >> @@ -217,12 +221,16 @@epair_menq(struct mbuf *m, struct epair_softc *osc) >> eh = mtod(m, struct ether_header *); >> >> switch (ntohs(eh->ether_type)) { >> +#ifdef INET >> case ETHERTYPE_IP: >> rss_soft_m2cpuid_v4(m, 0, &bucket); >> break; >> +#endif >> +#ifdef INET6 >> case ETHERTYPE_IPV6: >> rss_soft_m2cpuid_v6(m, 0, &bucket); >> break; >> +#endif >> default: >> bucket = 0; >> break; >> >> >> >> >> On 3/2/22 20:12, Santiago Martinez wrote: >>> Hi Kristof, sorry for my late reply. Im testing without INET. >>> >>> I will keep you updated. >>> >>> Santi >>> >>> >>> On 2/28/22 21:20, Kristof Provost wrote: >>>> On 28 Feb 2022, at 21:16, Santiago Martinez wrote: >>>>> Hi there , yes good point , the first ifdef should go inside the RSS ifdef . Will modify it to also work with INET6 only. Thanks for the feedback. >>>>> Santi >>>>> >>>>> >>>> Can you copy me on your updated patch? I’ll commit that. >>>> >>>> Thanks for finding and reporting this. >>>> >>>> Kristof >>>> >> >