From nobody Thu Jan 13 20:15:30 2022 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 17DBE1952E38 for ; Thu, 13 Jan 2022 20:15:35 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JZbK20cTVz4pj0 for ; Thu, 13 Jan 2022 20:15:33 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.16.1/8.16.1) with ESMTPS id 20DKFUSp072988 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 13 Jan 2022 12:15:30 -0800 (PST) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.glebi.us (8.16.1/8.16.1/Submit) id 20DKFUWF072987; Thu, 13 Jan 2022 12:15:30 -0800 (PST) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f Date: Thu, 13 Jan 2022 12:15:30 -0800 From: Gleb Smirnoff To: Michael Tuexen Cc: Jamie Landeg-Jones , net@freebsd.org Subject: Re: compressed TIME-WAIT to be decomissioned Message-ID: References: <202201131825.20DIP6AT072280@donotpassgo.dyslexicfish.net> <2C135179-CFAF-491E-B699-7EEC980BCF1B@lurchi.franken.de> List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2C135179-CFAF-491E-B699-7EEC980BCF1B@lurchi.franken.de> X-Rspamd-Queue-Id: 4JZbK20cTVz4pj0 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=softfail (mx1.freebsd.org: 162.251.186.162 is neither permitted nor denied by domain of glebius@freebsd.org) smtp.mailfrom=glebius@freebsd.org X-Spamd-Result: default: False [-0.46 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.36)[-0.364]; FREEFALL_USER(0.00)[glebius]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; DMARC_NA(0.00)[freebsd.org]; R_SPF_SOFTFAIL(0.00)[~all:c]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-1.00)[-1.000]; NEURAL_SPAM_LONG(1.00)[1.000]; MLMMJ_DEST(0.00)[net]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:27348, ipnet:162.251.186.0/24, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On Thu, Jan 13, 2022 at 09:11:09PM +0100, Michael Tuexen wrote: M> > On Thu, Jan 13, 2022 at 10:30:10AM -0800, Gleb Smirnoff wrote: M> > T> Sorry, the stats I was talking about are present in CURRENT only: M> > T> M> > T> netstat -sp tcp | grep TIME-WAIT M> > T> 3 times connection in TIME-WAIT responded with ACK M> > T> 0 times connection in TIME-WAIT was actively recycled M> > T> 0 times connection in TIME-WAIT responded with RST M> > T> M> > T> I will merge it to stable/13 today, so that those running 13 can check it out. M> > M> > Sorry, I actually can't merge it to stable, as it changes size of tcpstat M> > making kernel/netstat incompatible. So, if you are interested in this data M> > on stable, the patch needs to be applied manually: M> > M> > https://cgit.freebsd.org/src/commit?id=71d2d5adfe18e80e5f8afeb4f86ef69be1aaad81 M> Why did you not change M> M> + /* TCPS_TIME_WAIT usage stats */ M> + uint64_t tcps_tw_recycles; /* Times time-wait was recycled. */ M> + uint64_t tcps_tw_resets; /* Times time-wait sent a reset. */ M> + uint64_t tcps_tw_responds; /* Times time-wait sent a valid ack. */ M> + M> uint64_t _pad[6]; /* 3 UTO, 3 TBD */ M> M> to M> M> + /* TCPS_TIME_WAIT usage stats */ M> + uint64_t tcps_tw_recycles; /* Times time-wait was recycled. */ M> + uint64_t tcps_tw_resets; /* Times time-wait sent a reset. */ M> + uint64_t tcps_tw_responds; /* Times time-wait sent a valid ack. */ M> + M> - uint64_t _pad[6]; /* 3 UTO, 3 TBD */ M> + uint64_t _pad[3]; /* 3 UTO */ M> M> That way you could MFC it... Oh, you are right. That's why we have the pads :) Will MFC. -- Gleb Smirnoff