maintainer-feedback requested: [Bug 281887] multimedia/mjpegtools: fix build with clang 19

From: <bugzilla-noreply_at_freebsd.org>
Date: Sun, 06 Oct 2024 09:50:38 UTC
Bugzilla Automation <bugzilla@FreeBSD.org> has asked freebsd-multimedia
(Nobody) <multimedia@FreeBSD.org> for maintainer-feedback:
Bug 281887: multimedia/mjpegtools: fix build with clang 19
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281887



--- Description ---
Clang 19 has become more strict about errors in member functions, which
results in errors building multimedia/mjpegtools:

  ./Region2D.hh:439:13: error: no member named 'DoesContainPoint' in
'Region2D<INDEX, SIZE>'
    439 |			  || this->DoesContainPoint (rHere.m_tnY,
tnX)))
	|			     ~~~~  ^
  ./Region2D.hh:446:22: error: no member named 'Begin' in 'Region2D<INDEX,
SIZE>'
    446 |	  for (itHere = this->Begin(); itHere != this->End(); ++itHere)
	|			~~~~  ^
  ./Region2D.hh:446:47: error: no member named 'End' in 'Region2D<INDEX, SIZE>'
    446 |	  for (itHere = this->Begin(); itHere != this->End(); ++itHere)
	|						 ~~~~  ^
  ./Region2D.hh:549:14: error: no member named 'DoesContainPoint' in
'Region2D<INDEX, SIZE>'
    549 |			  && !this->DoesContainPoint (rHere.m_tnY,
tnX))
	|			      ~~~~  ^
  ./Region2D.hh:556:22: error: no member named 'Begin' in 'Region2D<INDEX,
SIZE>'
    556 |	  for (itHere = this->Begin(); itHere != this->End(); ++itHere)
	|			~~~~  ^
  ./Region2D.hh:556:47: error: no member named 'End' in 'Region2D<INDEX, SIZE>'
    556 |	  for (itHere = this->Begin(); itHere != this->End(); ++itHere)
	|						 ~~~~  ^
  ./Region2D.hh:635:16: error: no member named 'DoesContainPoint' in
'Region2D<INDEX, SIZE>'
    635 |			  if (!(this->DoesContainPoint (rHere.m_tnY,
tnX)
	|				~~~~  ^
  ./Region2D.hh:643:22: error: no member named 'Begin' in 'Region2D<INDEX,
SIZE>'
    643 |	  for (itHere = this->Begin(); itHere != this->End(); ++itHere)
	|			~~~~  ^
  ./Region2D.hh:643:47: error: no member named 'End' in 'Region2D<INDEX, SIZE>'
    643 |	  for (itHere = this->Begin(); itHere != this->End(); ++itHere)
	|						 ~~~~  ^

The member functions `DoesContainPoint`, `Begin` and `End` are all
commented out in Region2D.hh, probably because the code was never
finished up properly. The member functions referencing them are also
never used, so comment those out too, using `#if 0`, `#endif` pairs.