From nobody Sat May 06 01:09:29 2023 X-Original-To: multimedia@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QCqG20P1gz4B286 for ; Sat, 6 May 2023 01:09:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QCqG15FHBz45hY for ; Sat, 6 May 2023 01:09:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683335369; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vd8EVu4Ucn85A8I+rXWxtvnB/aq76kDCT8YeklasrQ4=; b=KtCn4I87Rw/IgI2q+yYaQB5f/p7SEidV22a9bWOOhnNpGKHTvxmoD+mczW25b66k3xUSeE P4mHSuZQGm3TCMdKu4zFpa7sZKy0ZwS37pfDOW7wdKO0hNUTFBnkmg1SH4ZMvL7cQyqUuQ EZxVME9xsvgLmuf5YsmVOMbWuLnS3ZS7O0x5JFcOnz3r4q/4WRqVz7OFgkF2I3KxamWyFN HaefV7xjjTmsrE+wfhsGd5yvGo1y3CaP54yifuim65S4WjvSGpJDksAee/CA55RNDXaRxp cOnwmaFtbxFoYFTUniue37oBU+vv7ZdOiU3j3Dp0g5A8Xtr6lXit/goi54OM2A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1683335369; a=rsa-sha256; cv=none; b=AX5XbQ9feLxyDljL5Zawjn+Nrd2xWZRAIpn4TPg8k9GUpMJ2HYpFnsA4EkIpy07A63kCaY S8UjAt5q0wnKrmb+vvN2egzwvun51rxZpmj+T/XB320Rvd0oOIQOgaZ0rNmuMhOzha6hNR cdsrOotkEmhXb2pkajfPWx3GhPqxnRgWZhJbgifKjQwa/U+AY+mKnI3ssy/IVzsmCV615L SqELpR/qCDGpc4JWbX9P81rb7Gzr0x/MS8ErIoyxOezDIBiQyiVb8CH659BxamAt8ZCHPL UroTGTHTA7ywJdM/eMUCBUva/3T/pE20actBkXnJLE9oi1rlnGQ6W7P1X7dPow== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QCqG14D39zGq0 for ; Sat, 6 May 2023 01:09:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 34619TCn099166 for ; Sat, 6 May 2023 01:09:29 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 34619TNn099165 for multimedia@FreeBSD.org; Sat, 6 May 2023 01:09:29 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: multimedia@FreeBSD.org Subject: maintainer-feedback requested: [Bug 271272] graphics/libcaca: Hidden dependency on Xlib.h Date: Sat, 06 May 2023 01:09:29 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: multimedia@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Multimedia discussions List-Archive: https://lists.freebsd.org/archives/freebsd-multimedia List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-multimedia@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N Bugzilla Automation has asked freebsd-multimedia (Nobody) for maintainer-feedback: Bug 271272: graphics/libcaca: Hidden dependency on Xlib.h https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D271272 --- Description --- Note: This bug seems to be a repeat of bug #153846, but I cannot find what about "the process" fixed or stopped this behavior with 0.99beta17, and it's still present with 0.99beta19. Problem: When building libcaca with IMLIB2 port option set, if imlib2 was b= uilt without X11 support, then this error occurs: In file included from ../src/common-image.c:21: /usr/local/include/Imlib2.h:26:10: fatal error: 'X11/Xlib.h' file not found #include ^~~~~~~~~~~~ 1 error generated. *** Error code 1 Stop. make[3]: stopped in /wrkdirs/usr/ports/graphics/libcaca/work/libcaca-0.99.beta19/examples *** Error code 1 This is because imlib2 uses the AC_PATH_XTRA macro, and relies on X_DISPLAY_MISSING getting defined when --without-x is passed to imlib2's configure. Within Imlib2.h, There are several #includes and function protot= ypes that are guarded by an #ifndef X_DISPLAY_MISSING. By contrast, libcaca defi= nes its own --enable-x configure flag to permit X11 detection, and only uses the AC_PATH_X macro. Solution: Have a conditional CFLAGS definition for libcaca based on the OPTIONS combination of IMLIB2 set and X11 unset. I will also submit a patch upstrea= m, but libcaca's last commit was 18 months ago, so I am not optimistic it will= be merged.