maintainer-feedback requested: [Bug 272480] audio/fluid-soundfont: Add the soundfont link /usr/local/share/soundfonts/default.sf2 that some users expect

Bugzilla Automation <bugzilla@FreeBSD.org> has asked freebsd-multimedia
(Nobody) <multimedia@FreeBSD.org> for maintainer-feedback:
Bug 272480: audio/fluid-soundfont: Add the soundfont link
/usr/local/share/soundfonts/default.sf2 that some users expect
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272480



--- Description ---
Background:

The 'dmidiplayer' executable installed by audio/dmidiplayer prints this error:
> MIDI Output "Error: fluid_sfloader_load(): Failed to open
'/usr/local/share/soundfonts/default.sf2': File does not exist.\nError: Unable
to open file '/usr/local/share/soundfonts/default.sf2'\nError: Failed to load
SoundFont \"/usr/local/share/soundfonts/default.sf2\"\nWarning: Failed to set
thread to high priority"


This soundfont file name comes from fluidsynth from this line in
audio/fluidsynth:
> cmake_admin/DefaultDirs.cmake:  set (DEFAULT_SOUNDFONT
"${CMAKE_INSTALL_FULL_DATADIR}/soundfonts/default.sf2" CACHE STRING

This file is not installed, but there is a tradition to reference such file.

For example, to work around this problem audio/drumstick/Makefile replaces
default.sf2 with /usr/local/share/sounds/sf2/FluidR3_GM.sf2 installed by
audio/fluid-soundfont.


The attached patch creates the symbolic link so that any applications that
happen to expect share/soundfonts/default.sf2 would fine it.