From nobody Wed Feb 21 21:19:38 2024 X-Original-To: java@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Tg8L33n96z5BP5L for ; Wed, 21 Feb 2024 21:19:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Tg8L32l1jz4KZj for ; Wed, 21 Feb 2024 21:19:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708550379; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CBSbkjecFSB8BWq9wytoPxn5VA0PHyz5VDlak/fGcPM=; b=I26y8L2SVI7QNnvVdC7TAY8U5G/aouhp19jFIK0GYf3JD2TT+XfeNsujnya9e9lLVgXdKq CIur/LE2A9kG5Lc/T36SAoUMmkdB6fHFuMOidRF5cj/pM3xoiJ5r1Bx55NJ973oGQrPQ0l ES+SkOzQD9hEu70IKwwkrAGnz87kPp8L1sBuHVz+bu3Rbq5HoLoXqsCIbrAGJ6jQW8P8/G YgD98jYREEodo3q4dPowZsFOiQr8pkAbOeMYu6WYRPeaL8RWB7E6R/kziZOTq4Q7twQCR7 pWLQA0++uP64JITODrc33CjDaVi1uoWGjQT8rvXFshqAW+sVCMnM3vDpb3Wuyw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1708550379; a=rsa-sha256; cv=none; b=SiY1owYKsJgUWmBeFCaqJ12nu4Cj5zr5mPjUZlFsLsfFk2cvir+MP8iZlbjyrt5+5buwwV WjVzIxP83P+xnckxfJ1EIt0gyWiZw97/OD3OZisw372KNV2QB2CmqsEjKs4njsOim6SWfD uTBfHGONpiwbJcQM4r5yjmCLMyNv+9h5LFbw2WtStEMU1SrK5N4jiCoUfpHk5/lUiPihti YUN3xxIRwKlDU8Hgg9n2jKa2u9dHvDjN2h95sM8l3NgKzVd6bbsGAjcdz7EEXMxb1O+fYw 7z3JCc6JUGJyedsWEzIhhORiju8Au3pEV/luZACI9DYTlEcAsNpM3+AkkGtcoA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Tg8L31q8Xz1JgG for ; Wed, 21 Feb 2024 21:19:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 41LLJdQl010329 for ; Wed, 21 Feb 2024 21:19:39 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 41LLJdLV010327 for java@FreeBSD.org; Wed, 21 Feb 2024 21:19:39 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: java@FreeBSD.org Subject: [Bug 277204] *: ports misusing WITH_CCACHE_BUILD and NO_CCACHE Date: Wed, 21 Feb 2024 21:19:38 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: mandree@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: portmgr@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Porting Java to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-java List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-java@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277204 --- Comment #3 from Matthias Andree --- Gleb, thanks for looking at rawtherapee. I have 5.10 cooking, test compiles= on the off-versions got delayed due to the usual rust rebuild madness (because= the upstream package for 13.2 wasn't up to date with the port), and I successiv= ely tried getting rid of all that you criticize. The thing about rawtherapee is, we don't have OpenCL, but only OpenMP, and = it is computationally VERY expensive (as raw camera image processing is in general, with Bayer/Foveon/TransX demosaicing, denoising and thereabouts), = so we need to squeeze every bit out of the CPU that we can. RT would currently build against GCC 12.3 on amd64, even without too many of the force options, so... - we should use LTO because upstream recommends it and it seems to increase performance on cross-compilation-unit calls, - which incurs the forcing of binutils to avoid linker failures, - we need to work around our cmake not being ccache friendly, because - bei= ng written in mostly C++ - rawtherapee is slow enough to compile (and I could argue that our ccache.mk is broken if it sets CCACHE_ENABLE so late that I can't derive CMAKE_ARGS with a simple .if... - it only gets set in the "pos= t" phase, not in port.options.mk, not in port.pre.mk) - last time I tried, run-time performance with LLVM compiler was inferior to GCC's (might be worth retrying, but that would delay the RT 5.10 upgrade to= at least next week or the week after) and I'm not sure what the state of libst= dc++ vs. libc++ affairs currently is. Smoke-testing in post-install is something I found necessary on my end beca= use there used to be builds that would crash on start, and I don't want them to escape my testing. Without test images in the source folder, these will be skipped. Unfortunately, poudriere has no support to run "make test" and dep= ends properly for "poudriere bulk" and "poudriere testport".=20 Arguably I could try to provide such stuff for .mk scripts now that some of= the people who were constantly getting in my way or asking for perfection inste= ad of an -exp run are no longer part of portmgr@ and haven't been seen as part= of the project in a long time, but that, too, is beyond my available time right now. Back to the rawtherapee 5.10 topic, I can remove some things, but none of t= he "lighter" ccache approaches would actually use ccache to build, so the ccac= he variable abuse that Benjamin pointed out cannot be fixed yet, I've tried th= at. Anything but the way it's written currently ends up with a hard-coded /usr/local/bin/g++12 as a compiler (with hardcoded path, so we can't BINARY_ALIAS or play PATH tricks) as a result of the cmake run, and what the port currently does seems to be one of the official cmake ways to get ccache into play. --=20 You are receiving this mail because: You are on the CC list for the bug.=