Re: New lock-order reversal
- In reply to: Steve Kargl : "Re: New lock-order reversal"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 10 Sep 2024 07:14:00 UTC
On 6 Sep 2024, at 19:15, Steve Kargl wrote: > On Fri, Sep 06, 2024 at 06:49:48PM +0200, Kristof Provost wrote: >> I’ve had another look at this, and while I can probably avoid this >> for >> setting the tunnel function (basically by assuming setting it never >> fails or >> is already done, which is currently the case), I’m not happy with >> the only >> solution I see on the removal side (i.e. “don’t, just trust that >> the socket >> will be closed soon”). > > Thanks for the patch. I'll add to my kernel when I rebuild it. > Unfortuantely, I have way too little understanding about locking > within the kernel to be of much help. > I’m not very happy with that first patch. Can you try [https://reviews.freebsd.org/D46615](https://reviews.freebsd.org/D46615) and [https://reviews.freebsd.org/D46616](https://reviews.freebsd.org/D46616) instead? (That first patch is just cleanup, but you’ll probably want it to avoid conflicts.) Best regards, Kristof