Re: Review D38047 ... and then there was one....

> On Oct 7, 2024, at 08:08, Cy Schubert <Cy.Schubert@cschubert.com> wrote:

> Yes. I was about to suggest this. Plus, any proposed commit log message
> must answer the questions why, what and how. With special attention to why.

I have the same feelings as Cy.

FWIW, part of the reason why large/complex changes like this languish in my review queues is in part due to reasons like this.

Unless I am a SME in the area who is driven to understand what the change aims to achieve, I will not take the time to review large/complex chances. I have a lot of other things in my life which take priority over large code reviews.

Please break the large change down into a smaller set of changes/reviews to make it easier to review the overall change effectively.

Cheers,
-Enji