From nobody Wed Dec 25 15:14:19 2024 X-Original-To: hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YJFfd45V0z5hTTg for ; Wed, 25 Dec 2024 15:14:33 +0000 (UTC) (envelope-from mohammad@thelightbird.com) Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YJFfc6RJjz4yTG for ; Wed, 25 Dec 2024 15:14:32 +0000 (UTC) (envelope-from mohammad@thelightbird.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=thelightbird-com.20230601.gappssmtp.com header.s=20230601 header.b=ZjtYVejo; spf=fail (mx1.freebsd.org: domain of mohammad@thelightbird.com does not designate 2a00:1450:4864:20::22f as permitted sender) smtp.mailfrom=mohammad@thelightbird.com; dmarc=none Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-3035046d4bfso52485031fa.0 for ; Wed, 25 Dec 2024 07:14:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thelightbird-com.20230601.gappssmtp.com; s=20230601; t=1735139670; x=1735744470; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=KPG1y1Qo750ZZZe9nHDm25/T3EVdLJrCMiN1zY83MMs=; b=ZjtYVejoGHfaJBAz+njBp1AGZ4utv9508Mdb3dIZcqJ8E/HZ6I+xOisYNvabVxVpuk C4fWFgx1+F6As5dvknugGb7vguIJcPmzRnOPWHh8/8n64pC01qPafrYFuZhz/4W3SmXt fFyYCVyVh50p3lzmcRxl/4O09yIbP6dNvZHwXNwH4oBiUgZQgK2HV84AqtkB4kDkFXYt p1lgH2yUYH7AqQyruj+ZXOoIDEUWBWb8gaDNnIQKvD5jwB8DoIALDbrnk4nKViTOzV2i zbJnbtPua4rrwfozA7JxPYB+b2KdemJxRlKfK2ZsbXd9rTJwiHn5bj9fUWTuy8vDPaYg LaiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735139670; x=1735744470; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KPG1y1Qo750ZZZe9nHDm25/T3EVdLJrCMiN1zY83MMs=; b=pxx5MH6vRSPPB+dNqnYxsRvU20J77b7/YNShpO7NKzOzyUY0jerMOQhW7SFegMG50j MvbZOeCj3b1iVhOOsO/y/Wt9wp91M7I0pKA2dwCT9XcobK884s43GTA0P0Oz99jeKcFt 7KO2WGJ3ETVg19Hw0ilKMXuBLsjcD+URQYdLH4kGcx4amyGhsMcJQM2OM57MiVf1lAiK gWKaZ8ld/2m+OWr4FjccN5QEiUwJZZ0Mg4fu0E8V7HC3F7FQw0nyWo2FZ7A0lmwTVeet b5qxHxpQzC/LqwlDZjXTRhgVDCVcqbKbtbLg/myNhHZM11T/LbilTvZQkKez7Zdshi4/ 70WA== X-Forwarded-Encrypted: i=1; AJvYcCWy9rIZ9nG9bwwtU4yrQxYSezMNgo+4Ob61Ej12jc6vd/qHTEwfhIZ3FZVkdCIUPUHAgCEUj9Ph@freebsd.org X-Gm-Message-State: AOJu0YxQC5s86zbEQ0G4WimG54F/9u8u7UmgX5t+IGePvTOQOqaOO8qz Fg0pz2Za/tEyAH1gdfV2gQl9/p9aufFizlE0ps0mhigu9am1o711aw9Db/HophEsZUN4Bkr61TN VwjRZCbm3Btsv620hx4vD6T+Ajd+vRA/qtbs/ X-Gm-Gg: ASbGncuhk1d44w1Js6COU2BPX/9V645JgOz9vPLpy1sEtcb+rP36vRHwHTNPeZR/tOy nSAAS7u4p6N64PaAuFiO8siSL9MS5aS+UUJBrsCoyKItswPBWxXWol9JtSO2vMDDe8/M= X-Google-Smtp-Source: AGHT+IF2L/xc/ug5rjUn0TzErYX4U3JOdw38YBxIcAK6NePkDrH7zugRsmEdRBUaaUCCqWlFec6FP+3PAuubriK1HeI= X-Received: by 2002:a2e:a99d:0:b0:300:c10:7c26 with SMTP id 38308e7fff4ca-3046851f9d9mr55608021fa.4.1735139669972; Wed, 25 Dec 2024 07:14:29 -0800 (PST) List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@FreeBSD.org MIME-Version: 1.0 References: <864j8lmaub.fsf@phe.ftfl.ca> <20241223032523.d9700186b36c60f3ed9b5995@dec.sakura.ne.jp> In-Reply-To: <20241223032523.d9700186b36c60f3ed9b5995@dec.sakura.ne.jp> From: Mohammad Noureldin Date: Wed, 25 Dec 2024 16:14:19 +0100 Message-ID: Subject: Re: USB4/TBT3 support To: Tomoaki AOKI Cc: Joseph Mingrone , hackers@freebsd.org, scottl@freebsd.org, Ed Maste Content-Type: multipart/alternative; boundary="000000000000aa32bf062a19af56" X-Spamd-Result: default: False [-2.30 / 15.00]; R_SPF_FAIL(1.00)[-all]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.999]; R_DKIM_ALLOW(-0.20)[thelightbird-com.20230601.gappssmtp.com:s=20230601]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; ARC_NA(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_ONE(0.00)[1]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; MISSING_XM_UA(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::22f:from]; DMARC_NA(0.00)[thelightbird.com]; MLMMJ_DEST(0.00)[hackers@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[hackers@freebsd.org]; DKIM_TRACE(0.00)[thelightbird-com.20230601.gappssmtp.com:+] X-Rspamd-Queue-Id: 4YJFfc6RJjz4yTG X-Spamd-Bar: -- --000000000000aa32bf062a19af56 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Tomoaki, 1st of all, thanks a lot for sharing your notes and insights helping to enrich the discussion On Sun, Dec 22, 2024 at 7:25=E2=80=AFPM Tomoaki AOKI wrote: > On Fri, 20 Dec 2024 17:04:20 +0100 > Mohammad Noureldin wrote: > > > Hi. > Thanks for the pointer. > > Some notes: > *hselasky@ (RIP, Hans...) suffered from the lack of official and open > hardware specs for implementing his driver. > > *hselasky@ wasn't going to implement TB3's security features > as it seemed NOT to be sufficient for actual security in spec itself. > > *I have Titan Ridge TB3 controller (falles back to Intel Cannon Lake > USB 3.1 controller when TB3 device is not connected) in my ThinkPad > P52, but hselasky@'s last driver didn't work for it, as his driver > only supports older generation of controller chipset (with the lack > of information). > > *P52 recognizes TB3-only device (Samsung X5 external SSD I've > purchased for test) as internal PCIe drive if it was attached > before powerint on the computer, but hot deplugging causes panic, > with and without hselasky@'s driver installed. > > *My related info are in Bug 237666 [1]. > > [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D237666 Believe or not, I was in touch with HPS (may he RIP) over this specific PR given my general interest in USB and I've even purchased 3 2nd hand machines to help testing and get to the root cause: - Dell Precision Tower 5810 -# Which proved not to be useful for this case - Lenovo ThinkPad P52s - Lenovo ThinkPad T480 -# Because Bjoern Zeeb (bz@) could reproduce the original reported issue on this machine and he wrote down some notes about his findings in [1] But that EuroBSDCon of year 2023 when I was planning to bring one or both of these Lenovos with me to tinker on them with HPS, I cam to know that he passed away before the EuroBSDCon's starting date ... RIP HPS. I've added the *"Problem Reports to be Possibly Revisited"* section [2] because in addition to [3] I've noticed other similar PR(s) where we can revisit after a working driver is in place to either: - Indicate that now this works - Or, it still not working, we won't support it, and write this down in a clear way for end users Also to hopefully make the scope more clear, I've added a Scope sub-section [4] > > -- > Tomoaki AOKI > Thanks again Tomoaki and happy holidays =F0=9F=91=8A [1] https://wiki.freebsd.org/BjoernZeeb/USB [2] https://wiki.freebsd.org/MohammadNoureldin/FreeBSDUSB4TBT3Support#Problem_R= eports_To_Be_Possibly_Revisited [3] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D237666 [4] https://wiki.freebsd.org/MohammadNoureldin/FreeBSDUSB4TBT3Support#Scope --=20 Thanks - Mohammad Noureldin -- "Life is like riding a bicycle. To keep your balance you must keep moving" - Albert Einstein --000000000000aa32bf062a19af56 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Tomoaki,
1st of all, thanks a lot for sharing your notes and insights h= elping to enrich the discussion

On Sun, Dec 22, 2024 at 7:25=E2=80=AFPM Tomo= aki AOKI <junchoon@dec.sakura.ne.jp> wrote:
On Fri, 20 Dec 2024 17:04:20 +0100
Mohammad Noureldin <mohammad@thelightbird.com> wrote:
<= br>
<snip>
=C2=A0

Hi.
Thanks for the pointer.

Some notes:
=C2=A0 *hselasky@ (RIP, Hans...) suffered from the lack of official and ope= n
=C2=A0 =C2=A0hardware specs for implementing his driver.

=C2=A0 *hselasky@ wasn't going to implement TB3's security features=
=C2=A0 =C2=A0as it seemed NOT to be sufficient for actual security in spec = itself.

=C2=A0 *I have Titan Ridge TB3 controller (falles back to Intel Cannon Lake=
=C2=A0 =C2=A0USB 3.1 controller when TB3 device is not connected) in my Thi= nkPad
=C2=A0 =C2=A0P52, but hselasky@'s last driver didn't work for it, a= s his driver
=C2=A0 =C2=A0only supports older generation of controller chipset (with the= lack
=C2=A0 =C2=A0of information).

=C2=A0 *P52 recognizes TB3-only device (Samsung X5 external SSD I've =C2=A0 =C2=A0purchased for test) as internal PCIe drive if it was attached<= br> =C2=A0 =C2=A0before powerint on the computer, but hot deplugging causes pan= ic,
=C2=A0 =C2=A0with and without hselasky@'s driver installed.

=C2=A0 *My related info are in Bug 237666 [1].

[1] https://bugs.freebsd.org/bugzilla/show= _bug.cgi?id=3D237666

Believe or not, I = was in touch with HPS (may he RIP) over this specific PR given my general i= nterest in USB and I've even purchased 3 2nd hand machines to help test= ing and get to the root cause:
- Dell Precision Tower 5810
<= div>-# Which proved not to be useful for this case
- Lenovo Think= Pad P52s
- Lenovo ThinkPad T480
-# Because=C2=A0Bjoern = Zeeb=C2=A0(bz@) could reproduce the original reported issue on this machine= and he wrote down some notes about his findings in [1]
=C2=A0
But that EuroBSDCon of year 2023 when I was planning to bring one o= r both of these Lenovos with me to tinker on them with HPS, I cam to know t= hat he passed away before the EuroBSDCon's starting date ... RIP HPS.

I've added the "Problem Reports to be Possib= ly Revisited" section [2] because in addition to [3] I've noti= ced other similar PR(s) where we can revisit after a working driver is in p= lace to either:
- Indicate that now this wo= rks
- Or, it still not working, we won'= t support it, and write this down in a clear way for end users

=
Also to hopefully make the scope more clear, I've added a Sc= ope sub-section [4]



--
Tomoaki AOKI=C2=A0 =C2=A0 <junchoon@dec.sakura.ne.jp>

Thanks again Tomoaki a= nd happy holidays=C2=A0=F0=9F=91=8A

=

--
Thanks
- Mohammad Noureldin
--
&q= uot;Life is like riding a bicycle. To keep your balance you must keep movin= g"
- Albert Einstein

--000000000000aa32bf062a19af56--