Re: Remove timecounter tc_counter_mask member?

On Tue, Sep 19, 2023, 11:41 AM Poul-Henning Kamp <phk@phk.freebsd.dk> wrote:

> --------
> Sebastian Huber writes:
> > On 16.09.23 22:44, Poul-Henning Kamp wrote:
> > > Sebastian Huber writes:
> > >
> > >> the timecounter structure contains a tc_counter_mask which enables
> > >> support for time counters implementing less than 32-bits:
> > >> Is the sys/x86/isa/clock.c still used? Are there chips on the market
> > >> with 24-bit ACPI timers?
> > > ... and are there any FreeBSD platforms using narrow timecounters
> > > outside the src-tree ?
> > >
> > > My personal gut feeling, is that we can get away with it, once i386
> > > is out of the picture.
> >
> > If it is in principle acceptable to remove the tc_counter_mask at some
> > point in time, would it make sense to issue a warning if a timecounter
> > is installed with a mask not equal to 0xffffffff?
>
> It would be a good a way to warn people...
>

I'd warn on first use to cut down on the noise

Warner

-- 
> Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
> phk@FreeBSD.ORG         | TCP/IP since RFC 956
> FreeBSD committer       | BSD since 4.3-tahoe
> Never attribute to malice what can adequately be explained by incompetence.
>
>