Re: how to compare branches?

From: Warner Losh <imp_at_bsdimp.com>
Date: Tue, 25 Jul 2023 02:35:03 UTC
On Mon, Jul 24, 2023, 8:19 PM Steve Kargl <sgk@troutmask.apl.washington.edu>
wrote:

> On Mon, Jul 24, 2023 at 08:27:25PM -0400, Ed Maste wrote:
> > On Mon, 24 Jul 2023 at 15:43, Brooks Davis <brooks@freebsd.org> wrote:
> > >
> > > or you can see individual commits graphically on mfc.freebsd.org with
> > > the filter @lib/msun/
> >
> > We also have a tool in the base system which will list the unmerged
> commits:
> >
> > % sh tools/tools/git/mfc-candidates.sh -a lib/msun
> > 34cc08e33698 Save all fpcr/fpsr bits in the AArch64 fenv_t
> > 7702d940ec9a Avoid -pedantic warnings about using _Generic in
> __fp_type_select
> > 2b9a828c9949 Set default SPE FP environment
> > 292815eac623 Fix powf().
>
> This ...
>
> > 3550a49f6814 msun: Add copyright notices
> > 455b2ccda3df * lib/msun/Makefile:   . Disconnect b_exp.c and b_log.c
>
> This ...
>
> > from the build.
> > 03a88e3de9c6 * lib/msun/Makefile b/lib/msun/Makefile:   . Disconnect
> > imprecise.c from the build.  This file can be deleted.   . Add
> > b_tgammal.c to the build for ld80 and ld128 targets.  The ld128     is
> > a 'git mv' of imprecise.c to ld128/b_tgammal.c.
>
> This ...
>
> > b94b8bf7027e mips: Remove msun support
> > 56f5947a7102 Remove checks for __GNUCLIKE_ASM assuming it is always true.
> > c44ca4c227f7 msun/Makefile: Fix conditional and unbreak the build.
> > Approved by:imp Fixes:       20adba8bc1beb125d5e5ed8f12e747ae79ca6a10
> > ae902a5be9b8 libc: Simplify soft-float on 32-bit arm
> > 4d846d260e2b spdx: The BSD-2-Clause-FreeBSD identifier is obsolete,
> > drop -FreeBSD
>

I'm merging this tomorrow or Wednesday.


> Should all of these be merged to stable/13?
>
> fix bugs or provide missing implementations of math functions.  The
> other patches either touch target-specific code (arm, aarch64) that
> I don't have and can't easily test or are cosmetic (e.g., BSD 2-Clause).
> I haven't seen any new libm bug reports, so likely all of the above
> can be merge.
>

Ignore the bsd 2 clause stuff. Life got too busy for me....

Warner

Note, Paul Zimmermann (a MPFR developer) that FreeBSD is only OS
> that he's aware that supplies sinpi, cospi, and tanpi functions.
> While testing, he found a few issues with these, reported them
> to me, and I have a patch under going test.  I'll submit it
> shortly.
>
> te
>
> --
> Steve
>
>