Re: What is the status of the FreeBSD development process now?

From: Warner Losh <imp_at_bsdimp.com>
Date: Fri, 04 Nov 2022 01:59:45 UTC
On Thu, Nov 3, 2022, 7:39 PM <iio7@tutanota.com> wrote:

> Nov 4, 2022, 01:34 by imp@bsdimp.com:
>
> > According to my data, reviews are up significantly since that email.
> >
> > I'm guessing you haven't been able to confirm anything has changed
> because
> > you've not actually looked for data, since it's trivially easy to find
> that data.
> >
> No, I have looked. I never said that I didn't find anything. However, what
> I was
> suspecting to find was a set of rules put in place to prevent anything
> like the
> wireguard issue from happening again.
>

Your expectations are off. You need to look at the data.

I guess my expectations were too high. Sure, things has improved, but
> without
> a clear set of rules - like ALL commits must be reviewed before going into
> the
> kernel, base, etc. - the same problem can happen again.
>

Now I know you are trolling...

Nobody that's has done engineering for any length of time would expect
reviews to catch all problems. That's at best wishful thinking and at worst
a horribly toxic management culture.

What has happened is that there is more review, the commits are generally
much much smaller and more people are reading the commits after the fact. I
half jokingly told a coworker recently the fastest way to find a problem in
my code is to commit it since so many people read it, I get feedback right
away.

Again, these things are present in the data.  There are way more tests than
being committed than before. There is more CI coverage than before. There
are efforts to greatly expand that. The layered approach gies a long way
towards catching issues like this than before. Thinking promulgating some
simplistic rule change is at best overly simplistic think and disingenuous
trolling at worst.

Warner

Kind regards.
>
>
>
>
>