Re: What is the status of the FreeBSD development process now?

On Thu, Nov 3, 2022 at 6:47 PM <iio7@tutanota.com> wrote:

> >> In OpenBSD, AFAIK, absolutely no code goes into the project without
> >> at least 1 other people reviewing it and approving it. This can be
> >> seen with the "OK" in the commits.
>
> > This has been shown to be false:
> >
> >
> https://lists.freebsd.org/archives/freebsd-questions/2022-November/002192.html
>
> I have just replied to that. It's wrong. Take a look at the
> OpenBSD commit logs.
>

Many, but not all, have the OK tag. My quick grep over the last 1000
commits I have in my tree suggests about 50%:
% git log -1000 | grep -i ok | wc
     524    2048   13689
which is the 1000 commits ending around May 1, 2022 this year (the
last time I pulled an OpenBSD tree on the machine I have handy).


> We're not talking about ports, the issue is related to the kernel and
> base, etc.
>

Many, but not all, FreeBSD commits have a reviewer these days, and
the main exceptions are trivial spelling errors, build botches and other
similar things.

A quick grep suggests of FreeBSD suggests similar numbers:

% git log -1000 | grep 'Review' | wc
     555    2163   22658
vs
%  git log -1000 HEAD~20000 | grep 'Review' | wc
     319    1220   10577

which is in the time period a few months before the email in your original
email.

For both OpenBSD and FreeBSD this undercounts the number of commits
that had a review that wasn't documented, or used a non-standard form
to document, or (in FreeBSD) submitted by was reviewed by the committer,
but no 'Reviewed by' was added to the commit because it was believed to
be implicit (it is, but that's hard to grep).

So it appears that the numbers are currently about the same and that
different
methods may give slightly different results because of the inconsistent
marking
of the tree. Because marking is inconsistent, and some actually reviewed
changes
go undocumented, it is really hard to say that one project is better than
the others.

Warner