Re: [PATCH 0/6] Simplify pps_capture() and pps_event()

You might have better luck getting these patches reviewed with either a
pull request against github
mentioning the usual time people (phk, etc), or as a series of phabricator
reviews adding said people.
If unsure, mention/add me and I'll add others :).

Hackers is (or has been) a high enough volume list that this may not be
noticed by those people,
especially since there's not a strong tradition of reviewing patches here.

On their surface (without having had time to study them in depth), these
seem reasonable improvements.
But having some context about why you are making these, and/or measurements
you've done to show no
harm (or hopefully an improvement) would be even better. This is slightly
tricky code that has had about 20
years of "soak time" in some fairly demanding environments, and so some
caution is advised in updating
it.

Warner

On Thu, Jul 7, 2022 at 9:27 AM Sebastian Huber <
sebastian.huber@embedded-brains.de> wrote:

> This patch set tries to simplify the pps_capture() and pps_event()
> processing.
> I am not sure if the rounding change is an improvement.
>
> Sebastian Huber (6):
>   pps: Load timecounter once in pps_capture()
>   pps: Simplify capture and event processing
>   pps: Move pcount assignment in pps_event()
>   pps: Directly assign the timestamps in pps_event()
>   pps: Simplify the nsec calculation in pps_event()
>   pps: Round to closest integer in pps_event()
>
>  sys/kern/kern_tc.c | 72 +++++++++++++++++++++++-----------------------
>  1 file changed, 36 insertions(+), 36 deletions(-)
>
> --
> 2.35.3
>
>
>