From nobody Mon Feb 07 23:04:19 2022 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 811D719A2312 for ; Mon, 7 Feb 2022 23:04:57 +0000 (UTC) (envelope-from m.e.sanliturk@gmail.com) Received: from mail-ot1-x332.google.com (mail-ot1-x332.google.com [IPv6:2607:f8b0:4864:20::332]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Jt1tw6BD5z4h5F for ; Mon, 7 Feb 2022 23:04:56 +0000 (UTC) (envelope-from m.e.sanliturk@gmail.com) Received: by mail-ot1-x332.google.com with SMTP id w27-20020a9d5a9b000000b005a17d68ae89so11971617oth.12 for ; Mon, 07 Feb 2022 15:04:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=h8Rf/V+ImoLbJnHLXC/RTiOFG3r1jKlDzeLnZQA49ao=; b=Gf3ZculpLm+bk0hFjNF8nvEWEwzA/whuhJLlCqWidMUd0LptIewVFFqcvg762rvTzB o+XWxEfhWcS0ZT6dPdnfijXAFTRy13b2hj+YZ0UMiyqfFFABWmm3GUfDU5D736sgNkuB 1jwzLC/LQ7wzxlfqjnk81OW6R2by9V8WyyUJffE7gOwRq24KnWnryCPh8L6ZCyNsuU0/ 7EfuepqPiK2JxFaYoSfp+re4ql5ltA00SLDVF8JEzhHGryckZGoZDGdy4uAnxf+5aosD KBb2BPvhXLTPJa8ONELO9JYZs3f+qSjcdSz/sLdgRJunXyCnKZVwBWJ1lAeihQYyC2LW JOGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h8Rf/V+ImoLbJnHLXC/RTiOFG3r1jKlDzeLnZQA49ao=; b=SgPK2OBRVqLv3a2+is3IF7IUrQs059BdCnoekG4N55f4N2+MLR5oSxpNqqefg0480B 6osqAtGtZ2BsVSrO93okOvVcsER0WwW7ffz55S2F69Hzp02o+d/Mt7o/YwGigTf7LSs8 u5l6XdU5ipQsJWkbEMXNAtWJc1Hy9CUvq9kW5QESsjV1zyEQKR0UJT9Me0L+tlW1zM5M ccFtlXH7qO8ccmu1Sa7xJrj0y5NCeEZlKdOxwHi51Zxsic4DwyFXUyqRPGAdHHc4XFuT 6EkmNk19AtBhwjohCP/kzz78xS+BoqiWBtQCYBz7erD4pDQ7pIKXI1l1vVoRasR+u6q/ eGqg== X-Gm-Message-State: AOAM531AVXE77aPCjge1fbRX0lSuyYumtTonZORrXEviGD8AnWPWN9ME KCvCkP+qWRGy4eeBkWtDfuz5nPYiFc9mYjr+lOQ= X-Google-Smtp-Source: ABdhPJwex54PMjp3ft6E9UnLyEdhUOMkFJIuEfzMA1fjKpbTrML1cldLJOcbvro8RMtj9hX8iLPnEeOXKDnYVXFxrdw= X-Received: by 2002:a9d:6041:: with SMTP id v1mr842376otj.35.1644275095992; Mon, 07 Feb 2022 15:04:55 -0800 (PST) List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 References: <202202072032.217KWUdU085792@critter.freebsd.dk> In-Reply-To: From: Mehmet Erol Sanliturk Date: Tue, 8 Feb 2022 02:04:19 +0300 Message-ID: Subject: Re: ntp_init() looks like a nop To: Warner Losh Cc: Poul-Henning Kamp , Sebastian Huber , FreeBSD Hackers Content-Type: multipart/alternative; boundary="000000000000027cbc05d775a146" X-Rspamd-Queue-Id: 4Jt1tw6BD5z4h5F X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=Gf3Zculp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of mesanliturk@gmail.com designates 2607:f8b0:4864:20::332 as permitted sender) smtp.mailfrom=mesanliturk@gmail.com X-Spamd-Result: default: False [-4.00 / 15.00]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MID_RHS_MATCH_FROMTLD(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::332:from]; MLMMJ_DEST(0.00)[freebsd-hackers]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N --000000000000027cbc05d775a146 Content-Type: text/plain; charset="UTF-8" On Tue, Feb 8, 2022 at 12:33 AM Warner Losh wrote: > > > On Mon, Feb 7, 2022 at 1:34 PM Poul-Henning Kamp > wrote: > >> -------- >> Sebastian Huber writes: >> >> > The ntp_init() function sets a couple of global variables to zero. >> These=20 >> > variables should be in the .bss section. Are they not already cleared=20 >> > during the kernel loading? >> >> They are, but I kept the code to minimize the diff relative to Dave Mills >> original version of the code. >> >> It can go no. >> > > I think I lost the email race. I just pushed Sebastian's changes. Is this > a request to not do this? If so, I'll revert. > > Warner > My reply is not an answer to your question , but I want to make a remark . I am developing a software about "A multi-media information management system" ( a continuation of my PhD thesis demonstration program ) having around 12 000 Pascal procedures . For "Record"-s , I am doing the following : By using a script system , I am generating many Procedures about operations on that "Record" , such as : (1) Allocate (2) Initialize (3) ... (n) Dispose In your case , it is said that "in another part this record is initialized ..." Assume that , "another part" is modified to ignore this initialization , and there is not a call to an initializer . In Turkish , this is called "To load a liver to a cat" ( I am sorry to say that ) . To prevent such disastrous possibilities ( after losing significant times to understand what is the reason ) I have developed such an approach . My ideas are like that . Obviously you know much better than me how to develop FreeBSD . With my best wishes , Mehmet Erol Sanliturk --000000000000027cbc05d775a146 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Feb 8, 2022 = at 12:33 AM Warner Losh <imp@bsdimp.co= m> wrote:


On Mon, Feb 7, 2022 at 1:34 PM Poul-= Henning Kamp <ph= k@phk.freebsd.dk> wrote:
--------
Sebastian Huber writes:

> The ntp_init() function sets a couple of global variables to zero. The= se=3D20
> variables should be in the .bss section. Are they not already cleared= =3D20
> during the kernel loading?

They are, but I kept the code to minimize the diff relative to Dave Mills original version of the code.

It can go no.

I think I lost the email = race. I just pushed Sebastian's changes. Is this a request to not do th= is? If so, I'll revert.

Warner=C2=A0



My reply is not an answer to your question , but I want to make a rem= ark .


I am developin= g a software about "A multi-media information management system"<= /div>
( a continuation of my PhD thesis demonstration program ) ha= ving around=C2=A0 12 000
Pascal procedures .
=

For=C2=A0 "Record"-s , I = am doing the following :

By using a scri= pt system , I am generating many Procedures =C2=A0 about=C2=A0 operations o= n that
"Record" , such as :
(1) All= ocate
(2) Initialize
(3) ...

(n) Dispose


In your case , it is said that "in another par= t this record is initialized ..."

= Assume that ,=C2=A0=C2=A0 "another part" is modified to ignore th= is initialization , and there is not
a call to=C2=A0 an init= ializer .=C2=A0

In Turkish , this i= s called "To load a liver to a cat"=C2=A0 ( I am sorry to say tha= t ) .

To prevent such disastrous possibi= lities ( after losing significant times to understand
= what is the reason ) I have developed such an approach .

My ideas are like that .



Obviously y= ou know much better than me how to develop FreeBSD .

With my best wishes ,


Mehmet Erol Sanliturk








=C2=A0
--000000000000027cbc05d775a146--