From nobody Mon Feb 07 21:31:49 2022 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 049B919AF5D0 for ; Mon, 7 Feb 2022 21:32:03 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-vk1-xa2f.google.com (mail-vk1-xa2f.google.com [IPv6:2607:f8b0:4864:20::a2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Jszqj5jp0z3FfP for ; Mon, 7 Feb 2022 21:32:01 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-vk1-xa2f.google.com with SMTP id u25so8630442vkk.3 for ; Mon, 07 Feb 2022 13:32:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Or/GETZvdeqaw2uCx2LaEGYd87UdUFJEVKUuej3iGEU=; b=Dj7zgdfmDvsCZOGcLN8DuSZBfSzehEgbNF+JPiB97uZ6FQ+eSkWHZ39TrGUspuMIkC 2hBp7noIx+RIQsPUnYWWGayJgR5j8Piy45ePMx30dyP5k2FnBc5hVckYzmDx3vKPWPB4 v95/o6a6ByNmCyShFchE4u40xn+ucO5QRvcNgDXcoKxGYlN6kaVbvP5IEbitLz7E5g+E /Tu+DiaKVHjDkGdR+grWAmEcGuJ3lbRipmaoMqwMfq3ryYOKZNS1FvaTHn91hM9sEXz0 eqQO78Eni9adZlppe4KpaoQHBKp23iOIYnesZO4QEBUwBiyk+fxLXNf77F5Y6+4CjczB g7vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Or/GETZvdeqaw2uCx2LaEGYd87UdUFJEVKUuej3iGEU=; b=qrA/aW4D9tB76YnQfU2Ml1Wy8eeh8dcG7XkQHI81wGrtVvFiwQcZ5rMtEZxXCbDqb2 wZDlGOcsizaRJsrBIb4phha2c06UvRzHLWz4tRc2S1lvf3MfS5Mm5br9xT6abG+VMT0K 6rBpRCeqfvGvEAWNKnFrAPhd5Z7bDQ0lpy+nzFPU3ZjxBGLqRmQQ/Jczx0ePpI8VlqMp h55bKwoZa/9kgGqs28kHUuBHDZe90/AjSv0Eljmq0fajfzEM/lN5NStIpx5/qrmJuv3W uTlI1jIggjwrfO8JkHfimePchuA8360LwwUETbljpgal4Aep0YwV+8pa9IdxI72rF7Fq SF8g== X-Gm-Message-State: AOAM533yb1dSYrVeMw+ObtWid/tuUeFgSESnlqONdh84nyZLs2PowXGz cVpe1OsaSwTMh6/BlKncVbIBig3MQ96tHd0Sh9PjZg3qDho= X-Google-Smtp-Source: ABdhPJzc7iqEUvVB+0s/mvzQFpJvJMOIyqHvwKJLU7gIf6ctKzGKQjH4xWLAUSBkSY7OAItT7Kjzt518vd3uIMjeQmg= X-Received: by 2002:a05:6122:130e:: with SMTP id e14mr660905vkp.26.1644269521309; Mon, 07 Feb 2022 13:32:01 -0800 (PST) List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 References: <202202072032.217KWUdU085792@critter.freebsd.dk> In-Reply-To: <202202072032.217KWUdU085792@critter.freebsd.dk> From: Warner Losh Date: Mon, 7 Feb 2022 14:31:49 -0700 Message-ID: Subject: Re: ntp_init() looks like a nop To: Poul-Henning Kamp Cc: Sebastian Huber , FreeBSD Hackers Content-Type: multipart/alternative; boundary="000000000000bba63305d77454bc" X-Rspamd-Queue-Id: 4Jszqj5jp0z3FfP X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20210112.gappssmtp.com header.s=20210112 header.b=Dj7zgdfm; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::a2f) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-1.02 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20210112.gappssmtp.com:s=20210112]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_SPAM_SHORT(0.98)[0.978]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20210112.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::a2f:from]; MLMMJ_DEST(0.00)[freebsd-hackers]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; R_SPF_NA(0.00)[no SPF record]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-ThisMailContainsUnwantedMimeParts: N --000000000000bba63305d77454bc Content-Type: text/plain; charset="UTF-8" On Mon, Feb 7, 2022 at 1:34 PM Poul-Henning Kamp wrote: > -------- > Sebastian Huber writes: > > > The ntp_init() function sets a couple of global variables to zero. > These=20 > > variables should be in the .bss section. Are they not already cleared=20 > > during the kernel loading? > > They are, but I kept the code to minimize the diff relative to Dave Mills > original version of the code. > > It can go no. > I think I lost the email race. I just pushed Sebastian's changes. Is this a request to not do this? If so, I'll revert. Warner --000000000000bba63305d77454bc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable