From nobody Tue Aug 09 18:55:12 2022 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M2MhS0MmZz4YsT3 for ; Tue, 9 Aug 2022 18:55:20 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic314-20.consmr.mail.gq1.yahoo.com (sonic314-20.consmr.mail.gq1.yahoo.com [98.137.69.83]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4M2MhQ53NJz3Wnc for ; Tue, 9 Aug 2022 18:55:18 +0000 (UTC) (envelope-from marklmi@yahoo.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1660071316; bh=NRgVoKv5+OL81YH/b6LG64w+kMwiHk7+qpARnEL4TxI=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject:Reply-To; b=q8snKVIalyJJJgiK0t7P3YKEcC5XG8KfG9PXlo5po6cn0yyu03713WqyUcEKhOrdCgI/GuyfYfGzIFOlZRGdFxrqNE/dgUOcIGb5DdIkPo3lxqW8njrUrajJ7aT0eAPN0MwtF8vMQNN7yYZV3KZtNwbjUoyIZ20ll4ePblC0TOhr7D4cmyElOehYHPOFTrd1FGcyWbRl6g8l03V/T3ZA0pAaOzMoQ2Z5i1I1QtU3L7WeG6kxAATUOp4fI+HpiMdyMnxTBDIGhLcXXVhRWifHGmwzkFndCazzxhbUQSN5FV46Ysq6N2kbxpEhCWEE/9Seh++PJ7Qs9zH8B0hIbBGXjQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1660071316; bh=A674o1kYvDojDoa0atcVRgSbp6Ku4sSU+GPaJ3/rAZn=; h=X-Sonic-MF:Subject:From:Date:To:From:Subject; b=f6s1iCoG43j21OHXgXm6gGxi6GWI31RNNhuysM5d6oxd21QKLaKSzHIJ5Mj36IzS9WYuZP38dQQmBq8CLsNnywRCNopHhILubjYxp7q6jgSHrdIfiEqqzDeuMwAASbWkwuy42NH53hJ8KBzzO3NYmht1hwt09LxnNjI7GW4g2RYXuK8rfsnCgevSDEfXLIxUj6kc43zibetVJ66LeMH2UD6CqcvADFm7BQb/mBjHswhhNavclvI31N1KMGMaPPcRVgXJDMNpVpxPvYnoHJzQPdilsfLcyRpGTe2o6LmAFEFVk0u5pYf37uWvtl3ICM/hoUo1Z8XBluALp6DTLRv2Vg== X-YMail-OSG: 0obiDwcVM1mzOCpp7kv0KHlHDaVLRTLQ9scDxAe7Il3lJGre_KRHfkmYNhC6ICM 3Ifkx7i0aiShx99zNBD1hh28JsshRFtdiqDPNLAtUpBt9R9cCXnQJ0a1JE2qemvE3SrkCnC0Sm1Q ZqGew_3k3fi0FaD5NYnoa4RZwqfzxmp_rFUQ7bKQuFYvCUARdBFfqUdQR1CGv7kRTy61DvL3_eEg 6ysfrEcOkBw.N5ua5ylnvv3dhgg2vp6lkGQmgQQ5Xue1GZXyn96MsNT4xM_ars6I6Ixy4ck9C_P7 zX6Q31P7aiFGEj6etsgAS2eb7iuqyiKAW63kWWQG01E_gusjliNvA4hpjTfgtX4PEpw2uiJE._5o Jq8qiZLOLtQo7OWFfySscvihbBzO7cINEM1be.E3vS4rG.xzcpXbhAfu1jnJNti5EVLDc.cSJnc1 7IfTvnpNY2VCoDOq3cSUejrhX7jgzM18O.5XqC5fSEPpVK1VKCMMINxz8drkzeSdwk7c6Vk2DXqG VOTPCzxVeTyOD3M1HIIDfA3lcMJibMhEt6D7xHFztR8LYepv1TycQSQ7u1xnpxRRB8kjit0WzoPn zm74NoupRyjgISyVvb8z5AV9wO1SP2JYBO6azfOCbVXwkL6KkUwNvZVF9_q.drkBLTpjTPUS_MYd dd3v4oVzINAt6UqEuoaghC7LWnQ7fkh_F4vIMp6qLTDAJaARNO3hr7CKxcfgYPMj8MJw3z91XnEz 10H0ft9yQqtYXMyHIQ06sn_0g2CFXFZSrlP.mDLD9on2vFEU_z_6dgji9ssZFWdJ7_MtkPVaL7I1 LDpeE0zZx7c6r7ee5kAjrmAIxN3Ic4umA54p3zgOIX7emgBGq2ZGemniYowAu7oEqvUGrBxODZE_ keVMLyibSGgM_OTT8p8xQPIUrp0UZAFiIgosAjOp.p4hGHDCRXYnSDACVVz_zXTgQ5vxAeldVoHu kLHcIG_xfI.rQKnSyOwOAWo3tme178K9f23g307lMurwDZy2n1.8xKSnbiiHLIJfqqh8xpYlAL2r eV_F23oTxqO8oM_fsaZ3tbowpZj43HZJKncwl.qhZ8o8vuFKN3BEB9yc37EfA7e5_gs4DQd.LRi0 XBduCsbC1K_lLhMTnYVDziiS78035IQdc7TdhH6lehfXUnrOw5F.57.D_FroCm2j3kcKnmKMBw3Q 1N.GbG4.uOFO1uFMEloWGvh_JZA75cifmvjEmRTMGFGgXjuAp_yHPq9YNPCtSdQl_Df0zRqhmLHo p20K.QS7bbJE8J3hQOYjKEULnfiBtvTFNYi0.jNtdmLvv3wnoF6ItVhKxCA91lFGkuRP2p8_cu3l _qmC6WQ1Kii6JuCyQG0bc3F3qWWt7yvetQRPQ_btljyt6WDs6fE_7WdzwoYYJMejNVyT0Bk1PGy1 epruufnFll7rQv_u04hx5WS.kPuqISdKWhoNBsCNqJ2F08U4JjIeit7q2YDqtBtn8JlI8xJ4AVTX vyFMKcuXACjaQ5zY1iogNMaJoGSNccPeJ16rWgF0isIJGhV8i5TI1KLp8NXMNvynNO1sS8MwQIpc R53cGbbVKvagv88jmKNGKbS73rbbun5Ul3At3cJNX7EecxDTtdp6NAh2H.PlY556z1inAaVzM0PK cHxhAdffkW4LNdg_joKHwLoLIiGAOh6oxLVrz0T7awzj0T9iq8VnDSiWoC3WJciJz2pwYqt7I97g ijT3S1IJvKVBuRJf_xTa5dMKxBBC_ZIEAtK4ohOd72UEn0nIuQNHrE1kwlcMxVEVeKM5z8qrvWLS NQP3ihb7V4UiJjQ3drh6hm7QEGRcVna2f3iPr6GIGGwzuNKwGcjKL4AbkseJqADnQDvQf7VmVGtf Fn3xvRFSxFpXXg7T.wDtXfH0MECw4cM8kWX6QnvpoMqYcSBDn1KIlabE57uRBSiwj5cQx1zqgMK0 UXafsjUQZaZ6FBjISjk4FBL01EPb96hlCzNadYcGCbb7_1eu5Qh0CvLzUZzxvw46XlJa.Z1BivI_ cDJ.zj.xgeln4jOGpcQL7mm6eufHn.LlCV5NKEN11jwWZ0RuJuURUsX7YJ1K16TwyAeZLbDoeUC3 alk.BENx2QlVPmnLmM.0KwvWkyV9W7ozkARckL9wv2Jve2mc9n8SeTZieviWS0M.xDoTcPs0YzyZ NK6sok8zzyWsnaEWKB.hX3oFIVWcOJAd7eb0dln_vbLbUDVjeJY.4ySBDl_V6Z0I41hCwrYBYn5b KyskpxPaI_Hd1S9NKhZZrhRs.uYyeUarwoC3_43aQHCMj1MXzFiwxjC5y6pPolgdp2z7_TiFPEdG OUOwbBTI- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.gq1.yahoo.com with HTTP; Tue, 9 Aug 2022 18:55:16 +0000 Received: by hermes--production-ne1-6649c47445-zp4l8 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 67d7542a3b0ff56c91b8a724acf0e36c; Tue, 09 Aug 2022 18:55:14 +0000 (UTC) Content-Type: text/plain; charset=utf-8 List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: Looks like the arm 20220805 snapshots are still odd, so probably kern.geom.part.mbr.enforce_chs=0 was still in use From: Mark Millard In-Reply-To: <20220809181513.GG30607@FreeBSD.org> Date: Tue, 9 Aug 2022 11:55:12 -0700 Cc: Warner Losh , "Rodney W. Grimes" , FreeBSD Hackers , freebsd-arm Content-Transfer-Encoding: quoted-printable Message-Id: References: <6AF28022-A8E7-46B3-B64E-99D217E9B6AC@yahoo.com> <0E0083BD-A749-4112-8FDA-62326EA95F8A@freebsd.org> <20220809181513.GG30607@FreeBSD.org> To: Glen Barber , Ed Maste X-Mailer: Apple Mail (2.3654.120.0.1.13) X-Rspamd-Queue-Id: 4M2MhQ53NJz3Wnc X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=q8snKVIa; dmarc=pass (policy=reject) header.from=yahoo.com; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.69.83 as permitted sender) smtp.mailfrom=marklmi@yahoo.com X-Spamd-Result: default: False [-3.23 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.992]; NEURAL_HAM_MEDIUM(-0.74)[-0.741]; MV_CASE(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; MIME_GOOD(-0.10)[text/plain]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; RCVD_IN_DNSWL_NONE(0.00)[98.137.69.83:from]; RCVD_COUNT_THREE(0.00)[3]; RCPT_COUNT_FIVE(0.00)[6]; FREEMAIL_FROM(0.00)[yahoo.com]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; TO_DN_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+]; MIME_TRACE(0.00)[0:+]; MLMMJ_DEST(0.00)[freebsd-hackers@freebsd.org] X-ThisMailContainsUnwantedMimeParts: N On 2022-Aug-9, at 11:15, Glen Barber wrote: > On Tue, Aug 09, 2022 at 02:06:14PM -0400, Ed Maste wrote: >> On Sun, 7 Aug 2022 at 18:43, Glen Barber wrote: >>>=20 >>> Will do. I=E2=80=99ll commit the suggested change to main tomorrow. >>>=20 >>> Thank you for your vigilant investigation. >>=20 >> Shall I commit the enforce_chs check now? >> --- >> commit 6ee7d69e6b526f35789b23ba570025f1c3b39c1a >> Author: Ed Maste >> Date: Tue Jul 19 16:47:49 2022 -0400 >>=20 >> release: ensure enforce_chs sysctl is 0 >>=20 >> We do not want CHS-based alignment for VM or SD card release = images. >>=20 >> Sponsored by: The FreeBSD Foundation >>=20 >> diff --git a/release/tools/arm.subr b/release/tools/arm.subr >> index 6e4ae731a0b9..01c5303cd4e1 100644 >> --- a/release/tools/arm.subr >> +++ b/release/tools/arm.subr >> @@ -62,6 +62,10 @@ umount_loop() { >> } >>=20 >> arm_create_disk() { >> + if [ $(sysctl -n kern.geom.part.mbr.enforce_chs) !=3D 0 ]; = then >> + return 1 >> + fi >> + >> # Create the target raw file and temporary work directory. >> chroot ${CHROOTDIR} gpart create -s ${PART_SCHEME} ${mddev} >> if [ "${PART_SCHEME}" =3D "GPT" ]; then >>=20 >=20 > Good question. Do we still want to ensure it is set to '0'? I'm a = bit > confused from the back-and-forth on the original thread. >=20 > If we do want to ensure it is set to '0', yes, please go ahead. >=20 Hopefully this week's experiment with explicitly avoiding BSD and freebsd-ufs having the same offset inside BSD (avoiding both offsets being zero) will allow the UFS labeling to work right: freebsd-ufs being tied to a unique offset inside BSD. I really doubt that using kern.geom.part.mbr.enforce_chs=3D1 to cause the offsets to be different is reasonable, despite that it happens to make them distinct: the freebsd-ufs offset is better controlled explicitly elsewhere. =3D=3D=3D Mark Millard marklmi at yahoo.com