Re: vwarn: libc vs opensolaris/ctf/tools

On Thu, Apr 21, 2022 at 04:57:13PM +0200, stephane rochoy wrote:
> 
> Mark Johnston <markj@freebsd.org> writes:
> 
> > On Thu, Apr 21, 2022 at 04:24:18PM +0200, stephane rochoy wrote:
> >> The vwarn function seems to be defined both in 
> >> lib/libc/gen/err.c
> >> and in cddl/contrib/opensolaris/tools/ctf/common/utils.c. It 
> >> seems
> >> to be ok to workaround the problem by enclosing OpenSolaris'
> >> implementation in #if 0.
> >
> > I think that'd be fine.  We can remove it outright.
> >
> > Your build is statically linking ctfdump, due to the use of 
> > NO_SHARED.
> > I can reproduce the failure locally, but as far as I can tell 
> > the
> > problem has been there for a long time.
> 
> Ok, got it.

Fixed in main now:
https://cgit.FreeBSD.org/src/commit/?id=45dd2eaac379e5576f745380260470204c49beac