[Bug 284378] www/webkit2-gtk: interactions with C++ dependencies built with clang/libc++ causes WebProcess crash

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=284378

--- Comment #39 from commit-hook@FreeBSD.org ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/ports/commit/?id=1eeaaa8e063450d0eb8f08df33a6ba338c348825

commit 1eeaaa8e063450d0eb8f08df33a6ba338c348825
Author:     Charlie Li <vishwin@FreeBSD.org>
AuthorDate: 2025-02-01 01:58:37 +0000
Commit:     Charlie Li <vishwin@FreeBSD.org>
CommitDate: 2025-02-01 01:58:37 +0000

    www/webkit2-gtk: remove byteRangeSample from PlatformSample

    The presence of this union member causes the build to fail with our
    libc++ because version 1 ABI's std::pair does not have a trivial
    copy constructor (see D35327). However this code is only used for
    a deprecated plugin only for macOS, and it along with supporting
    code like this have been removed in the main branch upstream, so
    this should hold in the upcoming 2.48 series. For now, only remove
    byteRangeSample as the complete upstream commit does not apply.

    This allows the port to return to using the base system toolchain,
    including libc++, fixing crashes from mangling libc++-built
    dependencies with libstdc++ webkitgtk. While here, remove some
    unused USE_X11 depends to save another PORTREVISION bump.

    Reference:
https://github.com/WebKit/WebKit/commit/d0527fca8fc20cdda907dfdc293323d7283bd262
    PR: 284378
    Reported by: huanghwh[at]gmail[dot]com
    Tested by: eduardo, shamaz.mazum[at]gmail[dot]com (previous iterations)

 www/webkit2-gtk/Makefile                                  |  5 ++---
 .../patch-Source_WebCore_platform_MediaSample.h (new)     | 15 +++++++++++++++
 2 files changed, 17 insertions(+), 3 deletions(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.