From nobody Sat Sep 28 09:48:14 2024 X-Original-To: gnome@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XG2Zk2hgtz5X4hP for ; Sat, 28 Sep 2024 09:48:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XG2Zk0srvz40hV for ; Sat, 28 Sep 2024 09:48:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727516894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wuADpqR9dvlZy1inNbwuOWPwLn/wMo64XCCwzhjTY34=; b=LyBAeNMhB4ZSQjvshalthRgWaQOB9snfUvAUUTr3Jp9X9TEm+VA9eDNl2xA0Do8vZMAQvq QKLs5lrbmIhqcr7bLynWhS8g5SYjbWNL69c17cZuQjJ4fpwVoAkpFbysNtNDIFH012xFrd p5b9atG3dC9wIfE9KlXDWYgZF8KSuvdWCxwZOJrWNoFQeh7GxJ1OyJbOyWJQOwTfrVMjyE 7uiZ1vNwCCBKNUGD2Lv6q3gzA0k/0NezH/n89lsct2gHHHerZqL2pU+vjuVq8s1n2O0xKp laoIpPsJmmWuTPTNiGmbxqpV7+mk98xJdtxIg0Xt+nPnKbBGWixoKRRujos9uQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1727516894; a=rsa-sha256; cv=none; b=juuv1zCkQIdAn99If7Y4U4SydE0osa44xwnVRNAhRf+GOtz3fD1u6cvffJ1sJjqYNSKiVk forUOObPw9rYJDuWeHqlESuWkJLUJ2ORy06P3fwu31poG95EAGxJgb+e7jo6p/QnpgZxe/ TpKTBC/I+FjM5F811qzKaOEJO6hoOhvQx7IkWaYRSfSaDMfOIo69D7adTNYnrvS7WNM44o QCKbsltU5ErSHtpYPquy44QYusB5Q3q4Hnax/gMIk3uPwbGts9c4W0ZgUqGG1pi+HGfK0A drLeXJza1G2hQZPuX+K/ER4IEKW/gLURZaS/gyeotlgoopPey7hyqIV+5meH2w== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XG2Zk0MsSzKBH for ; Sat, 28 Sep 2024 09:48:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 48S9mDjo019777 for ; Sat, 28 Sep 2024 09:48:13 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 48S9mDqN019776 for gnome@FreeBSD.org; Sat, 28 Sep 2024 09:48:13 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: [Bug 281477] audio/libaudiofile: fix build with clang 19, enable tests Date: Sat, 28 Sep 2024 09:48:14 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: gnome@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: GNOME for FreeBSD -- porting and maintaining List-Archive: https://lists.freebsd.org/archives/freebsd-gnome List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-gnome@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D281477 --- Comment #2 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3D7955b1d7ec787bf13f2cfea75e9355a= 3f3e91a53 commit 7955b1d7ec787bf13f2cfea75e9355a3f3e91a53 Author: Dimitry Andric AuthorDate: 2024-09-13 09:11:45 +0000 Commit: Dimitry Andric CommitDate: 2024-09-28 09:43:47 +0000 audio/libaudiofile: fix build with clang 19, enable tests Clang 19 has become more strict about initialization with undefined behavior, resulting in errors similar to: ./SimpleModule.h:126:40: error: in-class initializer for static data member is not a constant expression 126 | static const int kMinSignedValue =3D -1 << kScaleBits; | ~~~^~~~~~~~~~~~~ ./SimpleModule.h:176:22: note: in instantiation of template class 'signConverter' requested here 176 | transform::signedToUnsigned>(src, dst, count); | ^ ./SimpleModule.h:183:5: note: in instantiation of function template specialization 'ConvertSign::convertSignedToUnsigned' requested here 183 |=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20 convertSignedToUnsigned(src, dst, count); | ^ This is because left-shifting negative values is undefined. Replace -1 with ~0u which results in the expected value. While here, add a few other patches to remove warnings about undefined left-shifts, and add support for the "make test" target. PR: 281477 Approved by: maintainer timeout (2 weeks) MFH: 2024Q3 audio/libaudiofile/Makefile | 3 +++ audio/libaudiofile/files/patch-gtest_gtest.h (new) | 11 ++++++++ ...patch-libaudiofile_modules_SimpleModule.h (new) | 11 ++++++++ .../files/patch-test_FloatToInt.cpp (new) | 11 ++++++++ .../files/patch-test_IntToFloat.cpp (new) | 11 ++++++++ audio/libaudiofile/files/patch-test_NeXT.cpp (new) | 29 ++++++++++++++++++= ++++ audio/libaudiofile/files/patch-test_Sign.cpp (new) | 20 +++++++++++++++ 7 files changed, 96 insertions(+) --=20 You are receiving this mail because: You are the assignee for the bug.=