From nobody Tue Nov 12 14:42:43 2024 X-Original-To: gnome@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xnq0218Pfz5cctt for ; Tue, 12 Nov 2024 14:42:58 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xnq016Y95z4PK2; Tue, 12 Nov 2024 14:42:57 +0000 (UTC) (envelope-from asomers@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a99fa009adcso387985166b.0; Tue, 12 Nov 2024 06:42:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731422575; x=1732027375; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oo29lpTzGwlsH7r6eDAs8ZntACMBTRAfAhYsy9Qe8bs=; b=kRaWH/cXw1VSZ4qcq8Wf25Ru5rO++QWRunPruhMHW2FuYAaxhMptyBfWIM6LE9r5VJ cpSd93hlW/P2/0Cmbd/gEZNMSBgRA/9bO48DP2uOrQPl3gis0icBSI91DzteMboFFrI6 CY/SN76Rw0wwVRWtrZ7vi/nXTiUw32rWdTCPfuHZ/MRFacVZpqV/ap0Nes2pQAaWjFVX xLVwZUgE4eFZoac1rr2U8sYm5dpvpPFcaP+ay/YwDw9VUVr7ZSPRbgtQEQcQ7j2P9+mA ikK4Z84yxbpQUSf6anFV8QmEVYW0ZKhKPoBTfbj4ef2ldCuctb40e0bdtvUImd+szzE/ LH1Q== X-Forwarded-Encrypted: i=1; AJvYcCWIeh9rdCYKMHshQcxCCFeTCHF0+aPXlOPf7dU9GMxWK/Qu3rWcDtF+OKKrdqtCkcVby1MmFA==@freebsd.org, AJvYcCXmrjOrMEJ+SW5e5K4RnhtNMc4gZIOQefLrdZQW7dsbatYaGOnerM2kUpFvR26hgTbgo14Juo4=@freebsd.org X-Gm-Message-State: AOJu0Yx0XNBM8iT0q9VL3cae2wAMsN4DK3qaBGvBVbcf9cMS8OpYdAkk KjRP0Ej0GY5VfGnSDKou7f2+Vx2tGxY6/9AgrJLnQiwbYU/0MpSij6hGYYA8yO5j4ptWH7acBpJ gR4Js7JodV3fVSPRQ4BEnoVlNwQCbJA== X-Google-Smtp-Source: AGHT+IHgAZkkH3amdrLjsmKV4TzghExZhTn/q75bWgjbzR72zjugDMRWEpOdOJktL39BYOncL1CybN6uV7u7/I5NSps= X-Received: by 2002:a05:6402:42ca:b0:5cb:aad6:145c with SMTP id 4fb4d7f45d1cf-5cf0a31103cmr22318969a12.8.1731422575202; Tue, 12 Nov 2024 06:42:55 -0800 (PST) List-Id: GNOME for FreeBSD -- porting and maintaining List-Archive: https://lists.freebsd.org/archives/freebsd-gnome List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-gnome@FreeBSD.org MIME-Version: 1.0 References: In-Reply-To: From: Alan Somers Date: Tue, 12 Nov 2024 07:42:43 -0700 Message-ID: Subject: Re: Requiring SSE2 by default for i386 To: Nuno Teixeira Cc: gnome@freebsd.org, ashish@freebsd.org, dmgk@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4Xnq016Y95z4PK2 X-Spamd-Bar: ---- There's no connection between this port and Rust. The only connection is that "Due to Rust, more than 500 ports now require SSE2 by default on i386, so we may as well make it on-by-default for other ports too". Your commit LGTM. On Tue, Nov 12, 2024 at 2:23=E2=80=AFAM Nuno Teixeira = wrote: > > Hello, > > As upstream defaults to use SSE2 on amd64/i386 I'm reproducing it on port= . > I still don't get what this port has to do with rust SSE2 i386 requiremen= t as it doesn't use rust code, but I think we will get some performance imp= rovements. > > If you need any change on port, please feel free to change it. > > https://cgit.freebsd.org/ports/commit/?id=3D78b13cb9ecb8c0c0f59e09ba8d026= 4d023d6f688 > > Cheers, > > > Alan Somers escreveu (segunda, 11/11/2024 =C3=A0(s)= 20:50): >> >> Sounds good. >> >> On Mon, Nov 11, 2024 at 1:30=E2=80=AFPM Nuno Teixeira wrote: >> > >> > Ah, sure. >> > >> > I will add OPTIONS_DEFAULT=3DSSE2 and check if it will be problems for= amd64 and aarch64. >> > If everything ok then use this option since upstream default is SSE2 o= n by default. >> > >> > Sorry as I misread past email. >> > >> > Alan Somers escreveu (segunda, 11/11/2024 =C3=A0= (s) 16:25): >> >> >> >> I don't know what that "QMAKE_ON" part means. But when I do "make >> >> config", it shows the SSE2 option disabled by default. >> >> >> >> On Mon, Nov 11, 2024 at 5:20=E2=80=AFAM Nuno Teixeira wrote: >> >> > >> >> > (...) >> >> > >> >> > Just took a look at port Makefile and it's alleady set: >> >> > >> >> > OPTIONS_DEFINE=3D SSE2 >> >> > SSE2_DESC=3D Enable SSE2 optimization >> >> > SSE2_QMAKE_ON=3D CONFIG+=3Dsse2 >> >> > SSE2_QMAKE_OFF=3D CONFIG+=3Dno-sse2 >> >> > >> >> > This port does not have rust code. >> >> > >> >> > Alan Somers escreveu (domingo, 10/11/2024 =C3= =A0(s) 15:51): >> >> >> >> >> >> On Sun, Nov 10, 2024 at 7:00=E2=80=AFAM Nuno Teixeira wrote: >> >> >> > >> >> >> > Hello, >> >> >> > >> >> >> >> graphics/fraqtive >> >> >> > >> >> >> > >> >> >> > https://github.com/mimecorg/fraqtive/blob/02914797f47d26c4098f4a= 3a945716b13998a8cc/INSTALL#L43 >> >> >> > Upstream says SSE2 is enabled by default. >> >> >> > >> >> >> > What should we do here? >> >> >> >> >> >> Just set OPTIONS_DEFAULT_i386=3DSSE2 or OPTIONS_DEFAULT=3DSSE2 in = the port Makefile. >> >> > >> >> > >> >> > >> >> > -- >> >> > Nuno Teixeira >> >> > FreeBSD UNIX: Web: https://FreeBSD.org >> > >> > >> > >> > -- >> > Nuno Teixeira >> > FreeBSD UNIX: Web: https://FreeBSD.org > > > > -- > Nuno Teixeira > FreeBSD UNIX: Web: https://FreeBSD.org