[Bug 279280] graphics/gegl: sort out Makefile and pet portclippy

From: <bugzilla-noreply_at_freebsd.org>
Date: Sat, 01 Jun 2024 20:46:48 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279280

--- Comment #4 from Vladimir Druzenko <vvd@FreeBSD.org> ---
(In reply to Daniel Engberg from comment #3)
> Drop the omp hack?
Replaced:
.if !exists(/usr/include/omp.h)
A
.else
B
.endif
with:
.if exists(/usr/include/omp.h)
B
.else
A
.endif

> Please move GEGL_VER= and PLIST_SUB+ (remove + too?) above MESON_ARGS for consistency with the tree
portclippy said MESON_ARGS must be before PLIST_SUB.

> Place *_IMPLIES= below MESON_ARGS
portclippy said *_IMPLIES= must be before even *_BUILD_DEPENDS=

> tools/gobj2dot.py isn't called during build (needs shebangfix)?
Nothing changed around this.
/usr/ports/graphics/gegl/work/gegl-0.4.48/tools/gobj2dot.py: "#!/usr/bin/env
python3"
If add to shebangfix, than changed to "#!/usr/local/bin/python".
Testing with and without and then compare build logs.

-- 
You are receiving this mail because:
You are the assignee for the bug.