From nobody Thu Apr 11 18:07:57 2024 X-Original-To: gnome@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VFnjs0j5Dz5HqZ6 for ; Thu, 11 Apr 2024 18:08:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VFnjr458Fz4ctF for ; Thu, 11 Apr 2024 18:08:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1712858880; a=rsa-sha256; cv=none; b=xE/Xtn4xQ1BRxBPbaIsjlu6rZhVoYUUlNf/mEzH+AGHLvfTHucUAR+1CphxsIUPI+B6UZc Xg6hkXxB0hf50XB/pQiFFL+ZVebdOsGEFadRuTRO/aCKLbmWEFr6XR2Y24BEXg6Sbx8r/M s5wCC66cRGvbc1CywdIVeXxVpqtuy3dsg5GYOizs87Wh2y1dLb2mRbaz73EdKcx9Zo9kbe Q+5c7hdwaLbD47vM064yScDclnqCul/by/EvGHSJzYJQvRncqgYUbXXZhmxS9y8/9H5ZWg KvA5NHOoAesCQ9iuWjJNxAk3THc8h9kKbnCDYBajbim8pVdEQ/K7OJDzIl5Ecw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1712858880; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yBFwNcL1VheaGcTID9d5wNbii8S0dMYEjt9R0iLsjAc=; b=h9yI2jn5Oda3HotbuH98HkCs6TF8K2r7yR21SXvYJz3GaAlike/slfl3KptgGt13+Y/ygi +w39WXg3nqRIb1SfgoMhsHzeoYkz+mlP8g5oOAIUySyZJrH4h/+SItd29sNVCqR9tf1/uL DMS/8wjo/LeoHeshMMhAeJ5VZ5vAo3rKwNNJg9IDw13bSIT9P8jdAEESgWOTet3OT7Fb0A oo5lmlCVsmn2O4cWdyXGFtSxxWR39JyxLs94Va7+KAHrZEF+nskq0uhKUDu/u/ewW+29Y5 BsF51Z69alGOLmxbooDgE9iNyUGRk/C482nOBHrIsN4ED+bUQgLuAhyUrtDo/Q== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VFnjr3jYYzGd0 for ; Thu, 11 Apr 2024 18:08:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 43BI80IP052197 for ; Thu, 11 Apr 2024 18:08:00 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 43BI809a052196 for gnome@FreeBSD.org; Thu, 11 Apr 2024 18:08:00 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: [Bug 194727] uaudio device gets disconnected, and hangs usb until everything using /dev/mixer* is closed Date: Thu, 11 Apr 2024 18:07:57 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: usb X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: christos@freebsd.org X-Bugzilla-Flags: mfc-stable14? mfc-stable13? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: GNOME for FreeBSD -- porting and maintaining List-Archive: https://lists.freebsd.org/archives/freebsd-gnome List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-gnome@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D194727 --- Comment #91 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D44e128fe9d92c1a544b801cb56e907a66= ef34691 commit 44e128fe9d92c1a544b801cb56e907a66ef34691 Author: Christos Margiolis AuthorDate: 2024-04-11 18:06:50 +0000 Commit: Christos Margiolis CommitDate: 2024-04-11 18:06:50 +0000 sound: Implement asynchronous device detach Hot-unplugging a sound device, such as a USB sound card, whilst being consumed by an application, results in an infinite loop until either the application closes the device's file descriptor, or the channel automatically times out after hw.snd.timeout seconds. In the case of a detach however, the timeout approach is still not ideal, since we want all resources to be released immediatelly, without waiting for N seconds until we can use the bus again. The timeout mechanism works by calling chn_sleep() in chn_read() and chn_write() (see pcm/channel.c) in order to send the thread to sleep, using cv_timedwait_sig(). Since chn_sleep() sets the CHN_F_SLEEPING flag while waiting for cv_timedwait_sig() to return, we can test this flag in pcm_unregister() (called during detach) and wakeup the sleeping thread(s) to immediately kill the channel(s) being consumed. Sponsored by: The FreeBSD Foundation MFC after: 2 months PR: 194727 Reviewed by: dev_submerge.ch, bapt, markj Differential Revision: https://reviews.freebsd.org/D43545 share/man/man4/snd_uaudio.4 | 11 +---------- sys/dev/sound/pcm/dsp.c | 2 +- sys/dev/sound/pcm/mixer.c | 11 ----------- sys/dev/sound/pcm/sound.c | 24 ++++++++++-------------- sys/dev/sound/usb/uaudio.c | 13 +++---------- 5 files changed, 15 insertions(+), 46 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=