[Bug 273649] textproc/enchant: Fix build with LLVM/clang++ 16

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273649

--- Comment #3 from Olivier Certner <olivier.freebsd@free.fr> ---
(In reply to Alexey Dokuchaev from comment #2)

The only errors this build produces are these:
> error: ISO C++17 does not allow 'register' storage class specifier
and there are dozens of them.

They are harmless, and in fact were fixed upstream long ago (in 2017).  For
there reasons, I don't think it's worth it to patch them out.  I'll also note
that upstream explicitly requires C++11 in the newer 1.6.1 version (from 2017)
of the 1.x series.

So I tend to think that this should go in as is (perhaps using
"USE_CXXSTD=c++11" instead).  An alternative would be to upgrade to 1.6.1, but
this can be done afterwards with no harm (it is likely to take more time, and
right now I can't).

As to why there are no fallouts, for 13, that's normal since apparently the
last builds were with clang 14.0.5, whereas I have clang 16.0.6 (I'm on
13-STABLE from end of August).  The latter clang version is also the one used
for the latest pkg builds for 14-STABLE, where no fallouts can be seen, and I'm
not sure why.  FWIW, I'm using the ports tree at
38c671e45e4bae21a0199079d08273c1f171e1d4.

What do you think?

-- 
You are receiving this mail because:
You are the assignee for the bug.