From nobody Sat Oct 07 14:03:07 2023 X-Original-To: gnome@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S2n7b72QQz4wT4P for ; Sat, 7 Oct 2023 14:03:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S2n7b5rf8z4XFX for ; Sat, 7 Oct 2023 14:03:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696687387; a=rsa-sha256; cv=none; b=Bi8sph4PLfpHNQh/Y9x+lLI7pYWX/zGHwb3zKSzAsROAvmUtiPrNOoe261g09N7cnYQH3n 7jWqZgN44hz4dmlCbxxIhVy3isVJIkqXA9YnfmdJn4y8MaD56YSztE/1Fg99tyoHI/Nhtz Qc4RmNXxIbMpARdnjfb1bdM7aApSAwvyF6ckm3pred6QQmthrwNTUpPOHWWxJZmzArtNkv jJed+9uGX8qZxCxleCtdWeeoIgsyosX6a44b7kl0kH680Q3B83jvIi4DQ+CzbtYmdiUdgm grGstP4bfyHFTvxzwPzDY5mEMDrOjAALL1EApdlWO/i/AvyJxUPLV3aNgaAz6g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696687387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CCgTzEV4sZfFf/Mawd8JgZoVDLmbL5ywlynnSTZcL1E=; b=rD5F/xVotmZRmFenzMWab4WojEFtbPFweIhNcdw8PKDIa4DkY+qwskPPfEN125+Us7uBXG HXIWxn60IH1gRH8Lnit9/Muv/a1wXp7bxJrMPSPYz7u1tudcNMJ0flQuXE9EEZNMHfJBd6 Ad6a4ogzVGNzZKY5i0HM6aYSFa6824mgfwFoGjlkYfCuRWoebPuHb3L3SdIz6E2V9ICtyi 8NGOyhXaxURpW6In9tfH9lZ7qaxIuIkpFJTCrmoQ2ytHiERYmOayTIsynmZvNoQcrhB38o N41h99h7tgkuTt0/uyhnngZqCLOzYpk8qwSCiAsViAaYzZS2mncpZ2if1GT86g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S2n7b4tcczZG5 for ; Sat, 7 Oct 2023 14:03:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 397E37eP060571 for ; Sat, 7 Oct 2023 14:03:07 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 397E37dS060570 for gnome@FreeBSD.org; Sat, 7 Oct 2023 14:03:07 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: [Bug 274329] x11-toolkits/libwnck3: fix warnings, and build with lld 17 Date: Sat, 07 Oct 2023 14:03:07 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: dim@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: gnome@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: GNOME for FreeBSD -- porting and maintaining List-Archive: https://lists.freebsd.org/archives/freebsd-gnome List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-gnome@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274329 Bug ID: 274329 Summary: x11-toolkits/libwnck3: fix warnings, and build with lld 17 Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: gnome@FreeBSD.org Reporter: dim@FreeBSD.org Assignee: gnome@FreeBSD.org Flags: maintainer-feedback?(gnome@FreeBSD.org) Building x11-toolkits/libwnck3 with lld 17 results in the following link errors: cc -o libwnck/libwnck-3.so.0.3.0 libwnck/libwnck-3.so.0.3.0.p/meson-generated_.._wnck-enum-types.c.o libwnck/libwnck-3.so.0.3.0.p/meson-generated_.._libwnck-resources.c.o libwnck/libwnck-3.so.0.3.0.p/application.c.o libwnck/libwnck-3.so.0.3.0.p/class-group.c.o libwnck/libwnck-3.so.0.3.0.p/pager.c.o libwnck/libwnck-3.so.0.3.0.p/screen.= c.o libwnck/libwnck-3.so.0.3.0.p/selector.c.o libwnck/libwnck-3.so.0.3.0.p/tasklist.c.o libwnck/libwnck-3.so.0.3.0.p/util= .c.o libwnck/libwnck-3.so.0.3.0.p/window-action-menu.c.o libwnck/libwnck-3.so.0.3.0.p/window.c.o libwnck/libwnck-3.so.0.3.0.p/wnck-image-menu-item.c.o libwnck/libwnck-3.so.0.3.0.p/workspace.c.o libwnck/libwnck-3.so.0.3.0.p/xutils.c.o libwnck/libwnck-3.so.0.3.0.p/pager-accessible.c.o libwnck/libwnck-3.so.0.3.0.p/pager-accessible-factory.c.o libwnck/libwnck-3.so.0.3.0.p/workspace-accessible.c.o libwnck/libwnck-3.so.0.3.0.p/workspace-accessible-factory.c.o -Wl,--as-need= ed -Wl,--no-undefined -Wl,-O1 -shared -fPIC -Wl,--start-group -Wl,-soname,libwnck-3.so.0 -fstack-protector-strong -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -Wl,-rpath,/usr/local/lib -Wl,-rpath-link,/usr/local/lib -Wl,--version-script,/wrkdirs/share/dim/ports/x11-toolkits/libwnck3/work/li= bwnck-3.36.0/libwnck/libwnck-3.map -lm /usr/local/lib/libcairo.so /usr/local/lib/libXext.so /usr/local/lib/libXrender.so /usr/local/lib/libX11.so /usr/local/lib/libglib-2.0.so /usr/local/lib/libintl.so /usr/local/lib/libgobject-2.0.so /usr/local/lib/libgtk-3.so /usr/local/lib/libgdk-3.so /usr/local/lib/libharfbuzz.so /usr/local/lib/libpangocairo-1.0.so /usr/local/lib/libpango-1.0.so /usr/local/lib/libatk-1.0.so /usr/local/lib/libcairo-gobject.so /usr/local/lib/libgdk_pixbuf-2.0.so /usr/local/lib/libgio-2.0.so /usr/local/lib/libstartup-notification-1.so /usr/local/lib/libXRes.so -Wl,--end-group ld: error: version script assignment of 'global' to symbol '__progname' failed: symbol not defined ld: error: version script assignment of 'global' to symbol 'environ' fail= ed: symbol not defined cc: error: linker command failed with exit code 1 (use -v to see invocati= on) Commit bf6718d6938e added patch-libwnck_libwnck-3.map a long time ago, but it is unclear why. Remove the patch so the undefined symbols are no longer referenced in the linker script. While here, fix two warnings about incorrectly defined header guards: In file included from ../libwnck/pager-accessible-factory.c:20: ../libwnck/pager-accessible-factory.h:19:9: warning: '__WNCK_PAGER_ACCESSIBLE_FACTORY_H__' is used as a header guard here, follo= wed by #define of a different macro [-Wheader-guard] 19 | #ifndef __WNCK_PAGER_ACCESSIBLE_FACTORY_H__ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../libwnck/pager-accessible-factory.h:20:9: note: '__WBCK_PAGER_ACCESSIBLE_FACTORY_H__' is defined here; did you mean '__WNCK_PAGER_ACCESSIBLE_FACTORY_H__'? 20 | #define __WBCK_PAGER_ACCESSIBLE_FACTORY_H__ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | __WNCK_PAGER_ACCESSIBLE_FACTORY_H__ ../libwnck/workspace-accessible-factory.h:19:9: warning: '__WNCK_WORKSPACE_ACCESSIBLE_FACTORY_H__' is used as a header guard here, followed by #define of a different macro [-Wheader-guard] 19 | #ifndef __WNCK_WORKSPACE_ACCESSIBLE_FACTORY_H__ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../libwnck/workspace-accessible-factory.h:20:9: note: '__WBCK_WORKSPACE_ACCESSIBLE_FACTORY_H__' is defined here; did you mean '__WNCK_WORKSPACE_ACCESSIBLE_FACTORY_H__'? 20 | #define __WBCK_WORKSPACE_ACCESSIBLE_FACTORY_H__ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | __WNCK_WORKSPACE_ACCESSIBLE_FACTORY_H__ --=20 You are receiving this mail because: You are the assignee for the bug.=