From nobody Thu Oct 27 22:33:57 2022 X-Original-To: gnome@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Mz0pF3NNrz4gKMl for ; Thu, 27 Oct 2022 22:33:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Mz0pF1Lh1z3WVY for ; Thu, 27 Oct 2022 22:33:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Mz0pF0Nh5zFVj for ; Thu, 27 Oct 2022 22:33:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 29RMXuNE074914 for ; Thu, 27 Oct 2022 22:33:56 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 29RMXu9v074913 for gnome@FreeBSD.org; Thu, 27 Oct 2022 22:33:56 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: [Bug 267393] net-im/libnice: Add GNUTLS option Date: Thu, 27 Oct 2022 22:33:57 +0000 X-Bugzilla-Reason: AssignedTo CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: feature, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: gnome@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: GNOME for FreeBSD -- porting and maintaining List-Archive: https://lists.freebsd.org/archives/freebsd-gnome List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-gnome@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1666910037; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lZgcpBGNFabVdYHtBiw9JQqWCL5qQQJQBgOjVtx0s4M=; b=Clb+UWJxkfnuRDQWlFSMQ2w3N38Y08jzlqynBdi5DYCPvvb4hHDaXbXHy9DViO/IHuKZKa oemOrWV2DHptAQXCJjIbKWLf569B31xtq2llbwWQSf7zPZnKuBwOfpEVShMSbhUQ1c7ODt gDb6l/JzTQ27MkiwogFVf6dY9JqiPMLQPly8Ag2BbHVYEZw2iN27KaKd6CXvB2aSGARyC9 Ozgj0FthtMQtDSedE1q2tSNXOpy/vHyRI1atfALFZV28E+wyJGK3Slk7Xmz/04LdDexBd5 8CKbMAAzMqZeVB+3C2dyVj8CZQrLJ8RUTFyf/es3WS3Nj/dWrcxK/BOlKlIMGg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1666910037; a=rsa-sha256; cv=none; b=ZL6tz8NQGt+nLh99xzhpj9toDhnnQyg8L6D55ahIOQUBcKE6yMqspUOtrOIxe1kKIA2sNV 5ipN7troyLvewV3atH6A+6A3JWR9XmESD2jwYdT2qNxrEMJy+Wptxi8lXQ7+Xpd+89Dz8T wF5S+a5sxINVd4UbDl9cdNVu0wrFetySMhKAF/iNg1p1cDpqEW39FzQzw80egqA+C9m54D YL0cJcrCB0gOhJ17X93ARUtDoQE1BNQGP4z1sF3oF2ZOjkGKUkKmxlkQoxlHO5U6OPRAFj WrjmsBTQWOwMUQUclUqNEbco3JvPnbWgS5Q1LODfTXrFpJf6NmLLc9uyffBJXg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D267393 --- Comment #2 from Kubilay Kocak --- Thank you for the patch Jonathan. Some review items: 1) The build should be tested in these cases: - GNUTLS=3DOFF and - gnutls (only) is installed (not via *_DEPENDS) - openssl (only) is installed (not via *_DEPENDS) - gnutls (and) openssl are installed (not via *_DEPENDS) 2) Consider An SSL library group with two mutually exclusive options, one GNUTLS the other OPENSSL Note: This can either be in the form of - OPTIONS_SINGLE (one choice *must* be selected) - OPTIONS_RADIO (none or one choice can be selected) If libnice supports a build configuration without ssl library support at al= l, OPTIONS_RADIO is more appropriate. If not, OPTIONS_SINGLE is the way to go 3) The current port Makefile doesn't set USES=3Dssl. In the case where GNUTLS=3DOFF, or the grouped option OPENSSL is selected, it should probably= use USES=3Dssl[:...] with appropriate variables from that file. --=20 You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.=