From nobody Mon Dec 12 13:53:54 2022 X-Original-To: gnome@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NW34y6Pqnz4kS9W for ; Mon, 12 Dec 2022 13:53:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NW34y2pxCz4FW7 for ; Mon, 12 Dec 2022 13:53:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1670853234; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lQFXVAMgFsQ1a1A1dpJfSrvqSjeC2L3CItFixri6nU8=; b=PgtEN7LoLyT+BZVY3XECtFDC+/eGN0oFOSnCQStDbSpqPc36XQpxtAGgn8gAwG7sTCSJDK qD2EDG6gCcds095eoiYuzJtCF/8O8sNl1BnTlah034PpVMkF6+oi98c7blIXzBmSiA+XTq Ny0W86HIRmvudEbHQBxd8ryYUVVaF1KQUTcPTVXpO1b7z6IqkJy4iqgkCGgJ5AoWPw/pXH kMspE+rSR17lliXZO0AW4SSW1ZuqIskCdwVnzsTOskFDiL1mHF3Bc5xJz0z66D/pwVh6sc G5w5W3nHYmTcneYakzK5UvpaKrwR6tQFeDbfKwZVY+bxsZzanExnmcR8N3tTpQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1670853234; a=rsa-sha256; cv=none; b=W+SDacajUz7AHu50ER9JOeE2kV4gnRM8uDhLexemK9SYR8sYkD/4xPCGz/PH9/1+dK+jlr 1u74izpWCfvMKN1R4+GI0cUJvCKTiZHnRK5tR/96G4eK31yvlnq8IGt60oAw5/RHbCJeqB L0G6n3BDMQIi9TRq2+ODtLIs3ToqKfT7KLkquR7QWKJuAVpnuRgmQkAXVgiGRnusWEHN/B tcpF03QGmbWo9t/jW6pE7UbnrB2zI+obHqwoWw4DLTROFWqNlktnx2ztUc2Yq/IYTQaGeC 8/hGmg0OZnVpNOhMTVFsIOhz6uWkzEDsjNCTfkcaZi1bsAGX6UbXNrbi2MG/Zw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NW34y1scFzcNH for ; Mon, 12 Dec 2022 13:53:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 2BCDrsst037455 for ; Mon, 12 Dec 2022 13:53:54 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 2BCDrs62037454 for gnome@FreeBSD.org; Mon, 12 Dec 2022 13:53:54 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: maintainer-feedback requested: [Bug 268329] lang/gjs: fix build with clang/libc++ 15 Date: Mon, 12 Dec 2022 13:53:54 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: gnome@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: GNOME for FreeBSD -- porting and maintaining List-Archive: https://lists.freebsd.org/archives/freebsd-gnome List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-gnome@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N Bugzilla Automation has asked freebsd-gnome (Nobody) for maintainer-feedback: Bug 268329: lang/gjs: fix build with clang/libc++ 15 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D268329 --- Description --- During an exp-run for llvm 15 (see bug 265425), it turned out that lang/gjs failed to build with clang and libc++ 15: In file included from ../test/gjs-tests.cpp:11: In file included from /usr/include/c++/v1/random:1689: In file included from /usr/include/c++/v1/__random/discrete_distribution.h:18: In file included from /usr/include/c++/v1/numeric:167: In file included from /usr/include/c++/v1/functional:515: In file included from /usr/include/c++/v1/__functional/boyer_moore_searcher.h:24: In file included from /usr/include/c++/v1/array:127: In file included from /usr/include/c++/v1/algorithm:1851: In file included from /usr/include/c++/v1/__algorithm/ranges_sample.h:13: In file included from /usr/include/c++/v1/__algorithm/sample.h:18: /usr/include/c++/v1/__random/uniform_int_distribution.h:162:5: error: sta= tic assertion failed due to requirement '__libcpp_random_is_valid_inttype::value': IntType must be a supported integer type static_assert(__libcpp_random_is_valid_inttype<_IntType>::value, "Int= Type must be a supported integer type"); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../test/gjs-tests.cpp:71:16: note: in instantiation of template class 'std::uniform_int_distribution' requested here return std::uniform_int_distribution(lowest_value)(gen); ^ ../test/gjs-tests.cpp:942:30: note: in instantiation of function template specialization 'Gjs::Test::get_random_number' requested here char32_t random_char32 =3D get_random_number(); ^ This is because std::uniform_int_distribution is only defined for strict integer types, such as short, int, etc. Use std::uniform_int_distribution instead, and cast the result back t= o a char32_t.