From nobody Thu Oct 03 05:17:18 2024 X-Original-To: git@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XK0Kt4Qwkz5Xhmr for ; Thu, 03 Oct 2024 05:17:22 +0000 (UTC) (envelope-from mfechner@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XK0Kt3lV0z4WGq; Thu, 3 Oct 2024 05:17:22 +0000 (UTC) (envelope-from mfechner@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727932642; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=b7vCxQ1YHdSYWYIptWmofp4bHW+fNnldJvj9i52Pvmc=; b=pdD1e6WMhS9XxjCT25d+mpzsuGi3tFYkzxmX13/+/T83nBQZH9kj0BNWCUILzk3uqBUHt0 m6GdBg4tqLtZQeiDO2rH6xRsV8OYrmdUx1VXPC8qdII7EZZii3yrdpr+uzlhpE/RI6og9A HjbeFLbFDzcl1iD3zmOqvq3AZid36ENVS8lWSv+ORGmWTNvQsuavOL5jyQ09b9pdW3uFSt 0sNCj320PJZQyW6lFtjkA4IPLejcvMAGAEa2XwQDaenBnIarlBH8zu0eP8ejlKDlPlHzja KAXqq3G0wjJq+2gMJYNybCC3yao+H04q1ZcA5kp9FRKGJm0On8dibtDHCl/CCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727932642; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=b7vCxQ1YHdSYWYIptWmofp4bHW+fNnldJvj9i52Pvmc=; b=eImB31y9R82DACLYU7Bcn+nPd/BJ0pizWp3pVfRzjDDadI/sAskrzMulKy3eepOuBUZiGQ BCOlRwSBA6IEFSQwvSLyXe21gDwDfx9lYWbYdZfYsmXdHKz8030ioQR6Nifr0376XUpgBU +XljwP7TyVF5hESLUsmvxshHuxCSfdmqgxS2z77jdibmPhrv4a486n/S3vYonqTnCVPx7B tDPdWtKiwnw5aASUpwqOxAW5bJPYEn8sCDr3BuyVi/2rhzy9evtagPT0R5XcrSdGqKBdg6 9UEaeQm07u2uYF80dM5eQlrerT5W1IniDHbrBC2vPgaXYgZMGkaaaDt1cPOmJw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1727932642; a=rsa-sha256; cv=none; b=lmzcNvL82wXVwo7Ccde74D496goEnZGP+hgnmG3b7w32xG7h5kbqmjojy7SbaQMqXFFsFA 7u4VeAy1fg60EXfeEg8PmD2nDAqaUwxQBbCbFfPGlXxgMwF+KukRmw0zUML0FY1hOOj4KP 7xY0+pKrJwLvalCStvwjNhe4fHHJVwX6E93ogFZrl9acKQIm4LaVi/kqY1FUZ1VNkRf/5M /bj6EaTVx9g4mP1tPeatcr7bcKQy4K0Taxo2MqJ7F7MslY51LooJFEEkEZOQGx2SiLkMhM tAZd5wfYwCj8LZyAOsu0Vp3Cfp3o2R8uLVhJIngjLNAcpwwiE8al4NsWkCqWQQ== Received: from [192.168.1.151] (unknown [212.108.151.172]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mfechner) by smtp.freebsd.org (Postfix) with ESMTPSA id 4XK0Ks3H6szfXw; Thu, 3 Oct 2024 05:17:21 +0000 (UTC) (envelope-from mfechner@freebsd.org) Content-Type: multipart/alternative; boundary="------------aomzzQpQ743f3UEqrEnAUGp3" Message-ID: Date: Thu, 3 Oct 2024 08:17:18 +0300 List-Id: Discussion of git use in the FreeBSD project List-Archive: https://lists.freebsd.org/archives/freebsd-git List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-git@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Impossible to push my ports directory to my CI/CD pipeline To: Brooks Davis Cc: Dave Cottlehuber , git@freebsd.org References: <483fb132-0d1c-443a-9b44-b7f2f087fb3d@freebsd.org> Content-Language: en-US From: Matthias Fechner In-Reply-To: This is a multi-part message in MIME format. --------------aomzzQpQ743f3UEqrEnAUGp3 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Am 01.10.2024 um 22:37 schrieb Brooks Davis: > I've done some searching at it looks like there are gitlab options to > disable the various checks. I don't admin any gitlab instances so don't > know how to translate this into something you can use, but: > > https://gitlab.com/gitlab-org/gitlab-foss/-/blob/master/lib/gitlab/checks/lfs_check.rb?ref_type=heads > > seems to show an lfs_check.objects_missing knob to disable the precommit > check. You might also need to disable some lfs integrity checks. at least in gitlab it is possible to disable LFS feature per repository. It can be found in the repository under: Settings -> General -> Visibility, project features, permissions -> Repository -> Git Large File Storage (LFS) After I disabled this and saved the changes I was able again to push into my gitlab and all my pipelines are working again. So at least for gitlab I can confirm it is working, maybe other tooling will continue to have problems. Just reverting a commit does not change the history and the history reference these LFS objects which do not exist. I can imagine that other projects, using FreeBSD ports, will maybe see a similar problem. If a rewrite of the ports repository is an option should be decided by the git team, but I think that is the only clean way to get LFS objects out of the repository. I would squash the two commits (the one that added the LFS object and the one that removed it again) into a single commit, like an interactive rebase can do this. But as that will rewrite the complete history from this point on it is maybe not an option. Gruß Matthias -- "Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the universe trying to produce bigger and better idiots. So far, the universe is winning." -- Rich Cook --------------aomzzQpQ743f3UEqrEnAUGp3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit
Am 01.10.2024 um 22:37 schrieb Brooks Davis: 
I've done some searching at it looks like there are gitlab options to
disable the various checks.  I don't admin any gitlab instances so don't
know how to translate this into something you can use, but:

https://gitlab.com/gitlab-org/gitlab-foss/-/blob/master/lib/gitlab/checks/lfs_check.rb?ref_type=heads

seems to show an lfs_check.objects_missing knob to disable the precommit
check.  You might also need to disable some lfs integrity checks.
at least in gitlab it is possible to disable LFS feature per repository.
It can be found in the repository under:

Settings -> General -> Visibility, project features, permissions -> Repository -> Git Large File Storage (LFS)

After I disabled this and saved the changes I was able again to push into my gitlab and all my pipelines are working again.

So at least for gitlab I can confirm it is working, maybe other tooling will continue to have problems.

Just reverting a commit does not change the history and the history reference these LFS objects which do not exist.
I can imagine that other projects, using FreeBSD ports, will maybe see a similar problem.

If a rewrite of the ports repository is an option should be decided by the git team, but I think that is the only clean way to get LFS objects out of the repository.
I would squash the two commits (the one that added the LFS object and the one that removed it again) into a single commit, like an interactive rebase can do this.

But as that will rewrite the complete history from this point on it is maybe not an option.

Gruß
Matthias

-- 

"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs, and the universe trying to
produce bigger and better idiots. So far, the universe is winning." --
Rich Cook
--------------aomzzQpQ743f3UEqrEnAUGp3--