From nobody Thu Nov 25 23:21:24 2021 X-Original-To: freebsd-git@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 73CE318AE8F6 for ; Thu, 25 Nov 2021 23:21:35 +0000 (UTC) (envelope-from pauamma@gundo.com) Received: from mail.gundo.com (gibson.gundo.com [75.145.166.65]) by mx1.freebsd.org (Postfix) with ESMTP id 4J0YmG3SfTz3nY4 for ; Thu, 25 Nov 2021 23:21:34 +0000 (UTC) (envelope-from pauamma@gundo.com) Received: from webmail.gundo.com (variax.gundo.com [75.145.166.70]) by mail.gundo.com (Postfix) with ESMTP id AAB634C5005; Thu, 25 Nov 2021 17:21:27 -0600 (CST) List-Id: Discussion of git use in the FreeBSD project List-Archive: https://lists.freebsd.org/archives/freebsd-git List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-git@freebsd.org MIME-Version: 1.0 Date: Thu, 25 Nov 2021 23:21:24 +0000 From: Pau Amma To: Warner Losh Cc: freebsd-git Subject: Re: CI Piplines In-Reply-To: References: <6e72c7e11f43c844f44b343f3aadf040@gundo.com> User-Agent: Roundcube Webmail/1.4.8 Message-ID: X-Sender: pauamma@gundo.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4J0YmG3SfTz3nY4 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of pauamma@gundo.com designates 75.145.166.65 as permitted sender) smtp.mailfrom=pauamma@gundo.com X-Spamd-Result: default: False [-2.84 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FREEFALL_USER(0.00)[pauamma]; FROM_HAS_DN(0.00)[]; RWL_MAILSPIKE_GOOD(0.00)[75.145.166.65:from]; R_SPF_ALLOW(-0.20)[+a]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[gundo.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; RCVD_IN_DNSWL_MED(-0.20)[75.145.166.65:from]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.44)[-0.438]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:7922, ipnet:75.144.0.0/13, country:US]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On 2021-11-20 06:02, Warner Losh wrote: > On Sat, Nov 13, 2021 at 12:16 PM Pau Amma wrote: > >> It would be nice IMO to have something that upon submitting or >> updating >> a phabricator doc review (or maybe even before that, eg when >> committing >> to a documenter's local git clone) would do some or all of: >> - checking for AsciiDoc markup errors >> - checking for bad link targets >> - optionally, based on individual preferences and document language, >> checking spelling >> - rendering, at least to HTML >> - checking the result against accessibility guidelines (ideally, this >> would use the AsciiDoc source for ease of interpretation and >> correction >> of problems, but most accessibility checkers I know of only deal with >> HTML, and some checks, like color and contrast, are only possible when >> HTML and CSS are both available) >> - reporting to the author in near real-time (an email within a few >> minutes would probably be enough) >> >> I don't know, however, whether that would take phabricator action, CI >> action, or both. > > Phabricator has the ability to kick off Jenkins runs. > https://github.com/uber/phabricator-jenkins-plugin > has what looks like the necessary plugin. And > https://www.linkedin.com/pulse/using-phabricator-jenkins-git-continuous-automated-pre-commit-tayal > has a walkthrough of setting it up. Would you be able to look into what > it > would take > to apply those instructions to our phabricator setup? We have a 'test' > phabricator > setup that I think you can get access to if you wanted to try to do all > the > things > listed above. Thanks for the links. I had a first look at the plugin, and https://github.com/uber/phabricator-jenkins-plugin#jenkins-setup says some of the configuration is on the Jenkins side, not the Phabricator side. So my first question is: does FreeBSD have a Jenkins sandbox as well? (If you don't know, who does?) And who do I ask for access to the Phabricator sandbox? phab-admin@, phabric-admin@, or whatever the email address for the Phabricator admin people is? I also skimmed through https://www.linkedin.com/pulse/using-phabricator-jenkins-git-continuous-automated-pre-commit-tayal which seems to use a similar method, except it relies on Github instead of the plugin, so I'm setting it aside unless and until FreeBSD goes that route.