From nobody Thu Nov 18 16:46:50 2021 X-Original-To: freebsd-git@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id D494B188B3CB for ; Thu, 18 Nov 2021 16:47:00 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-vk1-xa33.google.com (mail-vk1-xa33.google.com [IPv6:2607:f8b0:4864:20::a33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Hw5LD5HSCz4TkS for ; Thu, 18 Nov 2021 16:47:00 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-vk1-xa33.google.com with SMTP id 84so4173941vkc.6 for ; Thu, 18 Nov 2021 08:47:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jh8ziTjmYlGhQmP6oh2S96xYkEM58xKpIn+B7yN1V7o=; b=f88Cz/rFsbb3BK6wOKLbsJygmW33zxVYXumy9/YQ8T1z/OkfWsoGKl8LyRo7bkYUza OEZocsmfo1N+OaYIetuTeoU9485UnZZ36CHX/2EPLtRP63lkJApc1+iTzuecDgSQThwT 5iRVATCqZEGRxX3i0GSWWS3XAzKg9MYUwY1PjftMDeahDL0wVzLBBQDaRwWz12rAAwJF 28B16EtVVim3Ge+Gp1ODXIMZZ/Wna5/HBrpsT/LH+mdiMYl3R/tKDOdPdLNPDJF4g8yg JIaOzBunv0e0CEPl4s8IGg6V6AOklHW3zWEJEyHcETMN0FyacrJ/rhfxRfdAZnRvx1+5 E5Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jh8ziTjmYlGhQmP6oh2S96xYkEM58xKpIn+B7yN1V7o=; b=h+SWjW051YVV2TCzzlTLPFRMA9Krrv7SLIi8CphwIJM5EvJzmD9t0+ht3kjib30aYT mL0HmG35WgKTpm2782cegOfhNgbDOtCS5Q8B+HIwZbJDPZ1Oql1b7pw5hMES75jjzhLr Y32P136mRKkxADEgM/V6XzMFt2CxjysX16jfQs/YHB9y+b+aiZbKsjFDGh+zAnPZq5TG ckvHSW78ynktSAL5jjCvKAFCRtaGWhMSKvE/QbKhX+Qi9GXzx6+5SBACEbuV7jMWnxac Q3AYmqKTaDA6RFSQET+pUIDiZ5GKpUalIbJXx3CzWR4Tp6TaaEs9XiSugeBf5/YZQGVr kqmg== X-Gm-Message-State: AOAM531Vla9mjHaPTIFDewzBgL8lstgsiv33Qdxc+1uvr7RZZWlxKRg/ d+QzOiQGHlyR0jiSjZ1nTZGeXAWjnhGdeJUqHvP+7Q== X-Google-Smtp-Source: ABdhPJxkVD5H8NA2tHsFz0KoRZasthv+o6IS0KPWL+PJGUB6hZhFQsiOPiDW5XdivgfDIxLZsmpm1v+LB2RD9dBlAu4= X-Received: by 2002:a05:6122:114c:: with SMTP id p12mr105744927vko.21.1637254020193; Thu, 18 Nov 2021 08:47:00 -0800 (PST) List-Id: Discussion of git use in the FreeBSD project List-Archive: https://lists.freebsd.org/archives/freebsd-git List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-git@freebsd.org MIME-Version: 1.0 References: <9766b3e1-fb5d-1993-46e2-057e2567315a@gmail.com> <36020FD7-32A4-4869-B6A2-2622F50F6478@yahoo.com> <20211118162927.GG81740@spindle.one-eyed-alien.net> In-Reply-To: <20211118162927.GG81740@spindle.one-eyed-alien.net> From: Warner Losh Date: Thu, 18 Nov 2021 09:46:50 -0700 Message-ID: Subject: Re: cgit, ages and chronological order To: Brooks Davis Cc: Philip Paeps , Mark Millard , "Ulrich Sp??rlein" , Graham Perrin , freebsd-git Content-Type: multipart/alternative; boundary="00000000000047f07e05d112e827" X-Rspamd-Queue-Id: 4Hw5LD5HSCz4TkS X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: Y --00000000000047f07e05d112e827 Content-Type: text/plain; charset="UTF-8" On Thu, Nov 18, 2021 at 9:29 AM Brooks Davis wrote: > On Thu, Nov 18, 2021 at 12:46:49PM +0800, Philip Paeps wrote: > > On 2021-11-17 06:32:52 (+0800), Mark Millard via freebsd-git wrote: > > > information being based on local git commit timing (and clocks) > > > vs. when the commits are pushed to FreeBSD servers: The display > > > order is from the timing on the FreeBSD servers but the Age is > > > based on the original commit (before the push). The longer the > > > delay between commit and push, the more noticeable the > > > distinction is. > > > > Some projects require a "git rebase --ignore-date" (or "git rebase > > --reset-author-date", which I consider the more obvious spelling) before > > pushing. A hook could potentially reject commits with timestamps that > > are too far off to the server's liking. > > > > I can't comment on whether we need or want either the policy or the hook > > or both. I don't really have a problem with the default Git behaviour > > here. > > I always use --ignore-date when curating pre-commit. I'd like to at > an absolute minimum enforce that CommitDate be newer than the previous > commit and older than the push time. There is no good argument for > allowing non-linear CommitDates since the only requirement is that the > committer have their clock set more or less correctly. > At the very least, we should document this suggestion. I also like the idea of enforcing this as a pre-commit hook, but before that we should have it the docs... wouldn't hurt to have a section in the docs about each of the major points we enforce to tell people have to fix the issue should they encounter it. Warner --00000000000047f07e05d112e827--