From nobody Sat Oct 19 12:57:04 2024 X-Original-To: geom@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XW1mw1wyqz5b4C8 for ; Sat, 19 Oct 2024 12:57:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XW1mv6RF0z4PgG for ; Sat, 19 Oct 2024 12:57:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729342623; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wa9GHSnDJEed8Ke4mUFJqvwn+QMx9EbysNMFKTl2CKg=; b=wRk25bCQZo5izutxhXJ8vLXUJ3mfpiiy5kerzJrsUhYQfFDQHN5H2NZ4ahXI4hCfY05i5D qkwVtlEKMhgl7p6QzqD8I1LJRP2szEDTqJ++8UZq5eQC0YalPzFWTKGvi/CFHlHVlzxKua P1i5v4hBm64xNssdZeoRZ2BC0hYn/MMGUE8m5SGfn8ORK+yR8povKMWwCE27B7iFa3MBNV nTlYyiPUnkZYEw0wMlE3dN+Pf1iP0iCFoKw1uDI2ctpThpL7Ux5ZITQLhWLm1iIP30tEoF sM9tpOjAsCTWT+boRMqcWrGG4askJzIF6IRWDsKCJWzkQJ2+X5I+CCmSXGfArQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1729342623; a=rsa-sha256; cv=none; b=fClnH5JoHS8c+Z9uvlbu5dE5p3fWWWOoaNoOnV/ezKIkh9170fNR/n/J6LzTZ2cTkAaOKw nDDVHAO/+twe/nq7CYdaz/CC0Wz1+YVo1hlYDLUcWloLQg1gCsQNRZrG+ArWCfzOheLh1q 2Kl8z+YheS5IcLJWjWUu3eS8HiMRvIm23UVOlxTJtEdWY/49qldTQy+L9mhWOVocycMY10 qnyi9NmRWR7S99/1Fe+/UOija7r+h1iOtu3n4MADzy5SNCalGV1BdgVhbv6PCtcU9TdS2f rSGvQ3GqLI/42S1JrVmC/ybyzSdcGuE27BHQy8cyJRMYzzml7qFb49lUe5agUQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XW1mv5xqMzJZK for ; Sat, 19 Oct 2024 12:57:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 49JCv3V2081971 for ; Sat, 19 Oct 2024 12:57:03 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 49JCv3au081970 for geom@FreeBSD.org; Sat, 19 Oct 2024 12:57:03 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: geom@FreeBSD.org Subject: [Bug 238814] geom: topology lock being dropped in dumpconf of gate, raid, & raid3 Date: Sat, 19 Oct 2024 12:57:04 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: crash, needs-patch, needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: geom@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: GEOM-specific discussions and implementations List-Archive: https://lists.freebsd.org/archives/freebsd-geom List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-geom@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238814 --- Comment #8 from commit-hook@FreeBSD.org --- A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D23b44ad101ca2381186aa565b6c04a978= c02a35e commit 23b44ad101ca2381186aa565b6c04a978c02a35e Author: Mark Johnston AuthorDate: 2024-10-04 14:53:57 +0000 Commit: Mark Johnston CommitDate: 2024-10-18 12:27:13 +0000 ggate: Avoid dropping the GEOM topology lock in dumpconf In general it's not safe to drop the topology lock in these routines, as GEOM assumes that the mesh will be consistent during traversal. However, there's no reason we can't hold the topology lock across calls to g_gate_release(). (Note that g_gate_hold() can be called with the topology lock held.) PR: 238814 MFC after: 2 weeks (cherry picked from commit b37b2543a23b44c78f6d78823dcfcedba46570db) sys/geom/gate/g_gate.c | 3 --- 1 file changed, 3 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=