From nobody Fri May 27 19:23:24 2022 X-Original-To: geom@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 197751B4E00A for ; Fri, 27 May 2022 19:23:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4L8vq06CsNz4q36 for ; Fri, 27 May 2022 19:23:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id ABEEA2860D for ; Fri, 27 May 2022 19:23:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 24RJNOsM099153 for ; Fri, 27 May 2022 19:23:24 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 24RJNOBE099152 for geom@FreeBSD.org; Fri, 27 May 2022 19:23:24 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: geom@FreeBSD.org Subject: [Bug 263979] [meta] UFS / FFS / GEOM crash (panic) tracking Date: Fri, 27 May 2022 19:23:24 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: crash, needs-qa, tracking X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: mckusick@FreeBSD.org X-Bugzilla-Flags: mfc-stable13? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: GEOM-specific discussions and implementations List-Archive: https://lists.freebsd.org/archives/freebsd-geom List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-geom@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1653679404; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fXtWFVXD+ok1m3R72HnAk4jttAs5U+aYUeHIHU2+7VQ=; b=Ic3bq8GIM9H7oi1HyuQ03m3IWNEBz9UctcSscAHOXJH0FRNvn4Q5kNRNZhk+Zk9YCqAqWv pdnEN8vHLZhJGiL3UgM5c0doOmeGBsV8kdP9bUJQLJ0lPUYoTmGPn09C6QxJKeVQDuC1UI nncRsgOOIjPS8A5gQ/qcfTEJqxfGnvreRkGWK//JDER5p5UV/BXE9j4gWScPuF4uBFMQuv xRz54OXwNv0yVzFeZ3OQhttMIUrePxsnh7xquU+1Xv+9gsLVMNUwICCFzSIgei5oWPowMX 3xOwC+ohdzaCa8rQTzsj4e+mXnPJjmJsgfAKFii3CEycxontzqLUfG7Zvh1dFQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1653679404; a=rsa-sha256; cv=none; b=bTd8uz4uh4NsDnOtryaCGefsI6mKqrmqTISz6EJ4BUHhQHuOsj8cFHGBen9UQ4n5GekO58 p3BwwV16AWamVzulxANDc/RQcB83yUTz6wuZCls5yhU0IjZEiGfZ5juoIvajHCkYQ1+JcM LBOsWIYvNgwZ6twWH9Z8DkWAoyRaJKb+ZkybzbPLWAGcivXQRF976uLViziUyCdwupyy4T S72a0fjaXFJhK9F0LdQZDC5mcMpMYjlPQCVUUreOtqhL8Rm3988Oj4AD8AMO467LzEpzNC M+vEAYuwsbk+6GBzkMDWwt684b6bflKhlMfnZCl6ZrDR432RID4nYS/SGZhl7g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263979 --- Comment #6 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D076002f24d35962f0d21f44bfddd34ee4= d7f015d commit 076002f24d35962f0d21f44bfddd34ee4d7f015d Author: Kirk McKusick AuthorDate: 2022-05-27 19:21:11 +0000 Commit: Kirk McKusick CommitDate: 2022-05-27 19:22:07 +0000 Do comprehensive UFS/FFS superblock integrity checks when reading a superblock. Historically only minimal checks were made of a superblock when it was read in as it was assumed that fsck would have been run to correct any errors before attempting to use the filesystem. Recently several bug reports have been submitted reporting kernel panics that can be triggered by deliberately corrupting filesystem superblocks, see Bug 263979 - [meta] UFS / FFS / GEOM crash (panic) tracking which is tracking the reported corruption bugs. This change upgrades the checks that are performed. These additional checks should prevent panics from a corrupted superblock. Although it appears in only one place, the new code will apply to the kernel modules and (through libufs) user applications that read in superblocks. Reported by: Robert Morris and Neeraj Reviewed by: kib Tested by: Peter Holm PR: 263979 MFC after: 1 month Differential Revision: https://reviews.freebsd.org/D35219 sys/ufs/ffs/ffs_subr.c | 163 +++++++++++++++++++++++++++++++++++++++++++--= ---- 1 file changed, 146 insertions(+), 17 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=