From nobody Sun Sep 01 06:35:44 2024 X-Original-To: gecko@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WxMb55MfWz5TdW5 for ; Sun, 01 Sep 2024 06:35:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WxMb527ywz4hCc for ; Sun, 1 Sep 2024 06:35:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725172545; a=rsa-sha256; cv=none; b=AwQoES75Y2ewJLIQZL/c0+O+wZaNnnkl0jRuiuXxZVAhI+D9WWGxJsCY9GCb7pv6mxgKGA rBe26iT9qRAs/gWADU7wMmLaovDKscmEajua6mCwl2sWlChg29SJMz7UrOEHlM+VrSXDZ/ HXEEaj2qRC6mUO32u9wtOApYvaSpkm4EhyVRWcqm4CBvrt5q+WxcgYJ9ww9przLiBw+cJN avfZGbCXhPuD/sJDfRn/LNLl51Lgpwkf5W7Xj5EUpcLdJp5us/c0TCSjNfUdsf4onQpgxa Ah3T4wPEafzcZlBuAU95J5u4aIrx2DRyF4phXEJbTmHqXZwb22QkpG8jueaBnw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725172545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5SSTXUIjop5g567oHMiBPhxZTY5eURUWz91LWJ35kGQ=; b=aHxSPHbbf1302MDLDj2rv40Q64pSBid1zQCb6BlMS+SyO0eu8cfOwLJb2yg7ULA/6fYZ18 FlFHN1wsIuYisosqVi4nfWpSaEM6ZMhgdJWqQfZZeGwVft3yDunK57+vUi00D0C7kq1Tuo m/59+pzO9jhgpHpJR+qbRHzbFlPrRS4SIhxLrDkAUv+DprE0bFnOvb03zPj3gLeNzg2zoF +tTCcpwolal9ezlXLGfeZCrFrY6tdq3Ig/Ogtt3jKjZhvfuxiqJDMjx85eIIgYAeMg/Ex2 HvjlkKHtLFA2q+DjcoHI3q3swEk278Rw0M/i/TpQCJ++TuxuUYpRm8RhARUEGg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WxMb51cLNzJ7G for ; Sun, 1 Sep 2024 06:35:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 4816Zjkv076945 for ; Sun, 1 Sep 2024 06:35:45 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 4816Zjv2076944 for gecko@FreeBSD.org; Sun, 1 Sep 2024 06:35:45 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: gecko@FreeBSD.org Subject: [Bug 281179] devel/llvm1[789] removal of arm_bf16.h from _BE_INCS_ARM in Makefile's was incorrect Date: Sun, 01 Sep 2024 06:35:44 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: marklmi26-fbsd@yahoo.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: gecko@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Gecko Rendering Engine issues List-Archive: https://lists.freebsd.org/archives/freebsd-gecko List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-gecko@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D281179 Bug ID: 281179 Summary: devel/llvm1[789] removal of arm_bf16.h from _BE_INCS_ARM in Makefile's was incorrect Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: gecko@FreeBSD.org Reporter: marklmi26-fbsd@yahoo.com Assignee: gecko@FreeBSD.org Flags: maintainer-feedback?(gecko@FreeBSD.org) For devel/llvm1[789]: clang/lib/Basic/Targets/ARM.cpp has: if (HasBFloat16) { Builder.defineMacro("__ARM_FEATURE_BF16", "1"); Builder.defineMacro("__ARM_FEATURE_BF16_VECTOR_ARITHMETIC", "1"); Builder.defineMacro("__ARM_BF16_FORMAT_ALTERNATIVE", "1"); } (The above is because target ARM in llvm covers AArch32, even for armv8.) clang/lib/Basic/Targets/AArch64.cpp has: if (HasBFloat16) { Builder.defineMacro("__ARM_FEATURE_BF16", "1"); Builder.defineMacro("__ARM_FEATURE_BF16_VECTOR_ARITHMETIC", "1"); Builder.defineMacro("__ARM_BF16_FORMAT_ALTERNATIVE", "1"); } (The above is because target AArch64 in llvm covers only AArch64, not AARch= 32.) The above suggests bf16 support has 32-bit support (even if it is armv8 32-bit). Looking for AArch32 state in: DDI0487K_a_a-profile_architecture_reference_manual.pdf it says (via the AArch32 column of a table): BF16 Supported if FEAT_AA32BF16 is implemented. So the documentation agrees about there being AARch32 support possible. (There is also AArch64 support possible.) Also: I've tested that putting arm_bf16.h back in the llvm18 Makefile to allow part of a poudriere-devel based armv7 www/firefox build attempt to work instead of getting an error about an include referencing not finding the file. So the deletion lead to part of a port/package build being broken. (The port has more broken than just that.) For reference the tested change was: -_BE_INCS_ARM=3D arm_cde.h arm_fp16.h arm_mve.h arm_neon.h arm_sme= .h \ +_BE_INCS_ARM=3D arm_bf16.h arm_cde.h arm_fp16.h arm_mve.h arm_neo= n.h arm_sme.h \ (My Makefile has other personal differences from the official=20 Makefile as well.) --=20 You are receiving this mail because: You are the assignee for the bug.=