From nobody Wed Mar 16 18:11:09 2022 X-Original-To: gecko@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 108D01A24E65 for ; Wed, 16 Mar 2022 18:11:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KJdcs5LwDz4nCV for ; Wed, 16 Mar 2022 18:11:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 98F451B223 for ; Wed, 16 Mar 2022 18:11:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 22GIB96s092417 for ; Wed, 16 Mar 2022 18:11:09 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 22GIB9wv092416 for gecko@FreeBSD.org; Wed, 16 Mar 2022 18:11:09 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: gecko@FreeBSD.org Subject: maintainer-feedback requested: [Bug 262598] www/firefox www/firefox-esr mail/thunderbird: fix build with libc++ 14 Date: Wed, 16 Mar 2022 18:11:09 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: gecko@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Gecko Rendering Engine issues List-Archive: https://lists.freebsd.org/archives/freebsd-gecko List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-gecko@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1647454269; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mgp3PcfR3z5H6LmGFER5w0VBjh8Tist+tulrtmO7Nbo=; b=uLAT2aYflAHdZM1VwQY7AD1CDRlD7FqJHpFsPvw3GkJBLE3lD1o91Aiys/bB8MPzThfLoT 3OJcuWvYSg/oGgzB6w1lcTIJ+iO0FXqo3gwB0F1CfS9oc2FTtr72xLGVj/BpMLNI5DNdWz 80S21PnFc2E1wDEUhTROEY49iVFo1WughSd9Nk5rfbcRMvUHTuAD1GIRYtdulywhlhOIeu +Eo7gbvAkvuBGdCsoMb61wdh9KCjHjeBUVPn6uPJvZMswvru5MdLPTODeIwLLyaQT3gnLD 7gyajPtGYcFJXeJ87OpPgKuu6ubcU08OZBUoyIp4LzAuilqghZZXcZRser2Gtw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1647454269; a=rsa-sha256; cv=none; b=GVpRjLMpz/8iLsIbX0z/vbusWsDZpIqVykcqNKDR3V1mEu0vFzN1LNTnosBCdZ/4VVwQGo gxKxsa8oDGRsKdj2u3ciY0j/IoZMp3XxWEaZmeLRkeaVts47vQNx+gMU95Qhi8BU0OUBs+ h5fXRoQ/SDA4enCt0LP6NE4MFswofJzbVFxrgFplpm+FtWxzqlG5XJe5ieutZMHZHL1PhF giB4LTXuEieFiGTdZDcSqCPFibb2rOe5rRs73YOGjS/9csb4T8i2qlal+e0va85QwH0xbl DKz0qPB+qaOoscyAodir+kZshbD9Z+KX9RUiZYlQaay6rqD1AKuaGCU2k0Xpnw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N Bugzilla Automation has asked freebsd-gecko (Nobody) for maintainer-feedback: Bug 262598: www/firefox www/firefox-esr mail/thunderbird: fix build with li= bc++ 14 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D262598 --- Description --- During an exp-run for llvm 14 (see bug 261742), it turned out that www/fire= fox, www/firefox-esr and mail/thunderbird fail to build when the base system lib= c++ version is >=3D 14: In file included from Unified_cpp_accessible_aom0.cpp:2: In file included from /wrkdirs/usr/ports/www/firefox/work/firefox-97.0/accessible/aom/AccessibleN= ode. cpp:6: In file included from /wrkdirs/usr/ports/www/firefox/work/firefox-97.0/accessible/aom/AccessibleN= ode. h:10: In file included from /wrkdirs/usr/ports/www/firefox/work/.build/dist/include/nsTHashMap.h:11: In file included from /wrkdirs/usr/ports/www/firefox/work/.build/dist/include/mozilla/RefPtr.h:13: In file included from /wrkdirs/usr/ports/www/firefox/work/.build/dist/include/mozilla/DbgMacro.h:= 13: In file included from /wrkdirs/usr/ports/www/firefox/work/.build/dist/include/mozilla/Span.h:30: In file included from /wrkdirs/usr/ports/www/firefox/work/.build/dist/stl_wrappers/string:64: In file included from /wrkdirs/usr/ports/www/firefox/work/.build/dist/system_wrappers/string:3: /usr/include/c++/v1/string:1721:9: error: call to '__throw_length_error' is ambiguous _VSTD::__throw_length_error("basic_string"); ^~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/c++/v1/__config:824:15: note: expanded from macro '_VSTD' #define _VSTD std ^ /wrkdirs/usr/ports/www/firefox/work/.build/dist/include/mozilla/throw_gcc.h= :92: 59: note: candidate function MOZ_THROW_NORETURN MOZ_THROW_EXPORT MOZ_THROW_INLINE void __throw_length_er= ror( ^ /usr/include/c++/v1/stdexcept:253:6: note: candidate function void __throw_length_error(const char*__msg) ^ [... a bunch more of these ...] This is because Mozilla attempts to redefine a number of internal C++ libra= ry functions, which was always a little dodgy, but is now broken with libc++ 14 and higher. If propose fixing this by avoiding to redefine those functions, when compil= ing for libc++. (It is likely that it will still work with e.g. GNU libstdc++.)